X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7B36D.2ACE42DE@onstor-exch02.onstor.net>; Wed, 20 Jun 2007 10:59:45 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Coverity question
Date: Wed, 20 Jun 2007 10:59:45 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E030E3522@onstor-exch02.onstor.net>
In-Reply-To: <20070620115635.3f44b777@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Coverity question
Thread-Index: AcezbLm+qPHP5oPGSTep+kSYBgOYJwAAFenw
From: "Mike Lee" <mike.lee@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>
Cc: "dl-Data-Manag" <dl-Data-Management@onstor.com>

Yep, a donkey who's afraid of memory leaks...
Yeah, probably will change it that way, if I get the okay from Jobi...

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, June 20, 2007 11:57 AM
To: Mike Lee
Cc: dl-Data-Manag
Subject: Re: Coverity question


Use malloc/free, for crying out loud.  You program like a donkey.

On Wed, 20 Jun 2007 11:31:44 -0700 "Mike Lee" <mike.lee@onstor.com>
wrote:

> Hi Guys:
>=20
> I'm getting the following finding from Coverity:
>=20
> From sm-fs/btree/btree.c:
>=20
> Event stack_use_local_overflow: Local variable "index": stack use of
> 1816 bytes exceeds maximum single use of 1024 bytes 154 uint32
> index[FS_BTREE_MAXKEYS];=20
>=20
> I am pretty certain that FS_BTREE_MAXKEYS is greater than 1024 by
> design: #define FS_BTREE_MAXKEYS \
>     ((PAGE_SIZE/(sizeof (fs_Extent) + sizeof (uint64) + sizeof
> (uint16))) - 1)
>=20
>=20
> So, does anyone have a recommendation on what to do with this issue?
>=20
> Thanks.
>=20
> -Mike
