X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7B1D7.AB1F5912@onstor-exch02.onstor.net>; Mon, 18 Jun 2007 10:37:05 -0800
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C7B1D7.AB1F5912"
Content-class: urn:content-classes:message
Subject: Review Request OPenbsd build changes
Date: Mon, 18 Jun 2007 10:37:05 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02215867@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Review Request OPenbsd build changes
Thread-Index: Acex16sWntG1OBL7RlqLTfQtSpA2/A==
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C7B1D7.AB1F5912
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Andy,
   I have a handful of changes to Makefiles I would like your to review.
These are in my p4 client larrys-r14-dmip whose workspace is local to
linux-compile.

The file that requires the most consideration is the top level Makefile.
The compile for the cheetah kernel was broken by changing the default
build to cougar. I put a fix in for that but it requires the user to set
SSC on the command line when make is invoked. Since I use a script to
launch the openbsd build this is not a problem for me since I was
already doing this. However Ken may not be setting SSC on the command
line for his builds.
Just FYI.

The Makefiles in libxml2-2.6.20/build-cross were created by the
configure program so they are pretty ugly. I needed to hack them up to
keep make from trying to run the configure and config.status programs
again.

Change 24239 by larrys@larrys-r14-dmip on 2007/06/15 11:01:04 *pending*

        Top level Makefile still needs to build Cheetah Kernel. We need
to=20
        continue to build all product variants in this branch. Setting
the
        default SSC value to COUGAR and making it the default build type
        is probably premature at this point.

        Disabled auto configuration and configure from libxml2 build.
The=20
        Makefiles are checked in, no need to try to recreate them.
        Reviewed by: nobody

Affected files ...

... //depot/cougar/Makefile#4 edit
... //depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/Makefile#1
edit
...
//depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/include/libxml/Mak
efile#1 edit
...
//depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/python/Makefile#1
edit
...
//depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/xstc/Makefile#1
edit

------_=_NextPart_001_01C7B1D7.AB1F5912
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Dus-ascii">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7652.24">
<TITLE>Review Request OPenbsd build changes</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/rtf format -->

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">Andy,</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp; I have a handful of changes to Makefiles I =
would like your to review. These are in my p4 client</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> <FONT SIZE=3D2 =
FACE=3D"Arial">larrys-r14-dmip</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial"> whose workspace is local to =
linux-compile.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">The =
file that requires the most consideration is the top =
level</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> =
<FONT SIZE=3D2 FACE=3D"Arial">Makefile</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">.</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial"> The compile for the =
cheetah kernel was broken by changing the default build to cougar. I put =
a fix in for that but it requires the user to set SSC on the command =
line when make is invoked. Since I use a script to launch the openbsd =
build this is not a problem for me since I was alrea</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">dy doing this. However Ken may not be setting SSC on the =
command line for his builds.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Just =
FYI.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">The =
Makefiles in</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"> <FONT SIZE=3D2 =
FACE=3D"Arial">libxml2-2.6.20/build-cross</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial"> were created by the configure program so they are pretty =
ugly. I needed to hack them up to keep make from trying to run the =
configure and config.status programs again.</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">Change 24239 by larrys@larrys-r14-dmip on 2007/06/15 =
11:01:04 *pending*</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Top level =
Makefile still needs to build Cheetah Kernel. We need to =
</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; continue to =
build all product variants in this branch. Setting the</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; default SSC =
value to COUGAR and making it the default build type</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; is probably =
premature at this point.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Disabled auto =
configuration and configure from libxml2 build. The </FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Makefiles are =
checked in, no need to try to recreate them.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Reviewed by: =
nobody</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">Affected files ...</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/cougar/Makefile#4 edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/Makefile#1 =
edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/include/libxml/Make=
file#1 edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/python/Makefile#1 =
edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/cougar/openbsd/src/libxml2-2.6.20/build-cross/xstc/Makefile#1 =
edit</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

</BODY>
</HTML>
------_=_NextPart_001_01C7B1D7.AB1F5912--
