X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7AFB9.6AC8FF67@onstor-exch02.onstor.net>; Fri, 15 Jun 2007 17:55:29 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: review req. for cw_install.in, try #67
Date: Fri, 15 Jun 2007 17:55:29 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02215863@onstor-exch02.onstor.net>
In-Reply-To: <20070615172205.268c156e@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: review req. for cw_install.in, try #67
Thread-Index: AcevrF8QfM7oU/2KRuSdwNThbcBIOQADCqKQ
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Comments inline below...

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, June 15, 2007 5:22 PM
To: Larry Scheer
Subject: Re: review req. for cw_install.in, try #67

On Fri, 15 Jun 2007 16:39:58 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Line 4: "content weighted installation program"
>    Nice save!

The test is surrounded by if BUILD_TYPE =3D opt so it won't check except
for customers or tests of the whole system.  Besides, they can always
just insist on continuing.

-- Except if I happen to grab cw_install.sh that was created by an opt
build then it will execute the code. Here again is another fix me now or
fix me later situation. If you can sell it to QA, well okay then...

> Lines 703-736: Your URL tests are too restrictive for internal use (QA
> and DEV.) If I give the URL:
>
ftp://upgrade:password@10.0.0.143/home/upgrade/DEV/R4.0.0.DEV-BC-061407.
> tar.gz
>=20
> I will get the message; "You have specified the wrong tarball for a
> Bobcat."
>=20
> Which is incorrect, that is a valid bobcat URL. You need to whittle
> down `basename $ftp_url` to get just the pattern you are interested
> with something like sed, cut, or a nested case statement:
>=20
> tarball=3D`basename $ftp_url`
> if [ ${tarball% BC.tar.gz} !=3D
>=20
> You need to whittle down=20
>=20
> You may want to replace the if test logic with case statements so you
> can do pattern matches. Example:
>=20
> case "$hwtype" in
>     BC)
> 	case `basename $ftp_url` in
> 		*${N_VERS}*BC*.tar.gz)
> 			: your golden
> 			;;
> 		*)
> 			record "You have specified the wrong tarball
> for a Bobcat."
> 			hwcross=3D1
> 			;;
> 	esac
> 	;;
> ...
>=20
> If you are proficient with korn/bash shell pattern matching constructs
> which, I am not, you could switch the shell to korn shell and use
> those.
>=20
> Line 917-918: The second nfxsh -e reboot -s is really needed?!! WOW! I
> would not have expected that.

Releases prior to 1.3.1 don't support the -y option, so the first line
will fail on 1.2.X releases, and then will execute the second line,
rebooting the system. Releases after that will never execute the second
line.

-- Ah, I have already purged 1.3.1 from my memory banks...

> -----Original Message-----
> From: Andy Sharp=20
> Sent: Friday, June 15, 2007 12:16 PM
> To: Larry Scheer
> Subject: review req. for cw_install.in, try #67
>=20
> Well, they threw away my original changelist -- those bastards! -- and
> one of the fixes that I guess I checked in before didn't work, so I
> had to fix the fix, and I decided to [quietly] add the ability to
> specify the URL on the command line and have it stick that in as the
> default URL, which I thought would take 2 seconds, but in reality
> took an hour.
>=20
> So we have to re-review.
>=20
> Change 24237 by andys@ripper on 2007/06/15 10:27:32 *pending*
>=20
>         Obfuscate the ftp password after it is typed.
>         Tidy up default FTP URL.
>         Clean up some wording.
>         Tested both FTP and HTTP URLs.
>         Niced down the CF intensive processes to hopefully avoid
>           honking the filer unexpectedly.
>        =20
>         TED00019467 - CW-install : Without a password in the URL
>         TED00019490 - Users should not get the "You have successfully
>         TED00019491 - Reword second paragraph of the install script
>         TED00019489 - cw_install.sh failed to upgrade filer
>         TED00019493 - No check done if user downloads cheetah version
>         TED00019541 - cw_install.sh script from sub#23 fails to reboot
>        =20
>         Reviewed by larrys
>=20
> Affected files ...
>=20
> ... //depot/FB-DELOREAN/nfx-tree/Tools/cw_install.in#2 edit
>=20
