X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7AFA6.7BD9A711@onstor-exch02.onstor.net>; Fri, 15 Jun 2007 15:39:58 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: review req. for cw_install.in, try #67
Date: Fri, 15 Jun 2007 15:39:58 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0221585F@onstor-exch02.onstor.net>
In-Reply-To: <20070615121627.3d750885@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: review req. for cw_install.in, try #67
Thread-Index: AcevgavKMYjQ60rIS2WcWQvh7rFGQwAEe4+w
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Line 4: "content weighted installation program"
   Nice save!

Lines 703-736: Your URL tests are too restrictive for internal use (QA
and DEV.) If I give the URL:
ftp://upgrade:password@10.0.0.143/home/upgrade/DEV/R4.0.0.DEV-BC-061407.
tar.gz

I will get the message; "You have specified the wrong tarball for a
Bobcat."

Which is incorrect, that is a valid bobcat URL. You need to whittle down
`basename $ftp_url` to get just the pattern you are interested with
something like sed, cut, or a nested case statement:

tarball=3D`basename $ftp_url`
if [ ${tarball% BC.tar.gz} !=3D

You need to whittle down=20

You may want to replace the if test logic with case statements so you
can do pattern matches. Example:

case "$hwtype" in
    BC)
	case `basename $ftp_url` in
		*${N_VERS}*BC*.tar.gz)
			: your golden
			;;
		*)
			record "You have specified the wrong tarball for
a Bobcat."
			hwcross=3D1
			;;
	esac
	;;
...

If you are proficient with korn/bash shell pattern matching constructs
which, I am not, you could switch the shell to korn shell and use those.

Line 917-918: The second nfxsh -e reboot -s is really needed?!! WOW! I
would not have expected that.


-----Original Message-----
From: Andy Sharp=20
Sent: Friday, June 15, 2007 12:16 PM
To: Larry Scheer
Subject: review req. for cw_install.in, try #67

Well, they threw away my original changelist -- those bastards! -- and
one of the fixes that I guess I checked in before didn't work, so I had
to fix the fix, and I decided to [quietly] add the ability to specify
the URL on the command line and have it stick that in as the default
URL, which I thought would take 2 seconds, but in reality took an hour.

So we have to re-review.

Change 24237 by andys@ripper on 2007/06/15 10:27:32 *pending*

        Obfuscate the ftp password after it is typed.
        Tidy up default FTP URL.
        Clean up some wording.
        Tested both FTP and HTTP URLs.
        Niced down the CF intensive processes to hopefully avoid
          honking the filer unexpectedly.
       =20
        TED00019467 - CW-install : Without a password in the URL
        TED00019490 - Users should not get the "You have successfully
        TED00019491 - Reword second paragraph of the install script
        TED00019489 - cw_install.sh failed to upgrade filer
        TED00019493 - No check done if user downloads cheetah version
        TED00019541 - cw_install.sh script from sub#23 fails to reboot
       =20
        Reviewed by larrys

Affected files ...

... //depot/FB-DELOREAN/nfx-tree/Tools/cw_install.in#2 edit

