X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7B1D2.F45D3AF6@onstor-exch02.onstor.net>; Mon, 18 Jun 2007 10:03:20 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: code review
Date: Mon, 18 Jun 2007 10:03:20 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E04360566@onstor-exch02.onstor.net>
In-Reply-To: <20070615180827.2386189a@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: code review
Thread-Index: Acevstj/IHZfVDdlTMmEvb9hBCPRYgCHZm2Q
From: "Tim Gardner" <tim.gardner@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>



-----Original Message-----
From: Andy Sharp=20
Sent: Friday, June 15, 2007 6:08 PM
To: Tim Gardner
Subject: Re: code review

On Fri, 15 Jun 2007 14:16:27 -0700 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> > > > On Wed, 13 Jun 2007 16:40:03 -0700 "Tim Gardner"
> > > > <tim.gardner@onstor.com> wrote:
> > > >=20
> > > > > ?P4CLIENT timg-work
> > > > >
> > > > > changes to support chassisd
> > > > >
> > > > > //depot/cougar/linux/kernel/Makefile#4 - edit default change
> > > > > (text) //depot/cougar/linux/kernel/linux-mips-2.6/.config#1 -
> > > > > delete default change
> > > > > (text)
> > >
> >
>
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/reset
> > > .c#1
> > > > > - edit default change
> > > > > (text)
> //depot/cougar/linux/kernel/linux-mips-2.6/bobcat-config#2
> > > > > - edit default change
> > > > > (text)
> > > //depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/mem.c#1
> > > > > - edit default change
> > > > > (text)
> > >
> >
>
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/watchdog/softdog
> > > .c#1

linux/Makefile

     there appear to be no diffs, did perfarce lose them or should you
     revert the file?

> done

linux/kernel/linux-mips-2.6/.config

     line 837, let's make softwatchdog a module, so change 'y' to a 'm'
> done

linux/kernel/linux-mips-2.6/drivers/char/mem.c

     line 555, just say #ifdef CONFIG_MIPS
> done
    =20
     put blank lines around line 619 for readability
> done
    =20
     line 565, just get rid of this ifdef block, because this whole
thing is covered by ifdef CONFIG_MIPS, and so this macro will never be
defined. you can also get rid of the xlate_dev_kmem_ptr macro and the
comment above it, because this code is only for MIPS.  nm, leave it.
> left it as is
    =20
     line 614, write_port function should be merely:
    =20
     if ((*ppos >> 28) =3D=3D 0xb) {
     	return do_write_kmem((void*)*ppos, (unsigned long)*ppos,
buf, count, ppos); } else {
     	return -EINVAL;
     }
    =20
> added the check    =20

linux/kernel/linux-mips-2.6/drivers/char/watchdog/softdog.c

     line 157, improper comment style.  kernel comment style is
     /*
      * comment
      */
     anyway, just explain why, and enclose the printk in #ifndef
CONFIG_ONSTOR_BOBCAT which will be found by any grep -rin onstor
> changed

nfx-tree/code/sendmail/Makefile

     looks good

nfx-tree/code/sm-chassis/Makefile

     nice

nfx-tree/code/sm-chassis/chassis-ui.c

     line 38, switch with line 39, this goes outside the #ifndef CHEETAH
     after all, the comment above says there will be more cougar
changes, and it might come as a shock that the os include only gets
included if it's not doing a cheetah build.  i think.  hmm.  well, the
     #ifndef CHEETAH is pretty ugly, really.
> ok

nfx-tree/code/sm-chassis/chassisd-bc.c

     looks good

nfx-tree/code/sm-chassis/chassisd.c

     looks good

nfx-tree/code/sm-chassis/cm-api-bc.h

     no changes?  p4 error or revert this file.
> reverted

nfx-tree/code/sm-chassis/cm-api.c

     ditto, no changes
> reverted

nfx-tree/code/sm-chassis/cm-util-bc.c

     looks good

nfx-tree/code/sm-chassis/cm.h

     looks good

nfx-tree/code/sm-chassis/linux.h

     looks good

nfx-tree/code/sm-chassis/openbsd.h

     looks good

nfx-tree/code/sm-ea/Makefile

     looks good

nfx-tree/code/sm-event/Makefile

     looks good

nfx-tree/code/sm-event/emrs-api.c

     looks good

nfx-tree/code/sm-event/linux-get-time.c

     ok

nfx-tree/code/sm-event/openbsd-get-time.c

     ok

nfx-tree/code/sm-evm/Makefile

     looks good

nfx-tree/code/sm-file/Makefile

     looks good

nfx-tree/code/sm-fs/Makefile

     looks good

nfx-tree/code/sm-ipmd/Makefile

     looks good

nfx-tree/code/sm-sct/Makefile

     looks good

nfx-tree/code/sm-sdm/Makefile

     looks good

nfx-tree/code/sm-spm/Makefile

     looks good

nfx-tree/code/sm-tape/Makefile

     looks good

nfx-tree/code/ssc-authentication/Makefile

     looks good

nfx-tree/code/ssc-cluster/Makefile

     looks good

nfx-tree/code/ssc-elog/Makefile

     looks good

nfx-tree/code/ssc-genlib/Makefile

     axe the #END at the end ~:^)
> why? this is a generated file

nfx-tree/code/ssc-genlib/genlib-linux.c

     yeesh, lot's of whitespace violations, starting with line 1,
trailing whitespace=20
     line 71 and others, wrap before 80 columns

> don't know what you are talking about. looks fine to me.

nfx-tree/code/ssc-genlib/genlib-openbsd.c

     same comments as the linux one

nfx-tree/code/ssc-genlib/genlib.h

     whitespace violations

nfx-tree/code/ssc-ncm/Makefile

     whitespace

nfx-tree/code/ssc-ndmp/Makefile

     looks good

nfx-tree/code/ssc-nfxnis/Makefile

     looks good

nfx-tree/code/ssc-nfxsh/Makefile

     looks good

nfx-tree/code/ssc-nfxsh/cmd_system-linux.c

     if you say so

nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c

     bye-bye

nfx-tree/code/ssc-nfxsh/cmd_system.c

     looks good

nfx-tree/code/ssc-pm/Makefile

     looks good

nfx-tree/code/ssc-rmc/Makefile

     looks good

nfx-tree/code/ssc-sanm/Makefile

     looks good

nfx-tree/code/ssc-sshd-kb5/Makefile

     looks good

nfx-tree/code/ssc-timekeeper/Makefile

     looks good

nfx-tree/code/ssc-vsd/Makefile

     looks good

nfx-tree/code/ssc-vtm/Makefile

     looks good

