X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7AF8E.D21BB891@onstor-exch02.onstor.net>; Fri, 15 Jun 2007 12:50:34 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: code review
Date: Fri, 15 Jun 2007 12:50:34 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E042A534B@onstor-exch02.onstor.net>
In-Reply-To: <20070614114746.4287ab2d@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: code review
Thread-Index: AceutIApuXbH0GswQpqzX6aEkCpRKQA2kz/w
From: "Tim Gardner" <tim.gardner@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

29244

-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, June 14, 2007 11:48 AM
To: Tim Gardner
Subject: Re: code review

OOh, excellent command

p4 change

creates a changelist, lets you edit the description and pick the files,
and then saves the changelist.  later you can add or delete files to
the changelist, etc.  you can submit the cl#=20


On Thu, 14 Jun 2007 10:45:24 -0700 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> how do I get a cl without doing a submit?
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Thursday, June 14, 2007 9:37 AM
> To: Tim Gardner
> Subject: Re: code review
>=20
> All I wanted was a cl#.
>=20
> On Wed, 13 Jun 2007 21:34:25 -0700 "Tim Gardner"
> <tim.gardner@onstor.com> wrote:
>=20
> > Huh? It is in a single change list. This code review process is what
> > everyone uses. I don't want a separate process just for you. Set
> > your P4CLIENT environemnt variable to timg-work and you can then
> > just run a p4 diff. Doesn't get much simpler than that. If you have
> > a script, then change the script.
> >=20
> > ________________________________
> >=20
> > From: Andy Sharp
> > Sent: Wed 6/13/2007 4:57 PM
> > To: Tim Gardner
> > Subject: Re: code review
> >=20
> >=20
> >=20
> > Hi Tim,
> >=20
> > Please gather into a single changelist so I can use my handy script.
> >=20
> > Thanks,
> >=20
> > a
> >=20
> > On Wed, 13 Jun 2007 16:40:03 -0700 "Tim Gardner"
> > <tim.gardner@onstor.com> wrote:
> >=20
> > > ?P4CLIENT timg-work
> > >
> > > changes to support chassisd
> > >
> > > //depot/cougar/linux/kernel/Makefile#4 - edit default change
> > > (text) //depot/cougar/linux/kernel/linux-mips-2.6/.config#1 -
> > > delete default change
> > > (text)
>
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/reset
> .c#1
> > > - edit default change
> > > (text) //depot/cougar/linux/kernel/linux-mips-2.6/bobcat-config#2
> > > - edit default change
> > > (text)
> //depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/mem.c#1
> > > - edit default change
> > > (text)
>
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/watchdog/softdog
> .c#1
> > > - edit default change (text)
> >=20
> >=20
