X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7AE3D.933F3447@onstor-exch02.onstor.net>; Wed, 13 Jun 2007 20:36:28 -0800
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C7AE3D.933F3447"
References: <BB375AF679D4A34E9CA8DFA650E2B04E042A48E2@onstor-exch02.onstor.net> <20070613165732.5a60d96a@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: code review
Date: Wed, 13 Jun 2007 20:34:25 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E1049E4@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: code review
Thread-Index: AceuFpvBtkqkRtpOQaenXFMeyy8nCwAJq4FD
From: "Tim Gardner" <tim.gardner@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C7AE3D.933F3447
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Huh? It is in a single change list. This code review process is what =
everyone uses. I don't want
a separate process just for you. Set your P4CLIENT environemnt variable =
to timg-work and
you can then just run a p4 diff. Doesn't get much simpler than that. If =
you have a script, then
change the script.

________________________________

From: Andy Sharp
Sent: Wed 6/13/2007 4:57 PM
To: Tim Gardner
Subject: Re: code review



Hi Tim,

Please gather into a single changelist so I can use my handy script.

Thanks,

a

On Wed, 13 Jun 2007 16:40:03 -0700 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> ?P4CLIENT timg-work
>
> changes to support chassisd
>
> //depot/cougar/linux/kernel/Makefile#4 - edit default change (text)
> //depot/cougar/linux/kernel/linux-mips-2.6/.config#1 - delete default
> change
> (text) =
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/reset.=
c#1
> - edit default change
> (text) //depot/cougar/linux/kernel/linux-mips-2.6/bobcat-config#2 -
> edit default change
> (text) //depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/mem.c#1
> - edit default change
> (text) =
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/watchdog/softdog.=
c#1
> - edit default change (text)



------_=_NextPart_001_01C7AE3D.933F3447
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<HTML dir=3Dltr><HEAD><TITLE>Re: code review</TITLE>=0A=
<META http-equiv=3DContent-Type content=3D"text/html; charset=3Dunicode">=0A=
<META content=3D"MSHTML 6.00.2800.1479" name=3DGENERATOR></HEAD>=0A=
<BODY>=0A=
<DIV id=3DidOWAReplyText80090 dir=3Dltr>=0A=
<DIV dir=3Dltr><FONT face=3DArial color=3D#000000 size=3D2>Huh? It is in =
a single change list. This code review process is what everyone uses. I =
don't want</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>a separate process just for =
you. Set your P4CLIENT environemnt variable to timg-work and</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>you can then just run a p4 =
diff. Doesn't get much simpler than that. If you have a script, =
then</FONT></DIV>=0A=
<DIV dir=3Dltr><FONT face=3DArial size=3D2>change the =
script.</FONT></DIV></DIV>=0A=
<DIV dir=3Dltr><BR>=0A=
<HR tabIndex=3D-1>=0A=
<FONT face=3DTahoma size=3D2><B>From:</B> Andy Sharp<BR><B>Sent:</B> Wed =
6/13/2007 4:57 PM<BR><B>To:</B> Tim Gardner<BR><B>Subject:</B> Re: code =
review<BR></FONT><BR></DIV>=0A=
<DIV>=0A=
<P><FONT size=3D2>Hi Tim,<BR><BR>Please gather into a single changelist =
so I can use my handy script.<BR><BR>Thanks,<BR><BR>a<BR><BR>On Wed, 13 =
Jun 2007 16:40:03 -0700 "Tim Gardner"<BR>&lt;tim.gardner@onstor.com&gt; =
wrote:<BR><BR>&gt; &#65279;P4CLIENT timg-work<BR>&gt;<BR>&gt; changes to =
support chassisd<BR>&gt;<BR>&gt; //depot/cougar/linux/kernel/Makefile#4 =
- edit default change (text)<BR>&gt; =
//depot/cougar/linux/kernel/linux-mips-2.6/.config#1 - delete =
default<BR>&gt; change<BR>&gt; (text) =
//depot/cougar/linux/kernel/linux-mips-2.6/arch/mips/onstor/bobcat/reset.=
c#1<BR>&gt; - edit default change<BR>&gt; (text) =
//depot/cougar/linux/kernel/linux-mips-2.6/bobcat-config#2 -<BR>&gt; =
edit default change<BR>&gt; (text) =
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/mem.c#1<BR>&gt; =
- edit default change<BR>&gt; (text) =
//depot/cougar/linux/kernel/linux-mips-2.6/drivers/char/watchdog/softdog.=
c#1<BR>&gt; - edit default change =
(text)<BR></FONT></P></DIV></BODY></HTML>
------_=_NextPart_001_01C7AE3D.933F3447--
