X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C83EB3.F2DD8FBA@onstor-exch02.onstor.net>; Fri, 14 Dec 2007 16:46:37 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 26965 for review
Date: Fri, 14 Dec 2007 16:46:36 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E072012BE@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0714FF62@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 26965 for review
Thread-Index: Acg+iDURro5KjfDIQ+6MHxkdRAvFrQADe+gwAAUTXgAAAeyb4A==
References: <BB375AF679D4A34E9CA8DFA650E2B04E0714FDF7@onstor-exch02.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E0714FF62@onstor-exch02.onstor.net>
From: "Ed Kwan" <ed.kwan@onstor.com>
To: "Ramesh R A. Andavar" <randavar@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>

Instead of using dd to see if the file exists, will "test -r" do the
trick?

> -----Original Message-----
> From: Ramesh R A. Andavar
> Sent: Friday, December 14, 2007 3:44 PM
> To: Ed Kwan; Andy Sharp
> Subject: RE: PERFORCE change 26965 for review
>=20
> Hi Ed/Andy,
>=20
> I have changed the code to check whether /etc/localtime points to an
> invalid file.
>=20
> Please review my code and let me know your comments
>=20
> My P4 client is ramesh_DEV
>=20
> Regards
> Ramesh.
>=20
> -----Original Message-----
> From: Ed Kwan
> Sent: Friday, December 14, 2007 1:27 PM
> To: Andy Sharp; Ramesh R A. Andavar
> Subject: RE: PERFORCE change 26965 for review
>=20
> Interesting point.
>=20
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Friday, December 14, 2007 11:34 AM
> > To: ramesh
> > Cc: Ed Kwan
> > Subject: Re: PERFORCE change 26965 for review
> >
> > On 14 Dec 2007 11:06:55 -0800 ramesh <ramesh@build-k2-depot> wrote:
> >
> > > Change 26965 by ramesh@ramesh_DEV on 2007/12/14 10:59:41
> > >
> > > 	On upgrade the time zone is reset to PST.  Modified the
> > > upgrade script to skip the /etc/localtime.  TED00020604.
> > >
> > > 	Reviewed by Ed Kwan
> > >
> > > Affected files ...
> > >
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#2 edit
> > >
> > >
> > > http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/26965?ac=3D10
> >
> > Hi guys,
> >
> > This change is not sufficient.  If you want to do this, more logic
has
> > to be added, because the timezone files might change on an upgrade,
> > leaving /etc/localtime pointing to nothing.  So you can skip it
here,
> > but after the upgrade is over, you have to check to see if it still
> > points to something, and if it doesn't, reset it to PST.
