X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C83B61.F48730B7@onstor-exch02.onstor.net>; Mon, 10 Dec 2007 11:22:08 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: This change broke cg and bl builds
Date: Mon, 10 Dec 2007 11:22:07 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E06FCE6C2@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02F3DC4F@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: This change broke cg and bl builds
Thread-Index: Acg7XnCAwIgXS6AJQvqzSyzzRbWkUAAAB0xkAACZhPA=
From: "Tim Gardner" <tim.gardner@onstor.com>
To: "Ken Renshaw" <ken.renshaw@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>
Cc: "Paul Hammer" <paul.hammer@onstor.com>,
	"Brian Stark" <brian.stark@onstor.com>


Hi Ken,

Thanks for clearing this up.
Part of the confusion here is that I believe the cougar team was
operating=20
with the expectation that any time the build broke, an email would be
sent.
This is how it was for awhile and then the emails stopped and I don't
recall
seeing an email from you saying you were changing the email policy.
When we originally discussed this you agreed to set it up so that we
would receive an email after every build.
If you are getting complaints about spam then perhaps it would be best
to setup a separate email alias. But I think it is in the best interest
of
every software engineer to see a daily email about the nightly build.
This way we can react quickly to breakages and developers are reminded
that a nightly build is running which will hopefully make them more
sensitive to breaking the build.
I will bring this up at the next software meeting. But for now I would
like you to go back to the original policy of having the nightly build
send an email to dl-software indicating the success or failure
every night.

Tim

> -----Original Message-----
> From: Ken Renshaw
> Sent: Monday, December 10, 2007 11:09 AM
> To: Andy Sharp; Ron Bhanukitsiri
> Cc: Yuvarani Cothandaraman; dl-software; Paul Hammer; Brian Stark; Ken
> Renshaw
> Subject: RE: This change broke cg and bl builds
>=20
> Wrong assumption Andy.
>=20
> Once again I wish people would *ask* instead of *assume*, that's where
a
> lot of perception comes from, and where a lot of communication could
be
> fixed.
>=20
> When I do work on the pass/fail logic for the nightly builds I turn
off
> global notification to keep from spamming you, but always always send
> emails to myself from buildadm irregardless. Once I've tested the
> pass/fail logic by running it a day or so I reenable global
notifications.
> I have dryrun flags in place but the entire process can only be tested
> live nightly, so once in a while I take this route ( last time was
when a
> bsd problem was missed, can't remember the time before that... ).
>=20
> The last email from the build failure is included below ( rest assured
> there were 3 for 3 night's worth ), and it's what I used to trigger
Ron
> into fixing the problem.
>=20
> My problem is that I'm going to get complaints either from the extra
spam
> or from a missed email, so I choose the one that attracts the least
> attention. If you wish I can take the other route, that of always
sending
> the global notifications, and then send out a 'false alarm' email once
it
> has been triaged.
>=20
> But as I said, builds were running, build caught the failure, and
build
> worked with the ensuring developer to correct the action. Sorry it
didn't
> happen before y'all showed back up from the weekend.
>=20
> ------Included message-----------
>=20
> -----Original Message-----
> From: Build Admin [mailto:build@localhost.localdomain]
> Sent: Mon 12/10/2007 6:25 AM
> To: Ken Renshaw
> Subject: Compilation failure in dev branch
>=20
> /perforce/buildlogs/dev/Monday/bl-dbg-compile.log:make[2]: ***
> [../../Build/bl/dbg/Objects/SSC/sm-utils/cmd-utils.o] Error 1
> /perforce/buildlogs/dev/Monday/bl-dbg-compile.log:make[1]: ***
[default]
> Error 1
> /perforce/buildlogs/dev/Monday/bl-dbg-compile.log:make: *** [ssc]
Error 2
> /perforce/buildlogs/dev/Monday/bl-opt-compile.log:make[2]: ***
> [../../Build/bl/opt/Objects/SSC/sm-utils/cmd-utils.o] Error 1
> /perforce/buildlogs/dev/Monday/bl-opt-compile.log:make[1]: ***
[default]
> Error 1
> /perforce/buildlogs/dev/Monday/bl-opt-compile.log:make: *** [ssc]
Error 2
> /perforce/buildlogs/dev/Monday/cg-dbg-compile.log:make[2]: ***
> [../../Build/cg/dbg/Objects/SSC/sm-utils/cmd-utils.o] Error 1
> /perforce/buildlogs/dev/Monday/cg-dbg-compile.log:make[1]: ***
[default]
> Error 1
> /perforce/buildlogs/dev/Monday/cg-dbg-compile.log:make: *** [ssc]
Error 2
> /perforce/buildlogs/dev/Monday/cg-opt-compile.log:make[2]: ***
> [../../Build/cg/opt/Objects/SSC/sm-utils/cmd-utils.o] Error 1
> /perforce/buildlogs/dev/Monday/cg-opt-compile.log:make[1]: ***
[default]
> Error 1
> /perforce/buildlogs/dev/Monday/cg-opt-compile.log:make: *** [ssc]
Error 2
>=20
> -----End included message----
>=20
> Thanks,
>=20
> -Ken
>=20
> -----Original Message-----
> From: Andy Sharp
> Sent: Mon 12/10/2007 10:56 AM
> To: Ron Bhanukitsiri
> Cc: Ken Renshaw; Yuvarani Cothandaraman; dl-software; Paul Hammer;
Brian
> Stark
> Subject: Re: This change broke cg and bl builds
>=20
> No worries, Ron.
>=20
> Well, almost no worries.
>=20
> The breakage was checked in on Friday, but apparently no notice from
our
> nightly build whatsoever.
>=20
> I believe I'm correct in saying we should have been getting messages
> since Saturday informing us of the breakage?
>=20
> Our engineering processes, including QA and software development, rely
> heavily on the sanctity and trustworthiness of the nightly build, but
> right now the perception is that it can't be trusted.  Can we put a
> priority on doing whatever it is that needs to be done to fix it?
>=20
> Please?
>=20
> Thanks,
>=20
> a
>=20
>=20
> On Mon, 10 Dec 2007 10:36:04 -0800 "Ron Bhanukitsiri"
<ronb@onstor.com>
> wrote:
>=20
> > Sorry about that.  The fix has been checked in.
> > CL #26840.
> >
> > Ron B[ee]
> >
> > -----Original Message-----
> > From: Ken Renshaw
> > Sent: Sunday, December 09, 2007 2:05 PM
> > To: Ron Bhanukitsiri
> > Cc: Brian DeForest
> > Subject: FW: This change broke cg and bl builds
> > Importance: High
> >
> > Hi Ron, this checkin breaks the cougar and bobcat-linux cg and bl
> > targets, here's the error:
> >
> > make[2]: Entering directory
> > `/perforce/trees/dev/nfx-tree/code/sm-utils'
/usr/bin/mipsel-linux-gnu-
> gcc-4.1
> > -fPIC -fms-extensions -Wno-pointer-sign  -DBOBCAT -Wall
> > -Wmissing-prototypes -g -Wall -Wmissing-prototypes -Werror
> > -DEXTENDED_SECURITY -DNFX_KERBEROS -DNETEEE_FRAGMENT  -G 0
> > -DONSTOR_CHANGE -DLDAP_DEPRECATED -DOS_INCL=3D\"linux.h\"  -I./linux
> > -I../../Includes/bl/SSC -I../../Includes/bl -I../../Includes/linux
> > -I../../Includes -I. -I../../Build/bl/opt -DLANGUAGE_C -DLINUX_TEST
> > -g -DSSC -DSSC_mips -DNFX_MOD_SSC -c cmd-utils.c -o
> > ../../Build/bl/opt/Objects/SSC/sm-utils/cmd-utils.o
> > cmd-utils.c: In function 'utils_displayShareACL':
> > cmd-utils.c:2513: error: duplicate case value
> > cmd-utils.c:2511: error: previously used here
> > cmd-utils.c:2520: error: duplicate case value
> > cmd-utils.c:2519: error: previously used here
> > cmd-utils.c:2522: error: duplicate case value
> > cmd-utils.c:2521: error: previously used here
> > make[2]: *** [../../Build/bl/opt/Objects/SSC/sm-utils/cmd-utils.o]
> > Error 1
> > make[2]: Leaving directory
> > `/perforce/trees/dev/nfx-tree/code/sm-utils'
> >
> > I thought I'd give you a chance to fix it before teh cougar team
> > notices in the morning ;)
> >
> > Thanks,
> >
> > -Ken
> >
> >
> > -----Original Message-----
> > From: Build Admin [mailto:build@localhost.localdomain]
> > Sent: Sun 12/9/2007 2:02 PM
> > To: Ken Renshaw
> > Subject:
> >
> > Change 26825 by ronb@ronb-dev-local on 2007/12/07 19:41:10
> >
> > 	Reviewed by: briand
> >
> > 	Add AT&T mkdir filesystem CLI feature.
> >
> > Affected files ...
> >
> > ... //depot/dev/nfx-tree/code/sm-gns/gns-api.c#4 edit
> > ... //depot/dev/nfx-tree/code/sm-utils/cmd-utils.c#14 edit
> > ... //depot/dev/nfx-tree/code/sm-utils/cmd-utils.h#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-gns-api.c#6 edit
> > ...
> >
//depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_grou
> > p_set.txt#2 edit
> > ...
> >
//depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_tree
> > _set.txt#2 edit
> > ...
> >
//depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_user
> > _set.txt#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_fsutil.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_fsutil.h#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_gns.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_quota.c#8 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#27 edit
> >
> >
> >

