X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C83B61.5B94B59D@onstor-exch02.onstor.net>; Mon, 10 Dec 2007 11:17:51 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: This change broke cg and bl builds
Date: Mon, 10 Dec 2007 11:17:50 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E06FCE6B0@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02F3DC4F@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: This change broke cg and bl builds
Thread-Index: Acg7XnCAwIgXS6AJQvqzSyzzRbWkUAAAB0xkAACE5xA=
References: <200712092202.lB9M2rQT008517@localhost.localdomain><BB375AF679D4A34E9CA8DFA650E2B04E02F3DC47@onstor-exch02.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E06FCE5E8@onstor-exch02.onstor.net> <20071210105657.4a436a28@ripper.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E02F3DC4F@onstor-exch02.onstor.net>
From: "Brian DeForest" <brian.deforest@onstor.com>
To: "Ken Renshaw" <ken.renshaw@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>,
	"Ron Bhanukitsiri" <ronb@onstor.com>
Cc: "Yuvarani Cothandaraman" <yuvarani.cothandaraman@onstor.com>,
	<dl-software>,
	"Paul Hammer" <paul.hammer@onstor.com>,
	"Brian Stark" <brian.stark@onstor.com>

I think most people would prefer to receive the notification of a failed
build ASAP.  At least I would.

In this case, the notification arrived 1.5 days after the build (Sun.
afternoon vs. Fri. night) which delayed the fix and impacted more
people. =20

-----Original Message-----
From: Ken Renshaw=20
Sent: Monday, December 10, 2007 11:09 AM
To: Andy Sharp; Ron Bhanukitsiri
Cc: Yuvarani Cothandaraman; dl-software; Paul Hammer; Brian Stark; Ken
Renshaw
Subject: RE: This change broke cg and bl builds

Wrong assumption Andy.

Once again I wish people would *ask* instead of *assume*, that's where a
lot of perception comes from, and where a lot of communication could be
fixed.

When I do work on the pass/fail logic for the nightly builds I turn off
global notification to keep from spamming you, but always always send
emails to myself from buildadm irregardless. Once I've tested the
pass/fail logic by running it a day or so I reenable global
notifications. I have dryrun flags in place but the entire process can
only be tested live nightly, so once in a while I take this route ( last
time was when a bsd problem was missed, can't remember the time before
that... ).

The last email from the build failure is included below ( rest assured
there were 3 for 3 night's worth ), and it's what I used to trigger Ron
into fixing the problem.

My problem is that I'm going to get complaints either from the extra
spam or from a missed email, so I choose the one that attracts the least
attention. If you wish I can take the other route, that of always
sending the global notifications, and then send out a 'false alarm'
email once it has been triaged.

But as I said, builds were running, build caught the failure, and build
worked with the ensuring developer to correct the action. Sorry it
didn't happen before y'all showed back up from the weekend.

------Included message-----------

-----Original Message-----
From: Build Admin [mailto:build@localhost.localdomain]
Sent: Mon 12/10/2007 6:25 AM
To: Ken Renshaw
Subject: Compilation failure in dev branch
=20
/perforce/buildlogs/dev/Monday/bl-dbg-compile.log:make[2]: ***
[../../Build/bl/dbg/Objects/SSC/sm-utils/cmd-utils.o] Error 1
/perforce/buildlogs/dev/Monday/bl-dbg-compile.log:make[1]: *** [default]
Error 1
/perforce/buildlogs/dev/Monday/bl-dbg-compile.log:make: *** [ssc] Error
2
/perforce/buildlogs/dev/Monday/bl-opt-compile.log:make[2]: ***
[../../Build/bl/opt/Objects/SSC/sm-utils/cmd-utils.o] Error 1
/perforce/buildlogs/dev/Monday/bl-opt-compile.log:make[1]: *** [default]
Error 1
/perforce/buildlogs/dev/Monday/bl-opt-compile.log:make: *** [ssc] Error
2
/perforce/buildlogs/dev/Monday/cg-dbg-compile.log:make[2]: ***
[../../Build/cg/dbg/Objects/SSC/sm-utils/cmd-utils.o] Error 1
/perforce/buildlogs/dev/Monday/cg-dbg-compile.log:make[1]: *** [default]
Error 1
/perforce/buildlogs/dev/Monday/cg-dbg-compile.log:make: *** [ssc] Error
2
/perforce/buildlogs/dev/Monday/cg-opt-compile.log:make[2]: ***
[../../Build/cg/opt/Objects/SSC/sm-utils/cmd-utils.o] Error 1
/perforce/buildlogs/dev/Monday/cg-opt-compile.log:make[1]: *** [default]
Error 1
/perforce/buildlogs/dev/Monday/cg-opt-compile.log:make: *** [ssc] Error
2

-----End included message----

Thanks,

-Ken

-----Original Message-----
From: Andy Sharp
Sent: Mon 12/10/2007 10:56 AM
To: Ron Bhanukitsiri
Cc: Ken Renshaw; Yuvarani Cothandaraman; dl-software; Paul Hammer; Brian
Stark
Subject: Re: This change broke cg and bl builds
=20
No worries, Ron.

Well, almost no worries.

The breakage was checked in on Friday, but apparently no notice from our
nightly build whatsoever.

I believe I'm correct in saying we should have been getting messages
since Saturday informing us of the breakage?

Our engineering processes, including QA and software development, rely
heavily on the sanctity and trustworthiness of the nightly build, but
right now the perception is that it can't be trusted.  Can we put a
priority on doing whatever it is that needs to be done to fix it?

Please?

Thanks,

a


On Mon, 10 Dec 2007 10:36:04 -0800 "Ron Bhanukitsiri" <ronb@onstor.com>
wrote:

> Sorry about that.  The fix has been checked in.
> CL #26840.
>=20
> Ron B[ee]
>=20
> -----Original Message-----
> From: Ken Renshaw
> Sent: Sunday, December 09, 2007 2:05 PM
> To: Ron Bhanukitsiri
> Cc: Brian DeForest
> Subject: FW: This change broke cg and bl builds
> Importance: High
>=20
> Hi Ron, this checkin breaks the cougar and bobcat-linux cg and bl=20
> targets, here's the error:
>=20
> make[2]: Entering directory
> `/perforce/trees/dev/nfx-tree/code/sm-utils'=20
> /usr/bin/mipsel-linux-gnu-gcc-4.1 -fPIC -fms-extensions=20
> -Wno-pointer-sign  -DBOBCAT -Wall -Wmissing-prototypes -g -Wall=20
> -Wmissing-prototypes -Werror -DEXTENDED_SECURITY -DNFX_KERBEROS=20
> -DNETEEE_FRAGMENT  -G 0 -DONSTOR_CHANGE -DLDAP_DEPRECATED=20
> -DOS_INCL=3D\"linux.h\"  -I./linux -I../../Includes/bl/SSC=20
> -I../../Includes/bl -I../../Includes/linux -I../../Includes -I.=20
> -I../../Build/bl/opt -DLANGUAGE_C -DLINUX_TEST -g -DSSC -DSSC_mips=20
> -DNFX_MOD_SSC -c cmd-utils.c -o=20
> ../../Build/bl/opt/Objects/SSC/sm-utils/cmd-utils.o
> cmd-utils.c: In function 'utils_displayShareACL':
> cmd-utils.c:2513: error: duplicate case value
> cmd-utils.c:2511: error: previously used here
> cmd-utils.c:2520: error: duplicate case value
> cmd-utils.c:2519: error: previously used here
> cmd-utils.c:2522: error: duplicate case value
> cmd-utils.c:2521: error: previously used here
> make[2]: *** [../../Build/bl/opt/Objects/SSC/sm-utils/cmd-utils.o]
> Error 1
> make[2]: Leaving directory
> `/perforce/trees/dev/nfx-tree/code/sm-utils'
>=20
> I thought I'd give you a chance to fix it before teh cougar team=20
> notices in the morning ;)
>=20
> Thanks,
>=20
> -Ken
>=20
>=20
> -----Original Message-----
> From: Build Admin [mailto:build@localhost.localdomain]
> Sent: Sun 12/9/2007 2:02 PM
> To: Ken Renshaw
> Subject:=20
> =20
> Change 26825 by ronb@ronb-dev-local on 2007/12/07 19:41:10
>=20
> 	Reviewed by: briand
> =09
> 	Add AT&T mkdir filesystem CLI feature.
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/sm-gns/gns-api.c#4 edit ...=20
> //depot/dev/nfx-tree/code/sm-utils/cmd-utils.c#14 edit ...=20
> //depot/dev/nfx-tree/code/sm-utils/cmd-utils.h#5 edit ...=20
> //depot/dev/nfx-tree/code/ssc-cluster/cluster-gns-api.c#6 edit ...
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_gr
> ou
> p_set.txt#2 edit
> ...
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_tr
> ee
> _set.txt#2 edit
> ...
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_filesystem_quota_us
> er
> _set.txt#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#6 edit ...=20
> //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_fsutil.c#3 edit ...=20
> //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_fsutil.h#2 edit ...=20
> //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_gns.c#3 edit ...=20
> //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_quota.c#8 edit ...=20
> //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#27 edit
>=20
>=20
>=20

