X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8360C.3082AEDB@onstor-exch02.onstor.net>; Mon, 3 Dec 2007 16:25:36 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review Change 26643
Date: Mon, 3 Dec 2007 16:25:36 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C91F4@onstor-exch02.onstor.net>
In-Reply-To: <20071130161032.26d06a01@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review Change 26643
Thread-Index: AcgzrrVIZOtDybaFQiCtMVJ1hgpWuQCSXyyg
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I am about 2/3s through the list of files to review.

Here are comments so far. This should give you something to work on...

Larry

What is replacing /var/agile? Is it /var/onstor or /var/log/onstor? You
are not replacing the directory on a one to one basis. For instance you
changed the Onstor log directory to /var/log/onstor in some places
(sm-elog, samba , and sendmail) but it is /var/onstor in others
(sm-ea/ea-cfgd.c.)=20

File: Includes/nfx-defs.h
Lines 280 -294 are deleted instead of modified is this correct?
Same with versions of this files that are in the prom directory=20

File Makefile.ssc
Line 114 you changed the variable name to ONSTOR_DIR from AGILE_DIR but
did not change the references to AGILE_DIR to ONSTOR_DIR

File: nfx-tree/code/sm-ea/ea-cfgd.c
Line 86: using /var/onstor where other areas you replaced this directory
with /var/log/onstor.

File code/samba-3.21a/Makefile
Line 95: You changed VARDIR to /var/log/onstor/samba from
/var/agile/samba. This means you need to change

File: sm-fs/fsdb-read-block.c; ssc-authen-lib/authen-lib.c and others=20
Looks like this needs to be sync'd resolved before you submit it.
-----Original Message-----
From: Andy Sharp=20
Sent: Friday, November 30, 2007 4:11 PM
To: Larry Scheer
Subject: please review Change 26643

change all /usr/local/agile strings to /onstor

change /var/agile to /var/onstor and /var/log/onstor

change a couple of files, rc.agile and welcome.agile to rc.onstor and
welcome.onstor.  the former will have to be done in a second checkin,
because it has changes that have to be committed first.

no changes in krb5-whatever and openldap-whatever, there may be
breakage there, which we'll have to figure out and fix.

changes won't be checked in before monday




Change 26643 by andys@ripper on 2007/11/29 15:31:02 *pending*

        AGILE training day.

Affected files ...

... //depot/dev/descr#1 edit
... //depot/dev/descr-bc#1 edit
... //depot/dev/make-patch.sh#1 edit
... //depot/dev/nfx-tree/Includes/nfx-defs.h#7 edit
... //depot/dev/nfx-tree/Makefile#3 edit
... //depot/dev/nfx-tree/Makefile.ssc#7 edit
... //depot/dev/nfx-tree/Tools/defs.mk#8 edit
... //depot/dev/nfx-tree/code/samba-3.21a/Makefile#2 edit
... //depot/dev/nfx-tree/code/samba-3.21a/passdb/secrets.c#5 edit
... //depot/dev/nfx-tree/code/sendmail/sendmail/main.c#1 edit
... //depot/dev/nfx-tree/code/sendmail/sendmail/queue.c#1 edit
...
//depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/asiFibreChan
nel.c#3 edit
...
//depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsProduct.c
#3 edit
... //depot/dev/nfx-tree/code/sm-bsd-snmpd/linux.h#2 edit
... //depot/dev/nfx-tree/code/sm-bsd-snmpd/openbsd.h#2 edit
... //depot/dev/nfx-tree/code/sm-ea/ea-cfgd-rx.c#7 edit
... //depot/dev/nfx-tree/code/sm-ea/ea-cfgd.c#6 edit
... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#2 edit
... //depot/dev/nfx-tree/code/sm-event/emrs-api.c#3 edit
... //depot/dev/nfx-tree/code/sm-event/event-as-openbsd.c#1 edit
... //depot/dev/nfx-tree/code/sm-event/event-as.c#9 edit
... //depot/dev/nfx-tree/code/sm-event/openbsd.h#1 edit
... //depot/dev/nfx-tree/code/sm-evm/evm-cfgd.c#7 edit
... //depot/dev/nfx-tree/code/sm-fs/fs-shell.c#22 edit
... //depot/dev/nfx-tree/code/sm-fs/fsdb-read-block.c#4 edit
... //depot/dev/nfx-tree/code/sm-fs/restore/restore.c#2 edit
... //depot/dev/nfx-tree/code/sm-fs/sanm_test.c#2 edit
... //depot/dev/nfx-tree/code/sm-fs/snapadmin#1 edit
... //depot/dev/nfx-tree/code/sm-ndmp/nscadmin#1 edit
... //depot/dev/nfx-tree/code/sm-opt/fs-linux.c#3 edit
... //depot/dev/nfx-tree/code/sm-opt/fs-openbsd.c#4 edit
... //depot/dev/nfx-tree/code/sm-opt/opt-api.h#4 edit
... //depot/dev/nfx-tree/code/sm-sct/sct-ccc-ssl.c#5 edit
... //depot/dev/nfx-tree/code/sm-sct/sct-http.c#5 edit
... //depot/dev/nfx-tree/code/sm-sct/sct.c#7 edit
... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#6 edit
... //depot/dev/nfx-tree/code/sm-sdm/sdm-conf.h#1 edit
... //depot/dev/nfx-tree/code/sm-sdm/sdm-devcap#3 edit
... //depot/dev/nfx-tree/code/sm-sdm/sdm-init-devcap.c#4 edit
... //depot/dev/nfx-tree/code/sm-sdm/sdm-main.c#3 edit
... //depot/dev/nfx-tree/code/sm-sdm/storage.c#5 edit
... //depot/dev/nfx-tree/code/sm-test/how-to-garfield#1 edit
... //depot/dev/nfx-tree/code/ssc-authen-lib/authen-lib-api.h#3 edit
... //depot/dev/nfx-tree/code/ssc-authen-lib/authen-lib.c#8 edit
...
//depot/dev/nfx-tree/code/ssc-authen-lib/authen-localaccounts-api.h#2
edit
... //depot/dev/nfx-tree/code/ssc-authen-lib/cifs-map-cfg.c#2 edit
... //depot/dev/nfx-tree/code/ssc-authentication/auth-cifs.c#8 edit
... //depot/dev/nfx-tree/code/ssc-cluster/clusdb-tools.c#6 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.c#7 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#11 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#4 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-test.c#8 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.c#4 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.h#3 edit
... //depot/dev/nfx-tree/code/ssc-elog/elog.c#5 edit
... //depot/dev/nfx-tree/code/ssc-ncm/ncm.c#7 edit
... //depot/dev/nfx-tree/code/ssc-ncm/ncm.h#4 edit
... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-main.c#7 edit
... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-ssc.h#2 edit
... //depot/dev/nfx-tree/code/ssc-nfxnis/nfxnis-loc.h#1 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#2 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#7 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_disk.c#2 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#12 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c#14 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_ndmp.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_port.c#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_rcon.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_scsi.c#4 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysHealth.c#2 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysdvt.c#3 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#26 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#12 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#5 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/selecttz#1 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/test/nfxsh-priv-test.c#2 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#1 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#8 edit
... //depot/dev/nfx-tree/code/ssc-openafs-ubik/beacon.c#8 edit
... //depot/dev/nfx-tree/code/ssc-openafs-ubik/recovery.c#5 edit
... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.c#7 edit
... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.h#3 edit
... //depot/dev/nfx-tree/code/ssc-pm/pm-mcp.c#7 edit
... //depot/dev/nfx-tree/code/ssc-pm/pm.c#9 edit
... //depot/dev/nfx-tree/code/ssc-pm/pmtab.all.linux#1 edit
... //depot/dev/nfx-tree/code/ssc-pm/pmtab.all.openbsd#1 edit
... //depot/dev/nfx-tree/code/ssc-pm/pmtab.init.linux#1 edit
... //depot/dev/nfx-tree/code/ssc-pm/pmtab.init.openbsd#1 edit
... //depot/dev/nfx-tree/code/ssc-pm/pmtab.linux#2 edit
... //depot/dev/nfx-tree/code/ssc-pm/pmtab.openbsd#1 edit
... //depot/dev/nfx-tree/code/ssc-pm/rc.agile#5 edit
... //depot/dev/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#4 edit
... //depot/dev/nfx-tree/code/ssc-rmc/rmc_util.c#3 edit
... //depot/dev/nfx-tree/code/ssc-sanm/sanm-private.h#1 edit
... //depot/dev/nfx-tree/code/ssc-support/cpucrash.sh#1 edit
... //depot/dev/nfx-tree/code/ssc-support/emrscron#7 edit
... //depot/dev/nfx-tree/code/ssc-support/replay_nfs_show_all.sh#1 edit
... //depot/dev/nfx-tree/code/ssc-support/support.sh#7 edit
... //depot/dev/nfx-tree/code/ssc-timekeeper/timekeep-api.h#4 edit
... //depot/dev/nfx-tree/code/ssc-vsd/vs-daemon.c#20 edit
... //depot/dev/nfx-tree/extra/strip.sh#1 edit
... //depot/dev/nfx-tree/test/lib/ONStor/Expect/GW/fscmd.pm#2 edit
... //depot/dev/nfx-tree/test/lib/ONStor/Expect/Ssh.pm#5 edit
... //depot/dev/nfx-tree/test/runtests#3 edit
...
//depot/dev/nfx-tree/test/t/all/features/filesystem/stress/StressTest/Ga
tewayMonitor.pm#1 edit
... //depot/dev/openbsd/src/etc/Makefile#4 edit
... //depot/dev/openbsd/src/etc/crontab#1 edit
... //depot/dev/openbsd/src/etc/flash_install.sh#1 delete
... //depot/dev/openbsd/src/etc/inetd.conf#1 edit
... //depot/dev/openbsd/src/etc/master.passwd#1 edit
... //depot/dev/openbsd/src/etc/master.passwd.org#1 edit
... //depot/dev/openbsd/src/etc/mtree/4.4BSD.dist#2 edit
... //depot/dev/openbsd/src/etc/newsyslog.conf#1 edit
... //depot/dev/openbsd/src/etc/rc#4 edit
... //depot/dev/openbsd/src/etc/rc.initial#4 edit
... //depot/dev/openbsd/src/etc/rc.local#1 edit
... //depot/dev/openbsd/src/etc/rc.shutdown#1 edit
... //depot/dev/openbsd/src/etc/root/dot.cshrc#1 edit
... //depot/dev/openbsd/src/etc/root/dot.profile#1 edit
... //depot/dev/openbsd/src/etc/syslog.conf#1 edit
... //depot/dev/openbsd/src/etc/welcome.agile#1 delete
... //depot/dev/openbsd/src/etc/welcome.onstor#1 branch
... //depot/dev/openbsd/src/krb5-1.4.2/src/Makefile#1 edit
... //depot/dev/openbsd/src/libexec/ld.so_elf/ld.so/library.c#1 edit
...
//depot/dev/openbsd/src/usr.sbin/dhcp/dhclient/scripts/dhclient-script#7
edit
... //depot/dev/prom/bc/Includes/nfx-defs.h#1 edit
... //depot/dev/prom/cg/Includes/nfx-defs.h#1 edit
... //depot/dev/prom/ch/Includes/nfx-defs.h#1 edit

