X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C82884.9B81616C@onstor-exch02.onstor.net>; Fri, 16 Nov 2007 11:12:18 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please Review
Date: Fri, 16 Nov 2007 11:12:19 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E06A7BB7C@onstor-exch02.onstor.net>
In-Reply-To: <20071116111108.70ef844d@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please Review
Thread-Index: AcgohHEthwcDfJSITYybwoxrx6J2LQAACdYA
References: <20071115170855.03e509ae@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E069927BE@onstor-exch02.onstor.net><20071115184532.1851f33c@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E0699297C@onstor-exch02.onstor.net> <20071116111108.70ef844d@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

ok

>-----Original Message-----
>From: Andy Sharp
>Sent: Friday, November 16, 2007 11:11 AM
>To: Maxim Kozlovsky
>Subject: Re: please Review
>
>On Fri, 16 Nov 2007 08:40:07 -0800 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>>
>>
>> >-----Original Message-----
>> >From: Andy Sharp
>> >Sent: Thursday, November 15, 2007 6:46 PM
>> >To: Maxim Kozlovsky
>> >Subject: Re: please Review
>> >
>> >On Thu, 15 Nov 2007 17:16:51 -0800 "Maxim Kozlovsky"
>> ><maxim.kozlovsky@onstor.com> wrote:
>> >
>> >> Makefile: No, we want to use all the processors and then some to
>> >> compensate for the I/O latencies. If you want better response
times
>> >> while running the compilation you can always run make with "nice".
>> >
>> >I know all about I/O latencies.  Hey, I don't do this for myself, I
>> >do it for people sharing machines like compile2 and whatnot.  At
>> >least there will be one "processor-lite" *slightly* available for
>> >bash response. Since each compile uses up 2-3 processes, it's going
>> >to hammer on all the processors anyway.
>> >
>> >But fine, have it your way.  I remove the "-1" as we speak.
>> Well I don't really care since I don't use this Makefile, so yeah
>> whatever. What really should be done is don't put any -j settings in
>> the makefile and let everybody use their own -j value on the command
>> line.
>
>That doesn't work exactly, as it doesn't get passed down to the kernel
>makefile.  I just removed the -1, at least the pain will be shorter
>lived that way.
>
>> >
>> >> Sb_wdog.c:
>> >>
>> >> 320: Why don't you declare the function correctly instead of
>> >> casting it
>> >
>> >Because I need a (char *) not a (void *) because I want to add to
the
>> >address by the number of bytes, not the number of ... something.
>> >It seemed a waste to allocate a local variable and assign it just to
>> >do that.  And I didn't want to have to do some ifdef =
SIZEOF_LONG=3D64
>> >etc nonsense that would just make the code harder to read.
>> [MK]
>> It is not a waste, casting functions is a generally bad idea. For
>> example if somebody modifies the irq function parameter list you code
>> will continue to compile but will fail in unpredictable way. It is
>> easy to write this code without any #ifdefs and without casts, just
>> declare a local variable.
>
>OK, local variable it is.
>
>> >
>> >>
>> >>
>> >> >-----Original Message-----
>> >> >From: Andy Sharp
>> >> >Sent: Thursday, November 15, 2007 5:09 PM
>> >> >To: Maxim Kozlovsky
>> >> >Subject: please Review
>> >> >
>> >> >Change 26386 by andys@ripper on 2007/11/15 16:38:26 *pending*
>> >> >
>> >> >        Fix some kernel compile warnings.
>> >> >        Adjust build to use all but one of the "processors" of
the
>> >> >        machine it is building on.
>> >> >        Update git repository.
>> >> >
>> >> >Affected files ...
>> >> >
>> >> >... //depot/dev/linux/kernel/Makefile#8 edit
>> >> >... //depot/dev/linux/kernel/linux-mips-
>> >> >2.6/arch/mips/onstor/cougar/prom.c#1 edit
>> >> >... //depot/dev/linux/kernel/linux-mips-
>> >> >2.6/arch/mips/onstor/cougar/time.c#1 edit
>> >> >... //depot/dev/linux/kernel/linux-mips-
>> >> >2.6/drivers/char/watchdog/sb_wdog.c#2 edit
>> >> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/FETCH_HEAD#4
edit
>> >> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/HEAD#3 edit
>> >> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/ORIG_HEAD#4 edit
>> >> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/index#5 edit
>> >> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/info/refs#4 edit
>> >> >...
>> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/info/packs#4
>> >> edit
>> >> >...
//depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
>> >> >4cdf6c82560a6bc65d649800c96c85ae53165246.idx#1 delete
>> >> >...
//depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
>> >> >4cdf6c82560a6bc65d649800c96c85ae53165246.pack#1 delete
>> >> >...
//depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
>> >> >a7d1fb235b40c0ff63eceb4cd117a535a345c84e.idx#1 add
>> >> >...
//depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
>> >> >a7d1fb235b40c0ff63eceb4cd117a535a345c84e.pack#1 add
>> >> >...
>> >>
>>
//depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.22#1
>> >> >edit
>> >> >...
>> >>
>>
//depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.22-
>> >> >dev#1 branch
>> >> >...
>> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-cg-
>> >> >2.6.22#2 delete
>> >> >...
>> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-cg-
>> >> >2.6.22-dev#3 delete
>> >> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/remotes/origin#4
>> >> >edit
>> >>
