X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C827B7.B7D494D3@onstor-exch02.onstor.net>; Thu, 15 Nov 2007 10:45:39 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Thu, 15 Nov 2007 10:45:39 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E069924AD@onstor-exch02.onstor.net>
In-Reply-To: <20071115103648.2eb92d45@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcgntnsI3Z9TTz+AS129QsLVEmn8IAAAO6wA
References: <BB375AF679D4A34E9CA8DFA650E2B04E069923BB@onstor-exch02.onstor.net> <20071115103648.2eb92d45@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>


Ok whatever.=20
linux/kernel/linux-mips-2.6/arch/mips/sibyte/Kconfig
>
>     add depends on NET_SB1250_MAC
>
>     and should be in drivers/net/Kconfig, not arch/mips/sibyte/Kconfig
>
>linux/kernel/linux-mips-2.6/cougar-config
>
>     looks good
>
>linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c
>
>     line 339
>
>     do you think we should do this?
>
>     #ifndef CONFIG_ONSTOR_COUGAR
>     static
>     #endif
>     uint64_t sbmac_orig_hwaddr[MAX_UNITS];
[MK] Does not really matter, does it?
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c
>
>     looks good

