X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C826DD.6D4D632F@onstor-exch02.onstor.net>; Wed, 14 Nov 2007 08:43:04 -0800
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C826DD.6D4D632F"
Content-class: urn:content-classes:message
Subject: Please review
Date: Wed, 14 Nov 2007 08:43:03 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E06991CF4@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: Acgm3WyanDTFAjzPTDSmC8QXqOkStw==
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C826DD.6D4D632F
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Change 26335 by maximk@maximk-13 on 2007/11/13 09:35:07 *pending*

        Do not use fixed mac addresses, they are set in prom now.

           Can't read the hardware register because the driver temporary
writes 0
           in there, use the variable.

           Fix the extraction of the mac address bits.

           Reviewed by andys.

Affected files ...

... //depot/dev/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2
edit
...
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt
_bus.c#4 edit


------_=_NextPart_001_01C826DD.6D4D632F
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Dus-ascii">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7652.24">
<TITLE>Please review</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/rtf format -->

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 FACE=3D"Arial">Change 26335 by maximk@maximk-13 on 2007/11/13 =
09:35:07 *pending*</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Do not use =
fixed mac addresses, they are set in prom now.</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p; Can't read the hardware register because the driver temporary writes =
0</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p; in there, use the variable.</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p; Fix the extraction of the mac address bits.</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs=
p; Reviewed by andys.</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Affected =
files ...</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/dev/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2 =
edit</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">... =
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_=
bus.c#4 edit</FONT></SPAN></P>

<P DIR=3DLTR><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

</BODY>
</HTML>
------_=_NextPart_001_01C826DD.6D4D632F--
