X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C82300.A1360599@onstor-exch02.onstor.net>; Fri, 9 Nov 2007 10:44:59 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Fri, 9 Nov 2007 10:44:59 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E06794C3D@onstor-exch02.onstor.net>
In-Reply-To: <20071109104100.08d58b69@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcgjABLCoOR/hJ2CS3ySJcIyGUCwAQAAC23Q
References: <BB375AF679D4A34E9CA8DFA650E2B04E06794AE6@onstor-exch02.onstor.net> <20071109104100.08d58b69@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>



>-----Original Message-----
>From: Andy Sharp
>Sent: Friday, November 09, 2007 10:41 AM
>To: Maxim Kozlovsky
>Subject: Re: Please review
>
>On Fri, 9 Nov 2007 08:46:14 -0800 "Maxim Kozlovsky"
><maxim.kozlovsky@onstor.com> wrote:
>
>> Change 26277 by maximk@maximk-13 on 2007/11/09 08:39:17 *pending*
>>
>>         Pass the mac address to the embedded cpus on cougar.
>>            Reviewed by andys.
>>
>> Affected files ...
>>
>> ...
>>
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/bobcat_mgmt
>> _bus.c#3 edit
>> ...
>>
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt
>> _bus.c#3 edit
>> ...
>>
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c#
>> 7 edit
>> ...
>>
//depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h#
>> 4 edit
>> ...
>> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/rcon.c#4
>> edit
>> ... //depot/dev/nfx-tree/code/sm-jmptbl/jmptbl.S#1 edit
>> ... //depot/dev/nfx-tree/code/sm-seep/seep-api.c#4 edit
>> ... //depot/dev/nfx-tree/code/ssc-mgmt-bus/mgmt-bus.h#2 edit
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/bobcat_mgmt_bus.c
>
>     looks good
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c
>
>     looks good
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c
>
>     looks good
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h
>
>     looks good
>
>linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/rcon.c
>
>     looks good
>
>nfx-tree/code/sm-jmptbl/jmptbl.S
>
>     looks good
>
>nfx-tree/code/sm-seep/seep-api.c
>
>     i thought you removed support for the gethostid function from
>     the jmptbl.S file?
[MK] This removes support for builtin prom function, which did not do
anything.=20
>
>nfx-tree/code/ssc-mgmt-bus/mgmt-bus.h
>
>     this structure is used in multiple files and defined separatedly
>     in multiple places.  can we eliminate that?
>     if there is a list of kernel header files that should be
"exported"
>     the nfx-space, let me know what they are and I will take care of
>     making those mods.
[MK] Not now.=20

