X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C81056.24109D7C@onstor-exch02.onstor.net>; Tue, 16 Oct 2007 16:39:13 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 25871 for review
Date: Tue, 16 Oct 2007 16:39:14 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E060D153C@onstor-exch02.onstor.net>
In-Reply-To: <20071016173335.741bfead@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 25871 for review
Thread-Index: AcgQVVpWRr4/j/6nSqST4+6+KDZMBQAAINAw
References: <WEBMAIL43i7pwKuX9aj00000fc5@mail.onstor.com> <20071016173335.741bfead@ripper.onstor.net>
From: "Ed Kwan" <ed.kwan@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

So how do I edit it?
It's 1:37am in London, and I don't think I've read your "cute" email
yet...

> -----Original Message-----
> From: Andy Sharp
> Sent: Tuesday, October 16, 2007 5:34 PM
> To: Ed Kwan
> Subject: Re: PERFORCE change 25871 for review
>=20
> On 16 Oct 2007 17:19:09 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:
>=20
> > Change 25871 by edk@edk-r310rel on 2007/10/16 12:15:42
> >
> > 	Integrating change 25825 for TED 20712 into the R3_1_0_rel
> > 	branch.
> > 	Reviewed by chrisv.
> >
> > Affected files ...
> >
> > ... //depot/R3_1_0_rel/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#5 integrate
>=20
> Hi Ed,
>=20
> Perhaps I was trying too hard to be cute before, and perhaps you've
got
> a lot going on right now, but the convention that we all need to
follow
> for check in comments is, amongst other things, to not require the use
> of this or any other tool to know what the checkin was about.  Even
for
> release or maintenance branches.  Please try to follow the convention.
> I know you've probably got a lot going on right now and we all goof it
> some times.  That's why we have to police each other, in order to stay
> on track.
>=20
> This was an integrate, so it should be easy to just cut and paste the
> original checkin comment; or you can summarize the original comment if
> you want, say for instance, if it's huge and you don't want to paste
> the whole thing.
>=20
> Thanks,
>=20
> a
