X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C810E9.02360429@onstor-exch02.onstor.net>; Wed, 17 Oct 2007 10:10:33 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review
Date: Wed, 17 Oct 2007 10:10:33 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9143@onstor-exch02.onstor.net>
In-Reply-To: <20071016180856.45ad7eb0@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review
Thread-Index: AcgQWkqR4w6m3nSrS76YOaHmMz3lkwAjcSMg
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Are you going to be in today? I would like to explain the changes to the
Makefile. I broke up the one main target into chunks to facilitate
debugging and the case where a patch fails.

I can move the patch file from the src directory to the source
hierarchy. No big thing there.

Any way it would be good for us to go over these changes in detail
together and not via email.

Larry=20

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, October 16, 2007 6:09 PM
To: Larry Scheer
Subject: Re: Please review

On Tue, 16 Oct 2007 17:39:03 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> My workspace is ~larrys/src/dev
>=20
> Change 25873 by larrys@larrys on 2007/10/16 12:32:38 *pending*
>=20
>         Makefile updated with rules to patch debian code and update
> the version in the changelog with an epoch number.
>         Reviewed by: AndyS
>=20
> Affected files ...
>=20
> ... //depot/dev/linux/Pkgs/source/wget/Makefile#1 edit
> ... //depot/dev/linux/src/wget-1.10.2/debian/changelog#1 edit
> ...
//depot/dev/linux/src/wget-1.10.2/debian/patches/debianrules.patch#1
> add
> ...
//depot/dev/linux/src/wget-1.10.2/debian/patches/onstor-src.dpatch#1
> add

linux/Pkgs/source/wget/Makefile

     wah?  we need to go over this in detail.


linux/src/wget-1.10.2/debian/changelog

     looks good


linux/src/wget-1.10.2/debian/patches/debianrules.patch

     >>add linux/src/wget-1.10.2/debian/patches/debianrules.patch

     uh, huh?  linux/src is the wrong directory


linux/src/wget-1.10.2/debian/patches/onstor-src.dpatch

     >>add linux/src/wget-1.10.2/debian/patches/onstor-src.dpatch

     nope, all this stuff needs to go in Source, remember?  we are
     doing away with src.  we have Pkgs/binary and Pkgs/source, no
     additional stuff in linux/src.


