X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C80ACE.6E21D5C9@onstor-exch02.onstor.net>; Tue, 9 Oct 2007 15:45:10 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 25776 for review
Date: Tue, 9 Oct 2007 15:45:10 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E018A6A12@onstor-exch02.onstor.net>
In-Reply-To: <20071009163458.4b53b174@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 25776 for review
Thread-Index: AcgKzQFxXtykBZALQi6VBhod/wd3wQAAJrKg
From: "Jeff Miller" <jeff.miller@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Andy,
The fcs errors are one for transmit and one for receive. =20

The chip has counters for collisions so I originally included them.
Rendell then suggested that we leave them out since we never should see
any with our configuration.  I did leave them in for the txrx display
command just so we can verify this.
Jeff


-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, October 09, 2007 4:35 PM
To: Jeff Miller
Subject: Re: PERFORCE change 25776 for review

On 9 Oct 2007 16:29:05 -0700 Jeff Miller <jeff.miller@onstor.com> wrote:

> Change 25776 by jeffm@jeffm-dev on 2007/10/09 11:28:07
>=20
> 	Some refinements to Cougar data netwark statistics.
> 	Removed 'collision' stats.
> 	Changed 'fsc' to 'fcs' since it stands for 'frame check
> sequence' Change 'crc' to 'fcs' in display to be consistent
> 	Change 'PHY code errors' to 'code errors' - I doubt knowing
> that they are detected by the PHY rather than MAC is helpful.
> Reviewed by: rendellf Regression: should only affect Cougar, changes
> are only in txrx net statistics code.
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/sm-bmc12500-eth/bmc12500-eth-api.h#3
> edit ...
//depot/dev/nfx-tree/code/sm-bmc12500-eth/bmc12500-eth-diag.c#4
> edit ... //depot/dev/nfx-tree/code/sm-stats/stats-txrx.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c#9 edit
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/25776?ac=3D10

for cmd_stats.c:

line 295, no need to print out fcs errors twice (line 298)
what happened to regular, late and excessive collisions?  do we not
collect those on either bobcat or cougar?
