X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C807A8.3D4EACB3@onstor-exch02.onstor.net>; Fri, 5 Oct 2007 15:34:14 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 25748 for review
Date: Fri, 5 Oct 2007 15:34:14 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9128@onstor-exch02.onstor.net>
In-Reply-To: <20071005161111.39aea65f@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 25748 for review
Thread-Index: AcgHpQVjQs72Wru3RPqt8xZ5Zr/q5wAAH54g
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>,
	"Rendell Fong" <rendell.fong@onstor.com>

We removed it from cmd_upgrade.c and sources related to the upgrade
program.
The reason it was removed had more to do with redesigning upgrade to be
more reliable and we wanted to preserve hard links than with the install
command being busted. The install command breaks hard links and the
upgrade command needed to be redesigned so we could preserve hard links.
I wouldn't say we deprecated it. After you fixed the upgrade command I
did several hundred upgrades using the fixed install program and did not
see file corruption so I a confident it was fixed. =20

I think the install command is lightly used, not sure if it is worth the
effort to change the code for BSD when we can use it in Linux.

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, October 05, 2007 4:11 PM
To: Rendell Fong
Cc: Larry Scheer
Subject: Re: PERFORCE change 25748 for review

Hey guys,

I thought the use of the install command in openbsd was deprecated,
never to be used again?  I know we supposedly fixed install, but this
gives me the willies.  Can we change it to cp/chmod for openbsd?

Cheers,

a

On 5 Oct 2007 16:04:03 -0700 Rendell Fong <rendell.fong@onstor.com>
wrote:

> Change 25748 by rendellf@rendellf on 2007/10/05 11:01:50
>=20
> 	Removed use of -C install option for Linux.
> 	Reviewed by: LarryS
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#15 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#4 edit
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/25748?ac=3D10
