X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C805F7.F4111CF0@onstor-exch02.onstor.net>; Wed, 3 Oct 2007 11:59:48 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Review Request
Date: Wed, 3 Oct 2007 11:59:48 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C911D@onstor-exch02.onstor.net>
In-Reply-To: <20071003121755.65395b19@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Review Request
Thread-Index: AcgF8hpX4j/9/0LgS+iQ0ky7dvPggwAAGHoA
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

My comments in-line

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, October 03, 2007 12:18 PM
To: Larry Scheer
Subject: Re: Review Request

Haste makes mistakes.

linux/rootfs/Makefile

     sh!t, i thought we added the exim4 config file a long time ago
>> Not really. The exim4 config file was only just a week or so ago.
>> I added it to this Makefile as soon as it was ready but the submittal
got held up by other changes.

     we should generate a reasonable fstab file.  i thought we did
     that as part of the temporary rc script that you had?  we can
     still keep the fstab.sav code.

>> I agree. That will come later when the compact flash is available. We
will need to handle the case where the compact flashes are swapped
manually and need to modify the rc scripts to check and replace the
fstab like we do with bsd. Or do you have another idea?

     line 134 and 139: I'm quite guilty of doing this "[ -x whatever
     ] || code" syntax, but i've decided that it's a maintenance
     liability, and i've now switched to using the much more readable
     and therefore maintainable "if [ ! -x whatever ] ; then code fi".
     In this case it would be:

     if [ ! -d $(@D) ] ; then mkdir $(@D) ; fi
>> This (above) was the only way I wrote Makefiles until I got here.
Since it was all over the place I started duplicating it. I figured
since it was used liberally throughout Makefiles at ONStor most
developers here understood the logic. Given it is handy and (perhaps)
safe for use with cd and mkdir -p that is where I use it the most.=20

     but seeing as how you do this a million times in this file,
     take that comment as something for the future ~:^)

>> Okay, I won't change it.



linux/rootfs/etc/hosts

     >>add linux/rootfs/etc/hosts
     	not good.  please make this file easily editable by
     	sed from one of your scripts or makefiles, or easily
     	appendable to.	we can't ship it looking like this
        nor leaving it like this.  initial config must populate
     	the rest of this file, and if the host name or ip address
	is ever changed, this file must be modified by that config
        change. i assume that is already handled by nfxsh or whatever.
        but maybe that's why it's missing: it was probably handled by
        the now gone initial config?  or did they add the initial
        config back?

>> Not sure what it should look like right now. I am thinking of using
something similar to what is used in BSD. A problem we have right now is
the initial config in Linux is not creating/editing this file. Not sure
what nfxsh does with it. I think it updates it when you add a VSVR IP
address but I will need to look at the code.
>> What do you think of the idea where this file is just:
127.0.0.1       localhost
>> then let the programs that are supposed to update this file just
append to it?
>> Of course this means onstor/initial-config needs to be updated to
append to the file. (Which it isn't doing currently.)




On Wed, 3 Oct 2007 11:35:56 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy could you please review this change list.
>=20
> If you can't get to it any time soon, let me know and I will ask
> someone else. I would like to get this checked in ASAP>
>=20
> Thanks,
>=20
> Larry
>=20
> P4 workspace: ~larrys/src/dev
>=20
> Change 25715 by larrys@larrys on 2007/10/03 06:24:37 *pending*
>=20
>         Updates to add EMRS certificates for SSL.=20
>         Kernel target updated to call kernel_install this is needed to
> match
>         changes to linux/kernel/Makefile.
>         Adding a default etc/hosts file. The basic system
> configuration done by debootstrap can't be trusted to provide this
> file. If a user adds etc/fstab.sav to the etc directory use that file
>         to replace the system's default (typically empty) fstab.
>         This is a convenience for NFS ROOT users.
>         Reviewed by: AndyS
>=20
> Affected files ...
>=20
> ... //depot/dev/linux/rootfs/Makefile#4 edit
> ... //depot/dev/linux/rootfs/etc/hosts#1 add
