X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7FC8D.48EB0EB5@onstor-exch02.onstor.net>; Fri, 21 Sep 2007 12:23:34 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 25551 for review
Date: Fri, 21 Sep 2007 12:23:34 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E05A25860@onstor-exch02.onstor.net>
In-Reply-To: <20070921105114.536e952a@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 25551 for review
Thread-Index: Acf8eAFoNHIMNoO+QN+H7+n7fL7gwgAFS9fg
From: "Jonathan Goldick" <jonathan.goldick@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

OK.  Probably need to add that to the instructions he mailed out.

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, September 21, 2007 10:51 AM
To: Jonathan Goldick
Subject: Re: PERFORCE change 25551 for review

On 21 Sep 2007 09:54:52 -0700 jong <jonathan.goldick@onstor.com> wrote:

> Change 25551 by jong@jong-jong-cifs on 2007/09/21 09:48:28
>=20
> 	Integrate 25529 from dev branch for defect 20568.
> 	       Reviewed by MaximK

Dude.

I guess your perforce muse abandoned you today, but this isn't a
sufficient comment.  When doing these integrates probably the easiest
thing is to cut/paste the original comment in as well, that's what I
do, but you have to say what the change is about w/o the person
consulting another tool like clearcrap or whatever.

Ken still has the marks on his back where we flogged him until he
started doing that, so it's only fair that I do the same to you ~:^)

a

> Affected files ...
>=20
> ... //depot/R3_1_0_rel/nfx-tree/code/sm-utils/cmd-utils.c#3 integrate
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/25551?ac=3D10
