X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7FA1B.39616F7D@onstor-exch02.onstor.net>; Tue, 18 Sep 2007 09:42:03 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Compilation failure in dev branch
Date: Tue, 18 Sep 2007 09:42:03 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E059637B6@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Compilation failure in dev branch
Thread-Index: Acf58pRjURPa/g/TRPCplTQIjktUIgAEcn7VAAFiNOAAANhwHwABs9uAAAGl0lA=
References: <200709181243.l8IChr9Q018800@localhost.localdomain> <BB375AF679D4A34E9CA8DFA650E2B04E018AE7B6@onstor-exch02.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E05963670@onstor-exch02.onstor.net> <BB375AF679D4A34E9CA8DFA650E2B04E018AE7B7@onstor-exch02.onstor.net> 
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>,
	"Jeff Miller" <jeff.miller@onstor.com>,
	"Charissa Willard" <charissa.willard@onstor.com>
Cc: "dl-Software" <dl-software@onstor.com>

I have looked at the change and it is not right even if we forget about =
the compilation failure. I am going to undo the change.

To whoever is going to redo the coverity fixes: in this particular case =
the problem should be fixed by using snprintf() instead of asprintf().

>-----Original Message-----
>From: Maxim Kozlovsky
>Sent: Tuesday, September 18, 2007 9:54 AM
>To: Jeff Miller; Charissa Willard
>Cc: dl-Software
>Subject: RE: Compilation failure in dev branch
>
>It is not a problem with the build system. To have the asprintf =
declared,
>you need to define _GNU_SOURCE in the .c file, as the man page says:
>
>SYNOPSIS
>       #define _GNU_SOURCE
>       #include <stdio.h>
>
>Or if this is problem for some reason, you can include "../ssc-
>bsdcompat/bsdcompat.h"
>
>
>>-----Original Message-----
>>From: Jeff Miller
>>Sent: Tuesday, September 18, 2007 9:09 AM
>>To: Charissa Willard
>>Cc: dl-Software
>>Subject: RE: Compilation failure in dev branch
>>
>>Charissa,
>>After a sync this morning I see the failure below.  I don't think it =
is a
>>problem with the code itself but rather a problem with the build =
system or
>>how it is used.
>>
>>/usr/mipsel-linux-gnu/include/stdio.h (which declares asprintf) seems =
to
>be
>>included ok (by cluster-contrl-cache.h).  There are ifdefs in stdio =
that
>>could cause skipping of the asprintf declaration.
>>
>>I'll look a little more.
>>Jeff
>>
>>
>>/usr/bin/mipsel-linux-gnu-gcc-4.1 -fPIC -fms-extensions =
-Wno-pointer-sign
>>-DBOBCAT -Wall -Wmissing-prototypes  -Werror -DEXTENDED_SECURITY -
>>DNFX_KERBEROS -DNETEEE_FRAGMENT  -G 0 -DCLUSTER_CONTRL -Wno-missing-
>>prototypes  -DONSTOR_CHANGE -DLDAP_DEPRECATED -DOS_INCL=3D\"linux.h\"  =
-
>>I./linux -I../../Includes/bl/SSC -I../../Includes/bl -
>I../../Includes/linux
>>-I../../Includes -I. -I../../Build/bl/dbg -DLANGUAGE_C -DLINUX_TEST  -
>>DFS_DEBUG -DLANGUAGE_C  -I../  -I./linux -I../../Includes/bl/SSC -
>>I../../Includes/bl -I../../Includes/linux -I../../Includes -I. -
>>I../../Build/bl/dbg -I../../Build/bl/dbg/ssc-cluster -g -DSSC =
-DSSC_mips -
>>DNFX_MOD_SSC -c -o ../../Build/bl/dbg/Objects/SSC/ssc-
>>cluster/contrl/cluster-contrl-cache.o cluster-contrl-cache.c
>>cc1: warnings being treated as errors
>>cluster-contrl-cache.c: In function =91ClusterCtrl_cacheGetRecord=92:
>>cluster-contrl-cache.c:362: warning: implicit declaration of function
>>=91asprintf=92
>>make[3]: *** =
[../../Build/bl/dbg/Objects/SSC/ssc-cluster/contrl/cluster-
>>contrl-cache.o] Error 1
>>make[3]: Leaving directory =
`/homes/jeffm/p4/dev/nfx-tree/code/ssc-cluster'
>>make[2]: *** [default] Error 1
>>make[2]: Leaving directory `/homes/jeffm/p4/dev/nfx-tree'
>>make[1]: *** [ssc] Error 2
>>make[1]: Leaving directory `/homes/jeffm/p4/dev/nfx-tree'
>>make: *** [dbg-bl] Error 2
>>
>>
>>
>>-----Original Message-----
>>From: Charissa Willard
>>Sent: Tue 9/18/2007 8:41 AM
>>To: Jeff Miller
>>Cc: dl-Software
>>Subject: RE: Compilation failure in dev branch
>>
>>Jeff,
>>
>>
>>
>>There were 2 recent changes to the cluster-contrl-cashe.c file for
>Coverity
>>fixes. Change 25457 was done late last night. Change 25465 was checked =
in
>>after this error was encountered. Can you see if this latest check-in
>still
>>causes compilation problems?
>>
>>
>>
>>-Charissa
>>
>>
>>
>>-----Original Message-----
>>From: Jeff Miller
>>Sent: Tuesday, September 18, 2007 7:58 AM
>>To: dl-Software
>>Subject: FW: Compilation failure in dev branch
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>-----Original Message-----
>>
>>From: Build Admin [mailto:build@localhost.localdomain]
>>
>>Sent: Tue 9/18/2007 5:43 AM
>>
>>To: Sandrine Boulanger; Paul Hammer; Ken Renshaw; Brian DeForest; dl-
>Cougar
>>
>>Subject: Compilation failure in dev branch
>>
>>
>>
>>/perforce/buildlogs/dev/Tuesday/bl-dbg-compile.log:make[2]: ***
>>[../../Build/bl/dbg/Objects/SSC/ssc-cluster/contrl/cluster-contrl-cache=
.o]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/bl-dbg-compile.log:make[1]: *** =
[default]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/bl-dbg-compile.log:make: *** [ssc] =
Error 2
>>
>>/perforce/buildlogs/dev/Tuesday/bl-opt-compile.log:make[2]: ***
>>[../../Build/bl/opt/Objects/SSC/ssc-cluster/contrl/cluster-contrl-cache=
.o]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/bl-opt-compile.log:make[1]: *** =
[default]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/bl-opt-compile.log:make: *** [ssc] =
Error 2
>>
>>/perforce/buildlogs/dev/Tuesday/cg-dbg-compile.log:make[2]: ***
>>[../../Build/cg/dbg/Objects/SSC/ssc-cluster/contrl/cluster-contrl-cache=
.o]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/cg-dbg-compile.log:make[1]: *** =
[default]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/cg-dbg-compile.log:make: *** [ssc] =
Error 2
>>
>>/perforce/buildlogs/dev/Tuesday/cg-opt-compile.log:make[2]: ***
>>[../../Build/cg/opt/Objects/SSC/ssc-cluster/contrl/cluster-contrl-cache=
.o]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/cg-opt-compile.log:make[1]: *** =
[default]
>>Error 1
>>
>>/perforce/buildlogs/dev/Tuesday/cg-opt-compile.log:make: *** [ssc] =
Error 2
>>
>>
>>
>>Please check compilation logs at http://liszt for today for the dev =
branch
>>
>>
>>

