X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C7F19D.06A16268@onstor-exch02.onstor.net>; Fri, 7 Sep 2007 14:18:32 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: PERFORCE change 25298 for review
Date: Fri, 7 Sep 2007 14:18:32 -0800
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E02BEF0F1@onstor-exch02.onstor.net>
In-Reply-To: <20070907113959.64631f53@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: PERFORCE change 25298 for review
Thread-Index: Acfxfn98gB/PRz+VR5CkV1FaAlJU9wAHk4eA
From: "Henry Lau" <henry.lau@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I will add more comments next time. To these changes, they are somewhat
closer to false alarm but just to make it clean.

Henry

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, September 07, 2007 11:40 AM
To: Henry Lau
Subject: Re: PERFORCE change 25298 for review

On 7 Sep 2007 10:34:44 -0700 henryl <henry.lau@onstor.com> wrote:

> Change 25298 by henryl@henryl-linux on 2007/09/07 10:26:38
>=20
> 	   Various Coverity fixes.
> 	   Reviewed by AmitB.   =20
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/sm-fs/fs-alloc.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-dump.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-layout.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-snap.c#12 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-trashcan.h#2 edit
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/25298?ac=3D10

Hi Henry,

I hate to be the nudge here, but this checkin comment probably doesn't
really suffice to help you. 6 months from now if you were looking
through the changes for fs-snap.c and saw a change with this comment,
would you have any idea what the change to that file might be about?
Remeber that these comments are like messages in a bottle -- to
yourself in the future.  I would think something along the lines of
"fixed this, that and the other [type problems].  found by coverity."
would be more helpful to you.

Cheers,

a
