X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8BEAD.CA9452C8@onstor-exch02.onstor.net>; Sun, 25 May 2008 14:25:01 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C8BEAD.CA9452C8"
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9648@onstor-exch02.onstor.net> <20080524162808.1604ea8c@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: Please review change list 29101
Date: Sun, 25 May 2008 14:25:01 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E042F01AB@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review change list 29101
Thread-Index: Aci99dSnyAji91mpQRGkA0lqP+p3TQAtzsrd
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C8BEAD.CA9452C8
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

You did review it a couple/few weeks back. Check your devnotes =
directory. I've been sitting on this change list for a while. If I am =
mistaken then please review this change.=20

I know we talked about it because I reverted my changes to =
/etc/init.d/networking that echoed std error to /var/log/dmesg based on =
your recommendation.

Larry

-----Original Message-----
From: Andy Sharp
Sent: Sat 5/24/2008 4:28 PM
To: Larry Scheer
Subject: Re: Please review change list 29101
=20
I don't recall reviewing this stuff, at least not for a couple weeks.

On Fri, 23 May 2008 21:23:45 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Sripal,
>    Please review these changes. Andy Sharp has already reviewed them;
> however I would like to have you look at the changes as well.
>=20
> My workspace is on linux-compile in the directory:
> /home/larrys/perforce/trees/dev
>=20
> You can run p4v on linux-compile to view the change list by selecting
> my larrys-r14-dmip client and setting the user to larrys.
>=20
> These changes to the interfaces file are necessary to remove the boot
> time messages. The defect 23467 also includes boot time messages that
> are caused by how we implemented the addroutes file. So more changes
> are needed to clean up those messages and do the adding of a default
> route and static routes correctly. However changing addroutes has a
> greater impact on the project so this work is being done in stages.
> =20
> Change 29101 by larrys@larrys-r14-dmip on 2008/05/05 18:56:18
> *pending*
>=20
>         TED00023467 Clean up messages at boot time
>         Change network/interfaces file to comment out the auto line
> for unconfigured interfaces. This eliminates messages:
>                 address: Unknown host
>                 ifconfig: `--help' gives usage information.
>                 Failed to bring up eth1.
>=20
>         Reviewed by: AndyS
>=20
> Affected files ...
>=20
> ... //depot/dev/linux/rootfs/etc/init.d/onstor-config#4 edit
> ... //depot/dev/linux/rootfs/etc/network/interfaces#3 edit
> ...
> //depot/dev/nfx-tree/code/ssc-initial-config/initial-config-linux.c#2
> edit
> ... //depot/dev/nfx-tree/code/ssc-initial-config/migrate.sh#1 edit
>=20
> Thanks,
>=20
> Larry


------_=_NextPart_001_01C8BEAD.CA9452C8
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: Please review change list 29101</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>You did review it a couple/few weeks back. Check your =
devnotes directory. I've been sitting on this change list for a while. =
If I am mistaken then please review this change.<BR>
<BR>
I know we talked about it because I reverted my changes to =
/etc/init.d/networking that echoed std error to /var/log/dmesg based on =
your recommendation.<BR>
<BR>
Larry<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Sat 5/24/2008 4:28 PM<BR>
To: Larry Scheer<BR>
Subject: Re: Please review change list 29101<BR>
<BR>
I don't recall reviewing this stuff, at least not for a couple =
weeks.<BR>
<BR>
On Fri, 23 May 2008 21:23:45 -0700 &quot;Larry Scheer&quot;<BR>
&lt;larry.scheer@onstor.com&gt; wrote:<BR>
<BR>
&gt; Sripal,<BR>
&gt;&nbsp;&nbsp;&nbsp; Please review these changes. Andy Sharp has =
already reviewed them;<BR>
&gt; however I would like to have you look at the changes as well.<BR>
&gt;<BR>
&gt; My workspace is on linux-compile in the directory:<BR>
&gt; /home/larrys/perforce/trees/dev<BR>
&gt;<BR>
&gt; You can run p4v on linux-compile to view the change list by =
selecting<BR>
&gt; my larrys-r14-dmip client and setting the user to larrys.<BR>
&gt;<BR>
&gt; These changes to the interfaces file are necessary to remove the =
boot<BR>
&gt; time messages. The defect 23467 also includes boot time messages =
that<BR>
&gt; are caused by how we implemented the addroutes file. So more =
changes<BR>
&gt; are needed to clean up those messages and do the adding of a =
default<BR>
&gt; route and static routes correctly. However changing addroutes has =
a<BR>
&gt; greater impact on the project so this work is being done in =
stages.<BR>
&gt;&nbsp;<BR>
&gt; Change 29101 by larrys@larrys-r14-dmip on 2008/05/05 18:56:18<BR>
&gt; *pending*<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; TED00023467 Clean =
up messages at boot time<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Change =
network/interfaces file to comment out the auto line<BR>
&gt; for unconfigured interfaces. This eliminates messages:<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; address: Unknown host<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; ifconfig: `--help' gives usage =
information.<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; Failed to bring up eth1.<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Reviewed by: =
AndyS<BR>
&gt;<BR>
&gt; Affected files ...<BR>
&gt;<BR>
&gt; ... //depot/dev/linux/rootfs/etc/init.d/onstor-config#4 edit<BR>
&gt; ... //depot/dev/linux/rootfs/etc/network/interfaces#3 edit<BR>
&gt; ...<BR>
&gt; =
//depot/dev/nfx-tree/code/ssc-initial-config/initial-config-linux.c#2<BR>=

&gt; edit<BR>
&gt; ... //depot/dev/nfx-tree/code/ssc-initial-config/migrate.sh#1 =
edit<BR>
&gt;<BR>
&gt; Thanks,<BR>
&gt;<BR>
&gt; Larry<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C8BEAD.CA9452C8--
