X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8BDB3.117BA4D8@onstor-exch02.onstor.net>; Sat, 24 May 2008 08:30:17 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C8BDB3.117BA4D8"
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9648@onstor-exch02.onstor.net> <4837FB60.1040902@onstor.com>
Content-class: urn:content-classes:message
Subject: RE: Please review change list 29101
Date: Sat, 24 May 2008 08:26:45 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E042F01A9@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review change list 29101
Thread-Index: Aci9kQaaM8bX5M85SJG9dDqmNWcsoQAIYyon
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Sripal Surendiran (HCL)" <sripal.surendiran@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C8BDB3.117BA4D8
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

You are correct, we will still see the SIOCADDRT messages. That work =
will be done in another change list.

Thanks for your review.

Larry


-----Original Message-----
From: Sripal Surendiran (HCL)
Sent: Sat 5/24/2008 4:26 AM
To: Larry Scheer
Cc: Tim Gardner; Andy Sharp
Subject: Re: Please review change list 29101
=20
Larry,

Changes seems to be fine.

This changes could suppress the system from calling ifup for interfaces=20
that are not configured. But still there could be error message when lo=20
tries to add the route.

"Configuring network interfaces...SIOCADDRT: Network is unreachable
run-parts: /etc/network/if-up.d/addroutes exited with return code 7"

We need to suppress route addition for loopback interface. I am not sure =

if you have already taken care.

Regards,
Sripal.

Larry Scheer wrote:
>
> Sripal,
>
>    Please review these changes. Andy Sharp has already reviewed them;=20
> however I would like to have you look at the changes as well.
>
> My workspace is on linux-compile in the directory:=20
> /home/larrys/perforce/trees/dev
>
> You can run p4v on linux-compile to view the change list by selecting=20
> my larrys-r14-dmip client and setting the user to larrys.
>
> These changes to the interfaces file are necessary to remove the boot=20
> time messages. The defect 23467 also includes boot time messages that=20
> are caused by how we implemented the addroutes file. So more changes=20
> are needed to clean up those messages and do the adding of a default=20
> route and static routes correctly. However changing addroutes has a=20
> greater impact on the project so this work is being done in stages.
>
> =20
>
> Change 29101 by larrys@larrys-r14-dmip on 2008/05/05 18:56:18 =
*pending*
>
>         TED00023467 Clean up messages at boot time
>
>         Change network/interfaces file to comment out the auto line =
for
>
>         unconfigured interfaces. This eliminates messages:
>
>                 address: Unknown host
>
>                 ifconfig: `--help' gives usage information.
>
>                 Failed to bring up eth1.
>
>         Reviewed by: AndyS
>
> Affected files ...
>
> ... //depot/dev/linux/rootfs/etc/init.d/onstor-config#4 edit
>
> ... //depot/dev/linux/rootfs/etc/network/interfaces#3 edit
>
> ...=20
> //depot/dev/nfx-tree/code/ssc-initial-config/initial-config-linux.c#2 =
edit
>
> ... //depot/dev/nfx-tree/code/ssc-initial-config/migrate.sh#1 edit
>
> Thanks,
>
> Larry
>



------_=_NextPart_001_01C8BDB3.117BA4D8
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: Please review change list 29101</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>You are correct, we will still see the SIOCADDRT =
messages. That work will be done in another change list.<BR>
<BR>
Thanks for your review.<BR>
<BR>
Larry<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Sripal Surendiran (HCL)<BR>
Sent: Sat 5/24/2008 4:26 AM<BR>
To: Larry Scheer<BR>
Cc: Tim Gardner; Andy Sharp<BR>
Subject: Re: Please review change list 29101<BR>
<BR>
Larry,<BR>
<BR>
Changes seems to be fine.<BR>
<BR>
This changes could suppress the system from calling ifup for =
interfaces<BR>
that are not configured. But still there could be error message when =
lo<BR>
tries to add the route.<BR>
<BR>
&quot;Configuring network interfaces...SIOCADDRT: Network is =
unreachable<BR>
run-parts: /etc/network/if-up.d/addroutes exited with return code =
7&quot;<BR>
<BR>
We need to suppress route addition for loopback interface. I am not =
sure<BR>
if you have already taken care.<BR>
<BR>
Regards,<BR>
Sripal.<BR>
<BR>
Larry Scheer wrote:<BR>
&gt;<BR>
&gt; Sripal,<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp; Please review these changes. Andy Sharp has =
already reviewed them;<BR>
&gt; however I would like to have you look at the changes as well.<BR>
&gt;<BR>
&gt; My workspace is on linux-compile in the directory:<BR>
&gt; /home/larrys/perforce/trees/dev<BR>
&gt;<BR>
&gt; You can run p4v on linux-compile to view the change list by =
selecting<BR>
&gt; my larrys-r14-dmip client and setting the user to larrys.<BR>
&gt;<BR>
&gt; These changes to the interfaces file are necessary to remove the =
boot<BR>
&gt; time messages. The defect 23467 also includes boot time messages =
that<BR>
&gt; are caused by how we implemented the addroutes file. So more =
changes<BR>
&gt; are needed to clean up those messages and do the adding of a =
default<BR>
&gt; route and static routes correctly. However changing addroutes has =
a<BR>
&gt; greater impact on the project so this work is being done in =
stages.<BR>
&gt;<BR>
&gt;&nbsp;<BR>
&gt;<BR>
&gt; Change 29101 by larrys@larrys-r14-dmip on 2008/05/05 18:56:18 =
*pending*<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; TED00023467 Clean =
up messages at boot time<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Change =
network/interfaces file to comment out the auto line for<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; unconfigured =
interfaces. This eliminates messages:<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; address: Unknown host<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; ifconfig: `--help' gives usage =
information.<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nb=
sp;&nbsp;&nbsp;&nbsp;&nbsp; Failed to bring up eth1.<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Reviewed by: =
AndyS<BR>
&gt;<BR>
&gt; Affected files ...<BR>
&gt;<BR>
&gt; ... //depot/dev/linux/rootfs/etc/init.d/onstor-config#4 edit<BR>
&gt;<BR>
&gt; ... //depot/dev/linux/rootfs/etc/network/interfaces#3 edit<BR>
&gt;<BR>
&gt; ...<BR>
&gt; =
//depot/dev/nfx-tree/code/ssc-initial-config/initial-config-linux.c#2 =
edit<BR>
&gt;<BR>
&gt; ... //depot/dev/nfx-tree/code/ssc-initial-config/migrate.sh#1 =
edit<BR>
&gt;<BR>
&gt; Thanks,<BR>
&gt;<BR>
&gt; Larry<BR>
&gt;<BR>
<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C8BDB3.117BA4D8--
