X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8BB06.E90D00E0@onstor-exch02.onstor.net>; Tue, 20 May 2008 22:52:53 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review code change for TED 21181
Date: Tue, 20 May 2008 22:52:52 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0A0F8C18@onstor-exch02.onstor.net>
In-Reply-To: <20080520210815.04d3679d@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review code change for TED 21181
Thread-Index: Aci6+EwYjCAXaN4ZQHK2e59ivCEi2gADoj5Q
References: <BB375AF679D4A34E9CA8DFA650E2B04E0A0F893D@onstor-exch02.onstor.net><20080520161707.299369f7@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E0A0F8ABC@onstor-exch02.onstor.net><20080520165636.0d0382ac@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E0A0F8B78@onstor-exch02.onstor.net> <20080520210815.04d3679d@ripper.onstor.net>
From: "Ed Kwan" <ed.kwan@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I made both changes that you recommended.  Please review again.  Thanks!

> -----Original Message-----
> From: Andy Sharp
> Sent: Tuesday, May 20, 2008 9:08 PM
> To: Ed Kwan
> Subject: Re: Please review code change for TED 21181
>=20
> On Tue, 20 May 2008 18:41:06 -0700 "Ed Kwan" <ed.kwan@onstor.com>
wrote:
>=20
> > Hi Andy,
> >
> > Don't think you can put a pipe command in a variable.
> >
> > eng236# cat s
> > #!/bin/sh
> > PCMD=3D"| wc"
> > ls $PCMD
>=20
> eval ls $PCMD
>=20
> sorry, forgot the eval
>=20
> >
> > eng236# ./s
> > ls: wc: No such file or directory
> > ls: |: No such file or directory
> >
> > Ed
> >
> > > nfx-tree/Tools/cw_install.in
> > >
> > >      line 854  for maintenance reasons, there should only be one
> > >      tar command:
> > >
> > >      if "$imode" then
> > >      	V=3D-v
> > > 	TAR_CHATTER_CMD=3D"| awk ' BEGIN { cnt=3D0 } { if ( (++cnt %
> > > 500 )
> > =3D=3D 0
> > > ) { print cnt " files extracted" } } '"
> > >      else
> > >      	V=3D
> > > 	TAR_CHATTER_CMD=3D
> > >      fi
> > >
> > >      nice -n 15 tar $V -zxpf "${tdir}/${tball}" -s
> > '+./usr/local/agile$++'
> > > \
> > >      			-s '+./usr/man/.*++' -s
> > > '+./usr/local/man/.*++'
> > .
> > > $TAR_CHATTER_CMD
> > >
> >
