X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8B6B7.7ACC0CB0@onstor-exch02.onstor.net>; Thu, 15 May 2008 11:14:13 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 29217
Date: Thu, 15 May 2008 11:14:13 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09FCEF78@onstor-exch02.onstor.net>
In-Reply-To: <20080515105802.722cacf9@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 29217
Thread-Index: Aci2tTgxmfYdyDFiRfSWm2oPvfHFvAAAhO1w
From: "Tim Gardner" <tim.gardner@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

genlib.h: 78
there is some commented out code at line 89

I'm compiling a fix for the build breakage now.

> -----Original Message-----
> From: Andy Sharp
> Sent: Thursday, May 15, 2008 10:58 AM
> To: Tim Gardner
> Subject: Re: please review 29217
>=20
> compile tested on cougar/cheetah.  cheetah still broken on sm-except.
>=20
>=20
> On Wed, 14 May 2008 20:55:04 -0700 "Tim Gardner"
> <tim.gardner@onstor.com> wrote:
>=20
> > genlib-openbsd.c
> > 32: get rid of all this code that is commented out. FYI: #if 0 /
> > #endif is easier.
>=20
> Dead code removed.
>=20
> > 78: more dead code; delete it
>=20
> 78?
>=20
> > cmd_promupgrade.c
> > 1189: why ignore the fclose return value. cast it to (void) is you
> > really want to ignore it.
>=20
> Convention is not to cast system calls to void return, especially
> system calls that have little or no value to their return value.
>=20
> > cmd_system.c
> > 381: this concerns me. think you explained it to me once. need to
hear
> > it again.
>=20
> Really on Bobcat and Cougar, there is no need to send a message to the
> embedded processors to halt, they will get a reset from when the SSC
> resets.  On cougar, this seems to be causing the TXRX to reset while
> the SSC is still running, and that causes a PCI bus reset, which
> crashes the kernel when it tries to access the compact flash.
>=20
> > cmd_upgrade.c
> > 1390: two blank lines not enough huh?
>=20
> fixed.
>=20
> > 1408,1420: why the change from using my_print which is used all
> > through this file?
>=20
> fixed.
>=20
> > Need some comments here why this function is only defined for
cheetah.
>=20
> fixed.
>=20
> > 2409: extra line
>=20
> removed multiple blank lines at the end of the file
>=20
> > genlib.c
> > 27: remove dead code
>=20
> fixed
>=20
> > 107: more dead code
>=20
> fixed
>=20
> > 205: and yet more unused code
>=20
> fixed
>=20
> > Nice job. Glad to see the death of the duplicate pm code.
> >
> > > -----Original Message-----
> > > From: Andy Sharp
> > > Sent: Wednesday, May 14, 2008 7:12 PM
> > > To: Tim Gardner
> > > Subject: please review 29217
> > >
> > > Built and tested on: Cougar, Bobcat/BSD, Cheetah/BSD
> > > Built on Bobcat/Linux
> > >
> > > Testing: system config reset (causes a reboot)
> > >          system reboot
> > >          system reboot -s
> > >          system config copy;system config restore (causes a
reboot)
> > >          CLI FTI (causes a reboot)
> > >
> > > Not tested:
> > >
> > >     I can't tell if an individual board on a Cheetah has ~not~
> > >     been rebooted when I hope it has.  But regular reboots seem to
> > >     work, and I get this output:
> > > Slot 1 rebooted
> > > Slot 2 rebooted
> > >     so I'm hopeful.
> > >
> > >     system reset ssc (on Cheetahs) - I can't find the
> > >     command although it seems to be in the code.
> > >
> > >
> > >
> > > Change 29217 by andys@ripper on 2008/05/13 16:51:57 *pending*
> > >
> > >         Properly fix build problem on sabre tooth - and try to
clean
> > up
> > >         code in SSC that reboots the system by coalescing as much
of
> > it
> > >         as possible to one generic place that is more sanely
> > maintainable.
> > >
> > >         This is a continuation of change 29108 which attempts to
> > > deal
> > with
> > >
> > >         >TED00023034 - kernel crash: DBE in yenta_irq during
> > >         >shutdown
> > >
> > >         by changing the way we reboot cougar.  It turns out there
> > > were a couple of other places in our code that reboot the system
in
> > >         their own private little ways.
> > >
> > >         reviewed by
> > >
> > > Affected files ...
> > >
> > > ... //depot/dev/linux/kernel/linux-mips-2.6/.git/index#9 edit
> > > ... //depot/dev/linux/kernel/linux-mips-
> > > 2.6/.git/objects/34/fad0113ebaca1d4983577e6a52dd8827a86e4b#1 add
> > > ... //depot/dev/linux/kernel/linux-mips-
> > > 2.6/.git/objects/55/456bc4702b7bad291f1f5c959811042fa2f432#1 add
> > > ... //depot/dev/linux/kernel/linux-mips-
> > > 2.6/.git/objects/6e/0ef3fa3742fe19dfda7b55dd2682cd0f748afe#1 add
> > > ... //depot/dev/linux/kernel/linux-mips-
> > > 2.6/.git/objects/70/8d47f1f69eb3f589015f1c6bd8465e6becfb81#1 add
> > > ... //depot/dev/linux/kernel/linux-mips-
> > > 2.6/.git/objects/f8/d80420def2316ffa7a62271c232a2209f3b9a5#1 add
> > > ...
//depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-
> > > 2.6.22#5 edit
> > > ... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#18 edit
> > > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.c#13 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#7 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/cm-util-bc.c#12 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-linux.c#7 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-openbsd.c#8 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib.c#1 add
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib.h#6 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/linux.h#7 edit
> > > ... //depot/dev/nfx-tree/code/ssc-genlib/openbsd.h#7 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#16 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#12 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#46 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#31 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#9 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_initial.c#1 edit
> > > ... //depot/dev/nfx-tree/code/ssc-pm/linux.c#6 edit
> > > ... //depot/dev/nfx-tree/code/ssc-pm/openbsd.c#6 edit
> > > ... //depot/dev/nfx-tree/code/ssc-pm/pm.c#15 edit
> > > ... //depot/dev/nfx-tree/code/ssc-pm/pm.h#8 edit
