X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8B63F.755DF428@onstor-exch02.onstor.net>; Wed, 14 May 2008 20:55:04 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 29217
Date: Wed, 14 May 2008 20:55:04 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09FCECEB@onstor-exch02.onstor.net>
In-Reply-To: <20080514191154.7911e1ce@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 29217
Thread-Index: Aci2MQvS1MiLZGyxSamNQrDgAhxKQwACwkAg
From: "Tim Gardner" <tim.gardner@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

genlib-openbsd.c
32: get rid of all this code that is commented out. FYI: #if 0 / #endif
is easier.

78: more dead code; delete it

cmd_promupgrade.c
1189: why ignore the fclose return value. cast it to (void) is you
really want to ignore it.

cmd_system.c
381: this concerns me. think you explained it to me once. need to hear
it again.

cmd_upgrade.c
1390: two blank lines not enough huh?
1408,1420: why the change from using my_print which is used all through
this file?
Need some comments here why this function is only defined for cheetah.

2409: extra line

genlib.c
27: remove dead code
107: more dead code
205: and yet more unused code

Nice job. Glad to see the death of the duplicate pm code.

> -----Original Message-----
> From: Andy Sharp
> Sent: Wednesday, May 14, 2008 7:12 PM
> To: Tim Gardner
> Subject: please review 29217
>=20
> Built and tested on: Cougar, Bobcat/BSD, Cheetah/BSD
> Built on Bobcat/Linux
>=20
> Testing: system config reset (causes a reboot)
>          system reboot
>          system reboot -s
>          system config copy;system config restore (causes a reboot)
>          CLI FTI (causes a reboot)
>=20
> Not tested:
>=20
>     I can't tell if an individual board on a Cheetah has ~not~
>     been rebooted when I hope it has.  But regular reboots seem to
>     work, and I get this output:
> Slot 1 rebooted
> Slot 2 rebooted
>     so I'm hopeful.
>=20
>     system reset ssc (on Cheetahs) - I can't find the
>     command although it seems to be in the code.
>=20
>=20
>=20
> Change 29217 by andys@ripper on 2008/05/13 16:51:57 *pending*
>=20
>         Properly fix build problem on sabre tooth - and try to clean
up
>         code in SSC that reboots the system by coalescing as much of
it
>         as possible to one generic place that is more sanely
maintainable.
>=20
>         This is a continuation of change 29108 which attempts to deal
with
>=20
>         >TED00023034 - kernel crash: DBE in yenta_irq during shutdown
>=20
>         by changing the way we reboot cougar.  It turns out there were
>         a couple of other places in our code that reboot the system in
>         their own private little ways.
>=20
>         reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/linux/kernel/linux-mips-2.6/.git/index#9 edit
> ... //depot/dev/linux/kernel/linux-mips-
> 2.6/.git/objects/34/fad0113ebaca1d4983577e6a52dd8827a86e4b#1 add
> ... //depot/dev/linux/kernel/linux-mips-
> 2.6/.git/objects/55/456bc4702b7bad291f1f5c959811042fa2f432#1 add
> ... //depot/dev/linux/kernel/linux-mips-
> 2.6/.git/objects/6e/0ef3fa3742fe19dfda7b55dd2682cd0f748afe#1 add
> ... //depot/dev/linux/kernel/linux-mips-
> 2.6/.git/objects/70/8d47f1f69eb3f589015f1c6bd8465e6becfb81#1 add
> ... //depot/dev/linux/kernel/linux-mips-
> 2.6/.git/objects/f8/d80420def2316ffa7a62271c232a2209f3b9a5#1 add
> ... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-
> 2.6.22#5 edit
> ... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#18 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.c#13 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#7 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/cm-util-bc.c#12 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-linux.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-openbsd.c#8 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/genlib.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-genlib/genlib.h#6 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/linux.h#7 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/openbsd.h#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#16 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#12 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#46 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#31 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#9 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_initial.c#1 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/linux.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/openbsd.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pm.c#15 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pm.h#8 edit
