X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8AF08.645B0B10@onstor-exch02.onstor.net>; Mon, 5 May 2008 16:33:15 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28788
Date: Mon, 5 May 2008 16:33:15 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09CA5BA7@onstor-exch02.onstor.net>
In-Reply-To: <20080505161815.7801e0ab@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28788
Thread-Index: AcivBkvYErndsnyIQMuLGgqCyipwLAAAZ1zQ
References: <20080505161815.7801e0ab@ripper.onstor.net>
From: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

OK.=20

No I have no idea how that line in bobcat_mgmt_bus.c should look like.

>-----Original Message-----
>From: Andy Sharp
>Sent: Monday, May 05, 2008 4:18 PM
>To: Maxim Kozlovsky
>Subject: please review 28788
>
>In bobcat_mgmt_bus.c, function mgmtbus_irq_free, the first line is in
>need of fixin', I'm hoping you know how ~:^) =20
The rest I'm actually
>expecting is not broken.  I've been running the kernel on my cougar for
>weeks.  The genlib and nfxsh changes are running on one of the QA
>filers and so far no panics.
>
>
>Change 28788 by andys@ripper on 2008/04/10 14:27:27 *pending*
>
>        TED00023034 - kernel crash: DBE in yenta_irq during shutdown
>
>        Implement the device exit method: release the interrupt and
>        netdev resources.
>
>        Minor message cleanup in mgmtbus_irq_setup.
>
>        Currently pursuing the theory that the TXRX is being sent a
>        message to reboot/reset, and in doing so, it's resetting the
>        PCI bus, which makes the 1125 very unhappy as it might be still
>        using it to scribble on the compact flash.
>
>        Therefore adding several changes to the code to try and get
after
>        this problem: ifconfig mgmtbus down in /etc/init.d/onstor and
>        exit routine in the mgmtbus driver (probably won't do anything,
>        but it makes it possible to run the driver as a module), and
>        not bothering to send a reset to the TXRX when doing a shutdown
>        because stopping pm will have the equivalent logical effect.
>
>        reviewed by
>
>Affected files ...
>
>... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-
>bus/bobcat_mgmt_bus.c#4 edit
>... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-
>bus/cougar_mgmt_bus.c#6 edit
>... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-
>bus.c#11 edit
>... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-
>bus.h#5 edit
>... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#6 edit
>... //depot/dev/nfx-tree/code/ssc-genlib/cm-reboot-linux.c#5 delete
>... //depot/dev/nfx-tree/code/ssc-genlib/cm-reboot-openbsd.c#2 delete
>... //depot/dev/nfx-tree/code/ssc-genlib/cm-util-bc.c#11 edit
>... //depot/dev/nfx-tree/code/ssc-genlib/genlib-linux.c#6 edit
>... //depot/dev/nfx-tree/code/ssc-genlib/genlib-openbsd.c#6 edit
>... //depot/dev/nfx-tree/code/ssc-genlib/linux.h#6 edit
>... //depot/dev/nfx-tree/code/ssc-genlib/openbsd.h#6 edit
>... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#45 edit

