X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8AC9F.BEBE4A20@onstor-exch02.onstor.net>; Fri, 2 May 2008 14:59:07 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 29001
Date: Fri, 2 May 2008 14:59:07 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C95CA@onstor-exch02.onstor.net>
In-Reply-To: <20080502131333.034adaf9@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 29001
Thread-Index: AciskP+VdoPoLlVcQfaEftFMpjYX/gADrq/g
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Looks ok.

-----Original Message-----
From: Andy Sharp=20
Sent: Friday, May 02, 2008 1:14 PM
To: Larry Scheer
Subject: Re: please review 29001

On Fri, 2 May 2008 11:56:30 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I didn't check close enough, did you cd into the directory? I didn't
> see a dirname in front of the cluster logs.

OK, think I fixed it.

> -----Original Message-----
> From: Andy Sharp=20
> Sent: Friday, May 02, 2008 11:54 AM
> To: Larry Scheer
> Subject: Re: please review 29001
>=20
> On Fri, 2 May 2008 11:43:53 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
>=20
> > linux/rootfs/etc/logrotate.d/onstor
> >=20
> >      looks good
> >=20
> > nfx-tree/code/sm-elog/elog-api.h
> >=20
> >      looks good
> >=20
> > nfx-tree/code/ssc-cluster/cluster-server.c
> >=20
> >      looks good
> >=20
> > nfx-tree/code/ssc-nfxsh/cmd_elog.c
> >=20
> >      looks good
> >=20
> > nfx-tree/code/ssc-nfxsh/cmd_upgrade.c
> >=20
> >      looks good
> >=20
> > nfx-tree/code/ssc-nfxsh/verify_install.in
> >=20
> >      Line 1147: I think the shell will try to expand the '*' in
> >      clusServ.log* you may need to quote that or escape the * if
> > your intention was to use it as a wildcard in the mv command.
>=20
> I do want the shell to expand it right there, so that all the files
> that match it are in the list.  But I'm glad you mentioned that,
> because it made me realize that vscan should also have a * after it,
> because it can be rotated as well.  Actually, Rendell pointed that out
> to me because it needed to change in support.sh as well.  It's a good
> thing I got this reviewed by several people!
>=20
> > nfx-tree/code/ssc-support/support.sh
> >=20
> >      looks good
> >=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Thursday, May 01, 2008 5:01 PM
> > To: Larry Scheer
> > Cc: Chris Vandever; Rendell Fong
> > Subject: please review 29001
> >=20
> > pick the parts you feel like reviewing.  i sent it to you three for
> > obvious reasons known only to me.
> >=20
> > Change 29001 by andys@ripper on 2008/04/28 10:40:43 *pending*
> >=20
> >         TED00022198 - upgrade log file should be located in
> > /var/log/onstor
> >        =20
> >         Somehow these guys {clusServ.log, sys_upgrade.log, vscan}
> > managed
> >         to escape Agile training day.  Put them where they belong,
> >         and add to logrotate config file to rotate clusServ.log and
> > vscan.
> >        =20
> >         Have upgrade move the log files to their new home.
> >        =20
> >         Have support.sh upload the files from the correct locations.
> >        =20
> >         TED00023583 - NFXSH SEGFAULT when system upgrade command had
> > typo
> >        =20
> >         This was really fixed in
> >         changelist#29028 Clear file pointer when it's closed
> >         but also, don't call fclose() unless there is a file
> > pointer, and axe the error message as fclose() can't really fail,
> > and even
> >         if it could, it wouldn't do us any good to know.
> >        =20
> >         reviewed by
> >=20
> > Affected files ...
> >=20
> > ... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#5 edit
> > ... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#30 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-support/support.sh#27 edit
> >=20
