X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8AC7C.BD017780@onstor-exch02.onstor.net>; Fri, 2 May 2008 10:48:32 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 29001
Date: Fri, 2 May 2008 10:48:32 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624AE3@onstor-exch02.onstor.net>
In-Reply-To: <20080501170123.4412c63c@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 29001
Thread-Index: Acir56kgG78DrnH+QdeJ2pXJDN6+3AAlM6iw
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

If we are now logrotating the vscan file (assuming I understand this
correctly), then line 3260 in support.sh will need to be changed from
"vscan" to "vscan*".  Otherwise, looks good.


-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, May 01, 2008 5:01 PM
To: Larry Scheer
Cc: Chris Vandever; Rendell Fong
Subject: please review 29001

pick the parts you feel like reviewing.  i sent it to you three for
obvious reasons known only to me.

Change 29001 by andys@ripper on 2008/04/28 10:40:43 *pending*

        TED00022198 - upgrade log file should be located in
/var/log/onstor
       =20
        Somehow these guys {clusServ.log, sys_upgrade.log, vscan}
managed
        to escape Agile training day.  Put them where they belong,
        and add to logrotate config file to rotate clusServ.log and
vscan.
       =20
        Have upgrade move the log files to their new home.
       =20
        Have support.sh upload the files from the correct locations.
       =20
        TED00023583 - NFXSH SEGFAULT when system upgrade command had
typo
       =20
        This was really fixed in
        changelist#29028 Clear file pointer when it's closed
        but also, don't call fclose() unless there is a file pointer,
        and axe the error message as fclose() can't really fail, and
even
        if it could, it wouldn't do us any good to know.
       =20
        reviewed by

Affected files ...

... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#5 edit
... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#3 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#7 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#10 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#30 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#7 edit
... //depot/dev/nfx-tree/code/ssc-support/support.sh#27 edit

