X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8AB39.9FD170D0@onstor-exch02.onstor.net>; Wed, 30 Apr 2008 20:15:36 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C8AB39.9FD170D0"
References: <20080430092623.217d6c4e@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E09624ACA@onstor-exch02.onstor.net> <20080430170427.767f4f05@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: FW: please review - change 29032
Date: Wed, 30 Apr 2008 20:14:57 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0149B6B7@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review - change 29032
Thread-Index: AcirHuxXpETrjaw/RYeB4aZ1Yefs9wAGpw+W
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C8AB39.9FD170D0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Do the /var/log/exim4/mainlog* files need to be copied?


-----Original Message-----
From: Andy Sharp
Sent: Wed 4/30/2008 5:04 PM
To: Rendell Fong
Subject: Re: please review - change 29032
=20
nfx-tree/code/ssc-support/support.sh

     line 1764, have you tested this?  I always worry about setting
     variables in loops only to have that setting not be relevant
     outside the loop.  maybe that's only while loops.  but it makes
     me nervous.  of course you tested it, i'm only joking.  or am i?

     line 3251, this will always not be true in linux, so to save some
     grief, put an if OPENBSD ; then ... fi around it.

     line 3292, this needs to be fixed for linux.  correct path is
     /var/spool/cron/crontabs/root

     line 3294, not sure /var/crash is correct path on linux?



On Wed, 30 Apr 2008 13:25:34 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Ok, I my tweaks are done.  The file is in the same place.
>=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Wednesday, April 30, 2008 9:26 AM
> To: Rendell Fong
> Subject: Re: please review - change 29032
>=20
> On Tue, 29 Apr 2008 17:53:04 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
>=20
> > This change was tested by running system get all/logs on a Bobcat.
> >=20
> > The system get all info was copied to the following directory:
> > =20
> >
> =
/n/dw/bycase_onstor_test/case0000001-case0002000/case1234.eng59/eng59,sn
> > _0452040003/system_get_all,20080429_17180847
> >=20
> > This verifies that the files as specified in the defect are no
> > longer being copied to multiple target directories.
> >=20
> > -------------------------------------------------------
> >=20
> > Change: 29032
> >=20
> > Client: rendellf-test
> >=20
> > User:   rendellf
> >=20
> > Description:
> >     TED23019: EMRS - support.sh needs to be updated
> >=20
> >     Fixed support.sh to avoid duplicate copy of auth log, cluster
> > log, and    =20
> >     vscan files during system get all/tse/logs cmds.  Display
> > appropriate message=20
> >     when no files are available to be uploaded.
> >=20
> > Files:
> >     //depot/dev/nfx-tree/code/ssc-support/support.sh    # edit
>=20
>=20
> nfx-tree/code/ssc-support/support.sh
>=20
>      line 1762, just use    if [ $# =3D 0 ]   instead of the pipe.
>=20
>      line 3230, this is the worst code EVER.  this block of calls to
>      put_files_in_target_location.  do all of us a favor and clean
>      it up, fix it, etc.  feel free to ask me what i'm talking about.
>      i assume the difference between today's version and last night's
>      version is the /var/log/onstor/samba stuff?
>=20
>=20
>=20


------_=_NextPart_001_01C8AB39.9FD170D0
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>FW: please review - change 29032</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Do the /var/log/exim4/mainlog* files need to be =
copied?<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Wed 4/30/2008 5:04 PM<BR>
To: Rendell Fong<BR>
Subject: Re: please review - change 29032<BR>
<BR>
nfx-tree/code/ssc-support/support.sh<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; line 1764, have you tested this?&nbsp; I always =
worry about setting<BR>
&nbsp;&nbsp;&nbsp;&nbsp; variables in loops only to have that setting =
not be relevant<BR>
&nbsp;&nbsp;&nbsp;&nbsp; outside the loop.&nbsp; maybe that's only while =
loops.&nbsp; but it makes<BR>
&nbsp;&nbsp;&nbsp;&nbsp; me nervous.&nbsp; of course you tested it, i'm =
only joking.&nbsp; or am i?<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; line 3251, this will always not be true in =
linux, so to save some<BR>
&nbsp;&nbsp;&nbsp;&nbsp; grief, put an if OPENBSD ; then ... fi around =
it.<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; line 3292, this needs to be fixed for =
linux.&nbsp; correct path is<BR>
&nbsp;&nbsp;&nbsp;&nbsp; /var/spool/cron/crontabs/root<BR>
<BR>
&nbsp;&nbsp;&nbsp;&nbsp; line 3294, not sure /var/crash is correct path =
on linux?<BR>
<BR>
<BR>
<BR>
On Wed, 30 Apr 2008 13:25:34 -0700 &quot;Rendell Fong&quot;<BR>
&lt;rendell.fong@onstor.com&gt; wrote:<BR>
<BR>
&gt; Ok, I my tweaks are done.&nbsp; The file is in the same place.<BR>
&gt;<BR>
&gt;<BR>
&gt; -----Original Message-----<BR>
&gt; From: Andy Sharp<BR>
&gt; Sent: Wednesday, April 30, 2008 9:26 AM<BR>
&gt; To: Rendell Fong<BR>
&gt; Subject: Re: please review - change 29032<BR>
&gt;<BR>
&gt; On Tue, 29 Apr 2008 17:53:04 -0700 &quot;Rendell Fong&quot;<BR>
&gt; &lt;rendell.fong@onstor.com&gt; wrote:<BR>
&gt;<BR>
&gt; &gt; This change was tested by running system get all/logs on a =
Bobcat.<BR>
&gt; &gt;<BR>
&gt; &gt; The system get all info was copied to the following =
directory:<BR>
&gt; &gt;&nbsp;<BR>
&gt; &gt;<BR>
&gt; =
/n/dw/bycase_onstor_test/case0000001-case0002000/case1234.eng59/eng59,sn<=
BR>
&gt; &gt; _0452040003/system_get_all,20080429_17180847<BR>
&gt; &gt;<BR>
&gt; &gt; This verifies that the files as specified in the defect are =
no<BR>
&gt; &gt; longer being copied to multiple target directories.<BR>
&gt; &gt;<BR>
&gt; &gt; -------------------------------------------------------<BR>
&gt; &gt;<BR>
&gt; &gt; Change: 29032<BR>
&gt; &gt;<BR>
&gt; &gt; Client: rendellf-test<BR>
&gt; &gt;<BR>
&gt; &gt; User:&nbsp;&nbsp; rendellf<BR>
&gt; &gt;<BR>
&gt; &gt; Description:<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; TED23019: EMRS - support.sh needs to =
be updated<BR>
&gt; &gt;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; Fixed support.sh to avoid duplicate =
copy of auth log, cluster<BR>
&gt; &gt; log, and&nbsp;&nbsp;&nbsp;&nbsp;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; vscan files during system get =
all/tse/logs cmds.&nbsp; Display<BR>
&gt; &gt; appropriate message<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; when no files are available to be =
uploaded.<BR>
&gt; &gt;<BR>
&gt; &gt; Files:<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp; =
//depot/dev/nfx-tree/code/ssc-support/support.sh&nbsp;&nbsp;&nbsp; # =
edit<BR>
&gt;<BR>
&gt;<BR>
&gt; nfx-tree/code/ssc-support/support.sh<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; line 1762, just use&nbsp;&nbsp;&nbsp; =
if [ $# =3D 0 ]&nbsp;&nbsp; instead of the pipe.<BR>
&gt;<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; line 3230, this is the worst code =
EVER.&nbsp; this block of calls to<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; put_files_in_target_location.&nbsp; =
do all of us a favor and clean<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; it up, fix it, etc.&nbsp; feel free =
to ask me what i'm talking about.<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; i assume the difference between =
today's version and last night's<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; version is the /var/log/onstor/samba =
stuff?<BR>
&gt;<BR>
&gt;<BR>
&gt;<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C8AB39.9FD170D0--
