X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8AADF.6DF11540@onstor-exch02.onstor.net>; Wed, 30 Apr 2008 09:29:57 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review - change 29032
Date: Wed, 30 Apr 2008 09:29:57 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624AC8@onstor-exch02.onstor.net>
In-Reply-To: <20080430092623.217d6c4e@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review - change 29032
Thread-Index: Aciq3u5aeuvw4LkwT++3tCMv3pJrJQAAFTsg
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Yes, I'm doing a few more tweaks based on RonB's input.


-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, April 30, 2008 9:26 AM
To: Rendell Fong
Subject: Re: please review - change 29032

On Tue, 29 Apr 2008 17:53:04 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> This change was tested by running system get all/logs on a Bobcat.
>=20
> The system get all info was copied to the following directory:
> =20
>
/n/dw/bycase_onstor_test/case0000001-case0002000/case1234.eng59/eng59,sn
> _0452040003/system_get_all,20080429_17180847
>=20
> This verifies that the files as specified in the defect are no longer
> being copied to multiple target directories.
>=20
> -------------------------------------------------------
>=20
> Change: 29032
>=20
> Client: rendellf-test
>=20
> User:   rendellf
>=20
> Description:
>     TED23019: EMRS - support.sh needs to be updated
>=20
>     Fixed support.sh to avoid duplicate copy of auth log, cluster log,
> and    =20
>     vscan files during system get all/tse/logs cmds.  Display
> appropriate message=20
>     when no files are available to be uploaded.
>=20
> Files:
>     //depot/dev/nfx-tree/code/ssc-support/support.sh    # edit


nfx-tree/code/ssc-support/support.sh

     line 1762, just use    if [ $# =3D 0 ]   instead of the pipe.

     line 3230, this is the worst code EVER.  this block of calls to
     put_files_in_target_location.  do all of us a favor and clean
     it up, fix it, etc.  feel free to ask me what i'm talking about.
     i assume the difference between today's version and last night's
     version is the /var/log/onstor/samba stuff?



