X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8AA26.BFDBDD48@onstor-exch02.onstor.net>; Tue, 29 Apr 2008 11:27:58 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28933 BMF
Date: Tue, 29 Apr 2008 11:27:58 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C95A5@onstor-exch02.onstor.net>
In-Reply-To: <20080429103457.77d86a97@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28933 BMF
Thread-Index: AciqH1h6EMWIkuCAScSQDs7DVFfiOAAB2NGg
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Looks good


-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, April 29, 2008 10:35 AM
To: Larry Scheer
Subject: please review 28933 BMF

Would like this to go into sub#20.


Change 28933 by andys@ripper on 2008/04/23 18:19:40 *pending*

	TED00023268 - Cougar: Elog rotate happens weekly once not daily
=09
	The elog log file wasn't being rotated due to size even though
	it should be.
=09
	I did test to see that it was rotating based on size, but
perhaps
	it got rotated for time instead.
=09
	Apparently the order of the directives in the config file are
	important, although the man page for logrotate doesn't mention
it,
	so how it's important itsn't quite clear, although it seemed to
	just ignore the "size" directive if it came before some other
	directive.  But moving the "size" directive down below the
	"weekly" directive seems to work.  I'm not sure the "weekly"
	directive is still working.  I did a specific test for that and
	it didn't seem to do it, but at least it is rotating for size
now,
	which is more important.
=09
	reviewed by

Affected files ...

... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#4 edit

