X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8A980.544960D8@onstor-exch02.onstor.net>; Mon, 28 Apr 2008 15:36:41 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 29000
Date: Mon, 28 Apr 2008 15:36:41 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C95A3@onstor-exch02.onstor.net>
In-Reply-To: <20080428153140.1d4da71a@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 29000
Thread-Index: Acipf6DX38VoyFwCTqanEcMgz7G63wAAK61A
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Looks good.

-----Original Message-----
From: Andy Sharp=20
Sent: Monday, April 28, 2008 3:32 PM
To: Larry Scheer
Subject: Re: please review 29000

Hm, in response to all this consternation with _system config reset_, I
was doing additional testing and decided the error message needed a
newline, so I added that.  (And as a side note, it looks to me like the
FTI starts just fine, but you didn't hear it from me.)

So a quick re-review is in order.  Sorry 'bout that.

Cheers,

a


On Mon, 28 Apr 2008 14:46:20 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Good-enough.
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Monday, April 28, 2008 2:36 PM
> To: Larry Scheer
> Subject: Re: please review 29000
>=20
> On Mon, 28 Apr 2008 14:17:44 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
>=20
> > Forgot to ask, what tests were run on these changes?
> > (Complying with new review/check-in requirements...)=20
>=20
> Which I have no intention of paying any attention to...
>=20
> Except that one.
>=20
> I did a _system config reset_ with no problems.
>=20
> > -----Original Message-----
> > From: Larry Scheer=20
> > Sent: Monday, April 28, 2008 2:09 PM
> > To: Andy Sharp
> > Subject: RE: please review 29000
> >=20
> > nfx-tree/code/ssc-nfxsh/cmd_flash.c
> >=20
> >      Looks good
> >=20
> > nfx-tree/code/ssc-nfxsh/linux.h
> >=20
> >      Looks good
> >=20
> >=20
> > nfx-tree/code/ssc-nfxsh/openbsd.h
> >=20
> >      Looks good
> >=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Monday, April 28, 2008 1:37 PM
> > To: Larry Scheer
> > Subject: Re: please review 29000
> >=20
> > On Mon, 28 Apr 2008 12:36:29 -0700 "Larry Scheer"
> > <larry.scheer@onstor.com> wrote:
> >=20
> > > nfx-tree/code/ssc-nfxsh/linux.h
> > >=20
> > >      Line 105: I don't understand the reason for while (0) {}. --
> > >      Just curious...
> >=20
> > Allows you to put a semicolon at the end of the macro, making it
> > look more like real code.  Adds just a touch of readability.  I
> > could just put curly braces around the whole thing, but I hate that.
> >=20
> > Which reminds me, I forgot to add
> > nfx-tree/code/ssc-nfxsh/cmd_flash.c to this changelist.  Duh.
> >=20
> > Resubmit.
> >=20
> > > nfx-tree/code/ssc-nfxsh/openbsd.h
> > >=20
> > >      Line 94: I see the while (0) {} again so it must be
> > > intentional; what does this do?
> > >=20
> > > -----Original Message-----
> > > From: Andy Sharp=20
> > > Sent: Monday, April 28, 2008 10:33 AM
> > > To: Larry Scheer
> > > Subject: please review 29000
> > >=20
> > > Change 29000 by andys@ripper on 2008/04/28 10:30:59 *pending*
> > >=20
> > >         TED 23181 Cougar:system config reset does not bring back
> > > the root
> > >         or admin password to default value
> > >        =20
> > >         Output the error messages to the console as well as the
> > > log so that the user is aware something didn't go right.
> > >        =20
> > >         reviewed by
> > >=20
> > > Affected files ...
> > >=20
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#14 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#14 edit
> > >=20
