X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8A975.4CB86A08@onstor-exch02.onstor.net>; Mon, 28 Apr 2008 14:17:44 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 29000
Date: Mon, 28 Apr 2008 14:17:44 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C959E@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C959B@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 29000
Thread-Index: Acipb5rA4GVK11QgSpGYpGppVxuINAABH82wAAA4k0A=
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>,
	"Andy Sharp" <andy.sharp@onstor.com>

Forgot to ask, what tests were run on these changes?
(Complying with new review/check-in requirements...)=20

-----Original Message-----
From: Larry Scheer=20
Sent: Monday, April 28, 2008 2:09 PM
To: Andy Sharp
Subject: RE: please review 29000

nfx-tree/code/ssc-nfxsh/cmd_flash.c

     Looks good

nfx-tree/code/ssc-nfxsh/linux.h

     Looks good


nfx-tree/code/ssc-nfxsh/openbsd.h

     Looks good

-----Original Message-----
From: Andy Sharp=20
Sent: Monday, April 28, 2008 1:37 PM
To: Larry Scheer
Subject: Re: please review 29000

On Mon, 28 Apr 2008 12:36:29 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> nfx-tree/code/ssc-nfxsh/linux.h
>=20
>      Line 105: I don't understand the reason for while (0) {}. --
>      Just curious...

Allows you to put a semicolon at the end of the macro, making it look
more like real code.  Adds just a touch of readability.  I could just
put curly braces around the whole thing, but I hate that.

Which reminds me, I forgot to add nfx-tree/code/ssc-nfxsh/cmd_flash.c
to this changelist.  Duh.

Resubmit.

> nfx-tree/code/ssc-nfxsh/openbsd.h
>=20
>      Line 94: I see the while (0) {} again so it must be intentional;
>      what does this do?
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Monday, April 28, 2008 10:33 AM
> To: Larry Scheer
> Subject: please review 29000
>=20
> Change 29000 by andys@ripper on 2008/04/28 10:30:59 *pending*
>=20
>         TED 23181 Cougar:system config reset does not bring back the
> root
>         or admin password to default value
>        =20
>         Output the error messages to the console as well as the log
>         so that the user is aware something didn't go right.
>        =20
>         reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#14 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#14 edit
>=20
