X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8A950.45671F20@onstor-exch02.onstor.net>; Mon, 28 Apr 2008 09:52:40 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28916
Date: Mon, 28 Apr 2008 09:52:40 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624ABC@onstor-exch02.onstor.net>
In-Reply-To: <20080428091412.208a960e@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28916
Thread-Index: AcipSuWF723y+1MbR4m7FjKFkUxezgABQUdg
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

An alternative would be to use curly braces around the whole block of
OS_VAR_CLEAN macro code.  But suppose you could leave be.


-----Original Message-----
From: Andy Sharp=20
Sent: Monday, April 28, 2008 9:14 AM
To: Rendell Fong
Subject: Re: please review 28916

It's so a semicolon can be used at the end of the macro.  Looks better
that way.

On Mon, 28 Apr 2008 08:42:25 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

>=20
> Looks ok except as noted.
>=20
> Linux.h: line 111  What is the "while (0) {}" for ?  Doesn't look
> necessary.
> Openbsd.h: line 99  ditto
>=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Saturday, April 26, 2008 5:39 PM
> To: Rendell Fong
> Subject: please review 28916
>=20
> Change 28916 by andys@ripper on 2008/04/22 14:59:46 *pending*
>=20
> 	TED00023367 - /var full after system config reset
> =09
> 	Add code to clean out /var/log and subdirectories
> 	and /var/onstor, as well as core files in /var/log
> 	and /var/run.
> =09
> 	reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#14 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#13 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#13 edit
>=20
