X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8A946.74E753E8@onstor-exch02.onstor.net>; Mon, 28 Apr 2008 08:42:25 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28916
Date: Mon, 28 Apr 2008 08:42:25 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624AB8@onstor-exch02.onstor.net>
In-Reply-To: <20080426173907.3aa8aa5a@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28916
Thread-Index: Acin/xs2TYCYMQpMQ0q76Oty4jtDhgBRuc8g
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>


Looks ok except as noted.

Linux.h: line 111  What is the "while (0) {}" for ?  Doesn't look
necessary.
Openbsd.h: line 99  ditto


-----Original Message-----
From: Andy Sharp=20
Sent: Saturday, April 26, 2008 5:39 PM
To: Rendell Fong
Subject: please review 28916

Change 28916 by andys@ripper on 2008/04/22 14:59:46 *pending*

	TED00023367 - /var full after system config reset
=09
	Add code to clean out /var/log and subdirectories
	and /var/onstor, as well as core files in /var/log
	and /var/run.
=09
	reviewed by

Affected files ...

... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#14 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#13 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#13 edit

