X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8A4C4.F5632BA0@onstor-exch02.onstor.net>; Tue, 22 Apr 2008 15:05:21 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C8A4C4.F5632BA0"
Content-class: urn:content-classes:message
Subject: RE: please review 28864
Date: Tue, 22 Apr 2008 15:05:21 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E03E9A7E1@onstor-exch02.onstor.net>
In-Reply-To: <20080422101202.35679ff7@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28864
Thread-Index: Acikm/vC6n1sb8FbSuKFgQNcsuFi6AAIuvRg
From: "Chris Vandever" <chris.vandever@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C8A4C4.F5632BA0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Well, that was fun.  My p4v refused to show me any files beyond
cluster-vintf-api.h for some obscure reason.  Thankfully, killing it and
restarting a new one did the trick, but it's certainly frustrating when
the tools don't frickin' work!

code/ssc-cluster/cluster-vsvr-api.c:
*	@5973 would you rename this cluster_getVsMgmtId() for
consistency?  Thanks.
*	@5979 cluster_getFilerMgmtVsvr() requires 2 + N clusDb accesses.
Instead you can just call cluster_getVsMgmtName(), pass the name to
cluster_makeVsvrNameKey(), and then read the record data via
cluster_getRecordDataByKey().  The record data is the vsId.  This would
take a single clusDb lookup.

ChrisV

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, April 22, 2008 10:12 AM
To: Chris Vandever
Cc: Rendell Fong
Subject: please review 28864

Chris,

I am sending this to you because I want you to review the changes to
the cluster api.  You don't have to look at the other files, but you're
certainly welcome to if you want to ~:^)

Rendell,

Same goes for you, except the two patch files for exim4.  Again, you're
welcome to look at the rest as well.

Thanks,

a



Change 28864 by andys@ripper on 2008/04/17 12:57:47 *pending*

	TED00023344 - autosupport from secondary cluster node not
working
=09
	Properly obtain the mgmt vsvr id from the cluster API and
	query the DNS with it.
=09
	Add a method to the cluster API to return the management vsvr
id.
=09
	Fix the change that was supposed to shut up the paniclog noise
	by putting a regex into /etc/default/exim4 that matches
anything.
=09
	reviewed by

Affected files ...

... //depot/dev/linux/Pkgs/binary/Deb/exim4-base_4.63-17_mipsel.deb#5
edit
... //depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb#2
edit
...
//depot/dev/linux/Pkgs/binary/Deb/exim4-daemon-custom_4.63-17_mipsel.deb
#6 edit
... //depot/dev/linux/Pkgs/source/exim4/debian.patch#6 edit
... //depot/dev/linux/Pkgs/source/exim4/onstor-vsvr-support.dpatch#2
edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#7 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.h#4 edit


------_=_NextPart_001_01C8A4C4.F5632BA0
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Dus-ascii">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: please review 28864</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/rtf format -->

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">Well, =
that was fun.</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&nbsp; My p4v refused to =
show me any files beyond cluster-vintf-api.h for some obscure =
reason.&nbsp; Thankfully, killing it and restarting a new one did the =
trick, but it</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&#8217;</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">s certainly frustrating when the tools =
don</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT =
SIZE=3D2 FACE=3D"Arial">&#8217;</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">t frickin</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Arial">&#8217;</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial"> work!</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">code/ssc-cluster/cluster-vsvr-api.c:</FONT></SPAN></P>

<P><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Symbol">&#183;<FONT =
FACE=3D"Courier =
New">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</FONT></FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> =
<FONT SIZE=3D2 FACE=3D"Arial">@5973 would you rename this =
cluster_getVsMgmtId() for consistency?</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">&nbsp; Thanks.</FONT></SPAN>

<BR><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Symbol">&#183;<FONT =
FACE=3D"Courier =
New">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</FONT></FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> <FONT SIZE=3D2 =
FACE=3D"Arial">@5979 cluster_getFilerMgmtVsvr() requires 2 + N clusDb =
accesses.</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us">&nbsp;<FONT SIZE=3D2 FACE=3D"Arial"> Instead you can just =
call cluster_getVsMgmtName(), pass the name to</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"> <FONT SIZE=3D2 =
FACE=3D"Arial">cluster_makeVsvrNameKey(), and then</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial"> read the record data via =
cluster_getRecordDataByKey().</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN><SPAN LANG=3D"en-us">&nbsp;<FONT SIZE=3D2 =
FACE=3D"Arial"> The record data is the vsId.&nbsp; This would take a =
single clusDb lookup.</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 =
FACE=3D"Arial">ChrisV</FONT></SPAN><SPAN LANG=3D"en-us"></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Tuesday, April 22, 2008 10:12 AM<BR>
To: Chris Vandever<BR>
Cc: Rendell Fong<BR>
Subject: please review 28864</FONT></SPAN><SPAN =
LANG=3D"en-us"></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">Chris,</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">I am sending this to you because I want you to review the changes =
to</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">the cluster api.&nbsp; You don't have to look at the other files, =
but you're</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">certainly welcome to if you want to ~:^)</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">Rendell,</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">Same goes for you, except the two patch files for exim4.&nbsp; =
Again, you're</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">welcome to look at the rest as well.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">Thanks,</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">a</FONT></SPAN></P>
<BR>
<BR>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">Change 28864 by andys@ripper on 2008/04/17 12:57:47 =
*pending*</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <FONT SIZE=3D2 =
FACE=3D"Courier New">TED00023344 - autosupport from secondary cluster =
node not working</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <FONT SIZE=3D2 =
FACE=3D"Courier New">Properly obtain the mgmt vsvr id from the cluster =
API and</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <FONT SIZE=3D2 =
FACE=3D"Courier New">query the DNS with it.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <FONT SIZE=3D2 =
FACE=3D"Courier New">Add a method to the cluster API to return the =
management vsvr id.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <FONT SIZE=3D2 =
FACE=3D"Courier New">Fix the change that was supposed to shut up the =
paniclog noise</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <FONT SIZE=3D2 =
FACE=3D"Courier New">by putting a regex into /etc/default/exim4 that =
matches anything.</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </SPAN></P>

<P ALIGN=3DLEFT><SPAN =
LANG=3D"en-us">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <FONT SIZE=3D2 =
FACE=3D"Courier New">reviewed by</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">Affected files ...</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">... =
//depot/dev/linux/Pkgs/binary/Deb/exim4-base_4.63-17_mipsel.deb#5 =
edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">... =
//depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb#2 =
edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">... =
//depot/dev/linux/Pkgs/binary/Deb/exim4-daemon-custom_4.63-17_mipsel.deb#=
6 edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">... //depot/dev/linux/Pkgs/source/exim4/debian.patch#6 =
edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">... =
//depot/dev/linux/Pkgs/source/exim4/onstor-vsvr-support.dpatch#2 =
edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#7 =
edit</FONT></SPAN></P>

<P ALIGN=3DLEFT><SPAN LANG=3D"en-us"><FONT SIZE=3D2 FACE=3D"Courier =
New">... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.h#4 =
edit</FONT></SPAN></P>

</BODY>
</HTML>
------_=_NextPart_001_01C8A4C4.F5632BA0--
