X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8A4AB.305BE690@onstor-exch02.onstor.net>; Tue, 22 Apr 2008 12:00:53 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28864
Date: Tue, 22 Apr 2008 12:00:53 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624AAB@onstor-exch02.onstor.net>
In-Reply-To: <20080422101202.35679ff7@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28864
Thread-Index: Acikm/vC6n1sb8FbSuKFgQNcsuFi6AAC62fg
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>,
	"Chris Vandever" <chris.vandever@onstor.com>

cluster-vsvr-api.c: line 5958 - description comments need to be updated
                    line 5966 - return value comments also need updating

cluster-vsvr-api.h: ok

onstor-vsvr-support.dpatch: line 41: hard coded constant being used
instead of RMC_SET_APP_VERS().  Is this due to #include conflicts or
complications? You might want to add comments regarding use of this
value at minimum or use a local #define.=20

debian.patch: line 1309 - I don't follow what this change is about.


-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, April 22, 2008 10:12 AM
To: Chris Vandever
Cc: Rendell Fong
Subject: please review 28864

Chris,

I am sending this to you because I want you to review the changes to
the cluster api.  You don't have to look at the other files, but you're
certainly welcome to if you want to ~:^)

Rendell,

Same goes for you, except the two patch files for exim4.  Again, you're
welcome to look at the rest as well.

Thanks,

a



Change 28864 by andys@ripper on 2008/04/17 12:57:47 *pending*

	TED00023344 - autosupport from secondary cluster node not
working
=09
	Properly obtain the mgmt vsvr id from the cluster API and
	query the DNS with it.
=09
	Add a method to the cluster API to return the management vsvr
id.
=09
	Fix the change that was supposed to shut up the paniclog noise
	by putting a regex into /etc/default/exim4 that matches
anything.
=09
	reviewed by

Affected files ...

... //depot/dev/linux/Pkgs/binary/Deb/exim4-base_4.63-17_mipsel.deb#5
edit
... //depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb#2
edit
...
//depot/dev/linux/Pkgs/binary/Deb/exim4-daemon-custom_4.63-17_mipsel.deb
#6 edit
... //depot/dev/linux/Pkgs/source/exim4/debian.patch#6 edit
... //depot/dev/linux/Pkgs/source/exim4/onstor-vsvr-support.dpatch#2
edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#7 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.h#4 edit

