X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C89E8E.3418EC68@onstor-exch02.onstor.net>; Mon, 14 Apr 2008 17:18:17 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28801
Date: Mon, 14 Apr 2008 17:18:17 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624A8F@onstor-exch02.onstor.net>
In-Reply-To: <20080414171716.2ae5e6c5@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28801
Thread-Index: AciejhLenPDZPtEeQlWBth8Gps4fLQAAA17A
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Ok.

-----Original Message-----
From: Andy Sharp=20
Sent: Monday, April 14, 2008 5:17 PM
To: Rendell Fong
Subject: Re: please review 28801

On Mon, 14 Apr 2008 17:07:12 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> See comments below.
>=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Monday, April 14, 2008 1:32 PM
> To: Rendell Fong
> Subject: please review 28801
>=20
> Change 28801 by andys@ripper on 2008/04/11 16:03:02 *pending*
>=20
>         TED00023303 - System config restore command fails on BSD
>        =20
>         Straighten out the call trail of ensure_fs_writable() and
>         restore_fs_permissions() which I think I mangled in a series
> of disconnected checkins.
>        =20
>         Quiet down emrscron on BSD when it tries to kill all emrscron
>         processes.  It still kills itself (on BSD), but who cares,
> it's at the end of a function, and the next step is "exit 0" anyway.
>        =20
>         Quiet down modify-cron call from cmd_flash.c.
>        =20
>         Regression focus:
>         * FTI - copy config from secondary flash
>         * system config reset
>         * system config copy
>         * system config restore
>         * system copy all
>         * system upgrade -p
>         * system upgrade -s
>        =20
>         reviewed by
>=20
> Affected files ...
>=20
> >> //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#9
> >> edit
>=20
> Lines 1815-1816: Comment can be removed since it no longer applies


Fixed.


> >> //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#13 edit
>=20
> Ok
>=20
> >> //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#27 edit
>=20
> Lines 1906, 1912: If an error occurs, execution will goto done from
> these lines and call restore_fs_permissions() without ever calling
> ensure_fs_writable() beforehand.  I don't know if this is will be
> problematic or not.  So I'm just pointing it out in case.

I moved ensure_blah() up just in case, because although I didn't get
the error message "error opening file" for the upgrade log, it makes me
nervous.

> >> //depot/dev/nfx-tree/code/ssc-support/emrscron#19 edit
>=20
> Ok
>=20
> >> //depot/dev/nfx-tree/code/ssc-zebra/fs-vector.c#4 edit
>=20
> Ok
>=20
