X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8A7F9.AB4935B8@onstor-exch02.onstor.net>; Sat, 26 Apr 2008 17:00:14 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C8A7F9.AB4935B8"
References: <20080414162122.20bfc8ef@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E09624A8B@onstor-exch02.onstor.net> <20080425194435.3d41ce75@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: please review 28800
Date: Sat, 26 Apr 2008 16:59:35 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E0149B6A9@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28800
Thread-Index: AcinR3gr59EBnMVVRSCdj6WlEyrnzAAshwbB
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C8A7F9.AB4935B8
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Let me know when you need it.
Rendell


-----Original Message-----
From: Andy Sharp
Sent: Fri 4/25/2008 7:44 PM
To: Rendell Fong
Subject: Re: please review 28800
=20
On Mon, 14 Apr 2008 16:27:19 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> You can try it on 10.2.6.7 after it comes up since I'm reboot it now.
> It has a few volumes.

Hi Rendell, say, does this offer still stand?  I never got a chance to
test this crapola before.

Thanks,

a

> -----Original Message-----
> From: Andy Sharp=20
> Sent: Monday, April 14, 2008 4:21 PM
> To: Rendell Fong
> Subject: Re: please review 28800
>=20
> On Mon, 14 Apr 2008 16:11:55 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
>=20
> > I guess I'm missing something.  If p doesn't change for each
> > iteration of the while loop how does it ever exit the loop?
>=20
> No, you're not missing anything, which is good.
>=20
> Fixed.
>=20
> I don't suppose you have any filers this code could be run on?  None
> of my filers have storage.
>=20
> >=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Monday, April 14, 2008 4:01 PM
> > To: Rendell Fong
> > Subject: Re: please review 28800
> >=20
> > On Mon, 14 Apr 2008 15:34:41 -0700 "Rendell Fong"
> > <rendell.fong@onstor.com> wrote:
> >=20
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit
> > >=20
> > > Line 2078:  Why delete (p++)?  Doesn't p need to increment to
> > > check each char in location string?
> >=20
> > The idea was that, in my estimation, the checking of each component
> > to see if it's individually too long was silly overkill, because I
> > suspect the individual component max is the same as the overall path
> > max.  It was checking the length of each component, and that was
> > passing, but having 100 directories deep was blowing up something
> > below it.
> >=20
> > So instead I changed it to check the overall path-max, which it
> > wasn't doing, and to check and make sure it didn't have more than 25
> > (arbitrary) directory components, which would be excessive in my
> > mind.
> >=20
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit
> > >=20
> > > Lines 4437-4448:=20
> > >   What's the initial value of p and count? =20
> > >   Doesn't p need to increment to check each char in location
> > > string?
> >=20
> > Same as above, only I fixed the uninitialized variables bug.
> > =20
> > =20
> > > -----Original Message-----
> > > From: Tim Gardner=20
> > > Sent: Monday, April 14, 2008 2:57 PM
> > > To: Rendell Fong
> > > Subject: FW: please review 28800
> > >=20
> > > =20
> > > Rendell,
> > >=20
> > > Can you please do this review.
> > > Thanks.
> > >=20
> > > Tim
> > >=20
> > > -----Original Message-----
> > > From: Andy Sharp=20
> > > Sent: Monday, April 14, 2008 2:52 PM
> > > To: Tim Gardner
> > > Subject: please review 28800
> > >=20
> > > Change 28800 by andys@ripper on 2008/04/11 15:59:26 *pending*
> > >=20
> > >         TED00023327 - Bus error audit export command with long
> > > path name=20
> > >         Egregiously long path name or number of directory
> > > components not being checked for in argument parsing.
> > >        =20
> > >         reviewed by
> > >=20
> > > Affected files ...
> > >=20
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit
> > >=20


------_=_NextPart_001_01C8A7F9.AB4935B8
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: please review 28800</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>Let me know when you need it.<BR>
Rendell<BR>
<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Fri 4/25/2008 7:44 PM<BR>
To: Rendell Fong<BR>
Subject: Re: please review 28800<BR>
<BR>
On Mon, 14 Apr 2008 16:27:19 -0700 &quot;Rendell Fong&quot;<BR>
&lt;rendell.fong@onstor.com&gt; wrote:<BR>
<BR>
&gt; You can try it on 10.2.6.7 after it comes up since I'm reboot it =
now.<BR>
&gt; It has a few volumes.<BR>
<BR>
Hi Rendell, say, does this offer still stand?&nbsp; I never got a chance =
to<BR>
test this crapola before.<BR>
<BR>
Thanks,<BR>
<BR>
a<BR>
<BR>
&gt; -----Original Message-----<BR>
&gt; From: Andy Sharp<BR>
&gt; Sent: Monday, April 14, 2008 4:21 PM<BR>
&gt; To: Rendell Fong<BR>
&gt; Subject: Re: please review 28800<BR>
&gt;<BR>
&gt; On Mon, 14 Apr 2008 16:11:55 -0700 &quot;Rendell Fong&quot;<BR>
&gt; &lt;rendell.fong@onstor.com&gt; wrote:<BR>
&gt;<BR>
&gt; &gt; I guess I'm missing something.&nbsp; If p doesn't change for =
each<BR>
&gt; &gt; iteration of the while loop how does it ever exit the =
loop?<BR>
&gt;<BR>
&gt; No, you're not missing anything, which is good.<BR>
&gt;<BR>
&gt; Fixed.<BR>
&gt;<BR>
&gt; I don't suppose you have any filers this code could be run =
on?&nbsp; None<BR>
&gt; of my filers have storage.<BR>
&gt;<BR>
&gt; &gt;<BR>
&gt; &gt; -----Original Message-----<BR>
&gt; &gt; From: Andy Sharp<BR>
&gt; &gt; Sent: Monday, April 14, 2008 4:01 PM<BR>
&gt; &gt; To: Rendell Fong<BR>
&gt; &gt; Subject: Re: please review 28800<BR>
&gt; &gt;<BR>
&gt; &gt; On Mon, 14 Apr 2008 15:34:41 -0700 &quot;Rendell =
Fong&quot;<BR>
&gt; &gt; &lt;rendell.fong@onstor.com&gt; wrote:<BR>
&gt; &gt;<BR>
&gt; &gt; &gt; ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 =
edit<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; Line 2078:&nbsp; Why delete (p++)?&nbsp; Doesn't p need =
to increment to<BR>
&gt; &gt; &gt; check each char in location string?<BR>
&gt; &gt;<BR>
&gt; &gt; The idea was that, in my estimation, the checking of each =
component<BR>
&gt; &gt; to see if it's individually too long was silly overkill, =
because I<BR>
&gt; &gt; suspect the individual component max is the same as the =
overall path<BR>
&gt; &gt; max.&nbsp; It was checking the length of each component, and =
that was<BR>
&gt; &gt; passing, but having 100 directories deep was blowing up =
something<BR>
&gt; &gt; below it.<BR>
&gt; &gt;<BR>
&gt; &gt; So instead I changed it to check the overall path-max, which =
it<BR>
&gt; &gt; wasn't doing, and to check and make sure it didn't have more =
than 25<BR>
&gt; &gt; (arbitrary) directory components, which would be excessive in =
my<BR>
&gt; &gt; mind.<BR>
&gt; &gt;<BR>
&gt; &gt; &gt; ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 =
edit<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; Lines 4437-4448:<BR>
&gt; &gt; &gt;&nbsp;&nbsp; What's the initial value of p and =
count?&nbsp;<BR>
&gt; &gt; &gt;&nbsp;&nbsp; Doesn't p need to increment to check each =
char in location<BR>
&gt; &gt; &gt; string?<BR>
&gt; &gt;<BR>
&gt; &gt; Same as above, only I fixed the uninitialized variables =
bug.<BR>
&gt; &gt;&nbsp;<BR>
&gt; &gt;&nbsp;<BR>
&gt; &gt; &gt; -----Original Message-----<BR>
&gt; &gt; &gt; From: Tim Gardner<BR>
&gt; &gt; &gt; Sent: Monday, April 14, 2008 2:57 PM<BR>
&gt; &gt; &gt; To: Rendell Fong<BR>
&gt; &gt; &gt; Subject: FW: please review 28800<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt;&nbsp;<BR>
&gt; &gt; &gt; Rendell,<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; Can you please do this review.<BR>
&gt; &gt; &gt; Thanks.<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; Tim<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; -----Original Message-----<BR>
&gt; &gt; &gt; From: Andy Sharp<BR>
&gt; &gt; &gt; Sent: Monday, April 14, 2008 2:52 PM<BR>
&gt; &gt; &gt; To: Tim Gardner<BR>
&gt; &gt; &gt; Subject: please review 28800<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; Change 28800 by andys@ripper on 2008/04/11 15:59:26 =
*pending*<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
TED00023327 - Bus error audit export command with long<BR>
&gt; &gt; &gt; path name<BR>
&gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Egregiously long path name or number of directory<BR>
&gt; &gt; &gt; components not being checked for in argument parsing.<BR>
&gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR>
&gt; &gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; reviewed =
by<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; Affected files ...<BR>
&gt; &gt; &gt;<BR>
&gt; &gt; &gt; ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 =
edit<BR>
&gt; &gt; &gt; ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 =
edit<BR>
&gt; &gt; &gt;<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C8A7F9.AB4935B8--
