X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C89E87.15076050@onstor-exch02.onstor.net>; Mon, 14 Apr 2008 16:27:19 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28800
Date: Mon, 14 Apr 2008 16:27:19 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624A8B@onstor-exch02.onstor.net>
In-Reply-To: <20080414162122.20bfc8ef@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28800
Thread-Index: AciehkHw/kSkAm0XQouqZiyIJ5hp1gAAIv6g
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

You can try it on 10.2.6.7 after it comes up since I'm reboot it now.
It has a few volumes.


-----Original Message-----
From: Andy Sharp=20
Sent: Monday, April 14, 2008 4:21 PM
To: Rendell Fong
Subject: Re: please review 28800

On Mon, 14 Apr 2008 16:11:55 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> I guess I'm missing something.  If p doesn't change for each iteration
> of the while loop how does it ever exit the loop?

No, you're not missing anything, which is good.

Fixed.

I don't suppose you have any filers this code could be run on?  None of
my filers have storage.

>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Monday, April 14, 2008 4:01 PM
> To: Rendell Fong
> Subject: Re: please review 28800
>=20
> On Mon, 14 Apr 2008 15:34:41 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
>=20
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit
> >=20
> > Line 2078:  Why delete (p++)?  Doesn't p need to increment to check
> > each char in location string?
>=20
> The idea was that, in my estimation, the checking of each component to
> see if it's individually too long was silly overkill, because I
> suspect the individual component max is the same as the overall path
> max.  It was checking the length of each component, and that was
> passing, but having 100 directories deep was blowing up something
> below it.
>=20
> So instead I changed it to check the overall path-max, which it
> wasn't doing, and to check and make sure it didn't have more than 25
> (arbitrary) directory components, which would be excessive in my mind.
>=20
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit
> >=20
> > Lines 4437-4448:=20
> >   What's the initial value of p and count? =20
> >   Doesn't p need to increment to check each char in location string?
>=20
> Same as above, only I fixed the uninitialized variables bug.
> =20
> =20
> > -----Original Message-----
> > From: Tim Gardner=20
> > Sent: Monday, April 14, 2008 2:57 PM
> > To: Rendell Fong
> > Subject: FW: please review 28800
> >=20
> > =20
> > Rendell,
> >=20
> > Can you please do this review.
> > Thanks.
> >=20
> > Tim
> >=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Monday, April 14, 2008 2:52 PM
> > To: Tim Gardner
> > Subject: please review 28800
> >=20
> > Change 28800 by andys@ripper on 2008/04/11 15:59:26 *pending*
> >=20
> >         TED00023327 - Bus error audit export command with long path
> > name=20
> >         Egregiously long path name or number of directory components
> >         not being checked for in argument parsing.
> >        =20
> >         reviewed by
> >=20
> > Affected files ...
> >=20
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit
> >=20
