X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C89E7F.BB3CD64D@onstor-exch02.onstor.net>; Mon, 14 Apr 2008 15:34:41 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28800
Date: Mon, 14 Apr 2008 15:34:41 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E09624A89@onstor-exch02.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E096B1BD1@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28800
Thread-Index: AcieebnR4qiZP56eS4Wld3PEMx/ZXQAALBmAAAD/rRA=
From: "Rendell Fong" <rendell.fong@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>

... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit

Line 2078:  Why delete (p++)?  Doesn't p need to increment to check each
char in location string?

... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit

Lines 4437-4448:=20
  What's the initial value of p and count? =20
  Doesn't p need to increment to check each char in location string?



-----Original Message-----
From: Tim Gardner=20
Sent: Monday, April 14, 2008 2:57 PM
To: Rendell Fong
Subject: FW: please review 28800

=20
Rendell,

Can you please do this review.
Thanks.

Tim

-----Original Message-----
From: Andy Sharp=20
Sent: Monday, April 14, 2008 2:52 PM
To: Tim Gardner
Subject: please review 28800

Change 28800 by andys@ripper on 2008/04/11 15:59:26 *pending*

        TED00023327 - Bus error audit export command with long path name
       =20
        Egregiously long path name or number of directory components
        not being checked for in argument parsing.
       =20
        reviewed by

Affected files ...

... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit

