X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C899D6.D45C3A00@onstor-exch02.onstor.net>; Tue, 8 Apr 2008 17:15:34 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28660 - should be a quickie
Date: Tue, 8 Apr 2008 17:15:34 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9540@onstor-exch02.onstor.net>
In-Reply-To: <20080408162836.0f2833e1@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28660 - should be a quickie
Thread-Index: AciZ0ETh9iIcy+w3Twmj5xD0ybUCPwABnwuA
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Looks good

-----Original Message-----
From: Andy Sharp=20
Sent: Tuesday, April 08, 2008 4:29 PM
To: Larry Scheer
Subject: Re: please review 28660 - should be a quickie

OK, this turned out not to be a quick one.

Take a look now.  I didn't add the >/dev/null because it only csh
outputs that message about no match.  [k]sh simply echoes /*bc.bin LGI.


On Tue, 8 Apr 2008 11:34:03 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Oh, and yes, the way your tests were written it would work on a bobcat
> but not a cheetah.
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Tuesday, April 08, 2008 10:17 AM
> To: Larry Scheer
> Subject: Re: please review 28660 - should be a quickie
>=20
> On Mon, 7 Apr 2008 23:41:01 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
>=20
> > If you just remove the Images directory then flash_install won't
> > work on a cheetah. You will always be returning 1 from
> > sanity_check_soft_dir() on a cheetah. Here is part of what is wrong"
> > From a cheetah:
> > athena# echo /*bc.bin | wc -c
> > echo: No match.
> >        0=20
> > From a bobcat:
> > eng216# echo /*bc.bin | wc -c
> >       35
>=20
> Dude, what do you have on your system?  It doesn't match 35 files on
> my system, just three files fc_bc.bin, txrx_bc.bin, and fp_bc.bin.
>=20
> >=20
> > This test is always true on both bobcat and cheetah
> >   if [ `echo /*bc.bin | wc -c` !=3D 3 ]=20
> >=20
> > If I go by the comment on line 166 then I presume you want line 165
> > to be: if [ `echo /*bc.bin 2>/dev/null | wc -c` =3D 35 ] ; then
>=20
> You must have a lot of images on your system!  Perhaps I should change
> it to:
>=20
> if [ `echo /*bc.bin 2>/dev/null | wc -c` !=3D 0 ] ; then
>=20
> > I took the liberty to redirect standard error to avoid the potential
> > of noise displaying on the console.
>=20
> That's a good point, I will add that.
>=20
> > It you want to test your change on a cheetah you can use 10.2.17.1
> > (athena) or 10.2.18.1 (minerva). Please don't blow away their
> > configurations and cluster db.
>=20
> That sounds like what I need to do.
>=20
> > If you need a bobcat to test flash_install you can use 10.2.11.4
> > (eng216) again please preserve the configuration and cluster
> > database.
>=20
> I did test on a Bobcat already, it works there.  I installed first
> with the old flash_install, then with the new, worked fine.
>=20
> > Larry
> >=20
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Mon 4/7/2008 5:03 PM
> > To: Larry Scheer
> > Subject: Re: please review 28660 - should be a quickie
> > =20
> > You must have been thinking of your proposal when the phrase
> > "...make no sense" came to mind.  The only thing I had to change,
> > if I understand your point, was the removal of the Images directory,
> > which, hey, I don't know, I was just guessing.  That's why I sent it
> > to you for reviewing.
> >=20
> > Fixed.  As long as the only thing that needed fixing was getting rid
> > of the Images directory.
> >=20
> >=20
> > On Mon, 7 Apr 2008 16:24:17 -0700 "Larry Scheer"
> > <larry.scheer@onstor.com> wrote:
> >=20
> > > Lines 165 through 173 make no sense. On a cheetah ssc-mgmt.bin is
> > > located in $1/ssc-mgmt.bin not in Images. There is no ssc-mgmt.bin
> > > anywhere for bobcat.
> > >=20
> > > So I think you meant to write:
> > >=20
> > > if [ `echo /*bc.bin | wc -c` =3D 3] ; then
> > >  # if on a bobcat, don't install cheetah distro
> > >  if [ $1/ssc-mgmt.bin ] ; then
> > >     return 1
> > >  fi
> > > # must be on a cheetah ?
> > > elif [ ! -e $1/ssc-mgmt.bin ] ; then
> > >     return 1
> > > fi=20
> > >=20
> > > -----Original Message-----
> > > From: Andy Sharp=20
> > > Sent: Monday, April 07, 2008 3:51 PM
> > > To: Larry Scheer
> > > Subject: Re: please review 28660 - should be a quickie
> > >=20
> > > Alright, added some code, but since I don't have a cheetah, I
> > > don't know if it's right.  So please re-review.
> > >=20
> > >=20
> > > On Fri, 4 Apr 2008 19:54:56 -0700 "Larry Scheer"
> > > <larry.scheer@onstor.com> wrote:
> > >=20
> > > > nfx-tree/Tools/flash_install.sh
> > > >=20
> > > >      This will prevent a cheetah or bobcat build from being
> > > > installed on a cougar.  But it won't stop a cheetah release from
> > > > being installed on a bobcat. Which is fine if that was all you
> > > > wanted to at this time
> > > >=20
> > > >      If you want to go one step further a cheetah has this file:
> > > >      /ssc-mgmt.bin and bobcats do not. You could test for the
> > > > existence of ssc-mgmt.bin if you know you are running on a
> > > > cheetah or a bobcat.
> > > >=20
> > > > -----Original Message-----
> > > > From: Andy Sharp=20
> > > > Sent: Thursday, April 03, 2008 2:36 PM
> > > > To: Larry Scheer
> > > > Subject: please review 28660 - should be a quickie
> > > >=20
> > > > A quickie, hopefully:
> > > >=20
> > > > Change 28660 by andys@ripper on 2008/04/03 14:34:48 *pending*
> > > >=20
> > > >         Bolster sanity check that should prevent installing BSD
> > > > onto a Linux based system, and vice-versa.
> > > >        =20
> > > >         reviewed by
> > > >=20
> > > > Affected files ...
> > > >=20
> > > > ... //depot/dev/nfx-tree/Tools/flash_install.sh#11 edit
> > > >=20
> >=20
