X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C89943.82DED410@onstor-exch02.onstor.net>; Mon, 7 Apr 2008 23:41:01 -0700
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C89943.82DED410"
References: <20080407155033.5f07e017@ripper.onstor.net><BB375AF679D4A34E9CA8DFA650E2B04E056C9536@onstor-exch02.onstor.net> <20080407170343.2763f205@ripper.onstor.net>
Content-class: urn:content-classes:message
Subject: RE: please review 28660 - should be a quickie
Date: Mon, 7 Apr 2008 23:41:01 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E042F0147@onstor-exch02.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28660 - should be a quickie
Thread-Index: AciZDAMmQmOEbqb3RZqI+dWkOFMpmAAMrd6Q
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

This is a multi-part message in MIME format.

------_=_NextPart_001_01C89943.82DED410
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

If you just remove the Images directory then flash_install won't work on =
a cheetah.
You will always be returning 1 from sanity_check_soft_dir() on a =
cheetah.
Here is part of what is wrong"
From a cheetah:
athena# echo /*bc.bin | wc -c
echo: No match.
       0=20
From a bobcat:
eng216# echo /*bc.bin | wc -c
      35=20

This test is always true on both bobcat and cheetah
  if [ `echo /*bc.bin | wc -c` !=3D 3 ]=20

If I go by the comment on line 166 then I presume you want line 165 to =
be:
   if [ `echo /*bc.bin 2>/dev/null | wc -c` =3D 35 ] ; then

I took the liberty to redirect standard error to avoid the potential of =
noise displaying on the console.

It you want to test your change on a cheetah you can use 10.2.17.1 =
(athena) or 10.2.18.1 (minerva). Please don't blow away their =
configurations and cluster db.

If you need a bobcat to test flash_install you can use 10.2.11.4 =
(eng216) again please preserve the configuration and cluster database.

Larry

-----Original Message-----
From: Andy Sharp
Sent: Mon 4/7/2008 5:03 PM
To: Larry Scheer
Subject: Re: please review 28660 - should be a quickie
=20
You must have been thinking of your proposal when the phrase "...make no
sense" came to mind.  The only thing I had to change, if I understand
your point, was the removal of the Images directory, which, hey, I
don't know, I was just guessing.  That's why I sent it to you for
reviewing.

Fixed.  As long as the only thing that needed fixing was getting rid of
the Images directory.


On Mon, 7 Apr 2008 16:24:17 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Lines 165 through 173 make no sense. On a cheetah ssc-mgmt.bin is
> located in $1/ssc-mgmt.bin not in Images. There is no ssc-mgmt.bin
> anywhere for bobcat.
>=20
> So I think you meant to write:
>=20
> if [ `echo /*bc.bin | wc -c` =3D 3] ; then
>  # if on a bobcat, don't install cheetah distro
>  if [ $1/ssc-mgmt.bin ] ; then
>     return 1
>  fi
> # must be on a cheetah ?
> elif [ ! -e $1/ssc-mgmt.bin ] ; then
>     return 1
> fi=20
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Monday, April 07, 2008 3:51 PM
> To: Larry Scheer
> Subject: Re: please review 28660 - should be a quickie
>=20
> Alright, added some code, but since I don't have a cheetah, I don't
> know if it's right.  So please re-review.
>=20
>=20
> On Fri, 4 Apr 2008 19:54:56 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
>=20
> > nfx-tree/Tools/flash_install.sh
> >=20
> >      This will prevent a cheetah or bobcat build from being
> > installed on a cougar.  But it won't stop a cheetah release from
> > being installed on a bobcat. Which is fine if that was all you
> > wanted to at this time
> >=20
> >      If you want to go one step further a cheetah has this file:
> >      /ssc-mgmt.bin and bobcats do not. You could test for the
> > existence of ssc-mgmt.bin if you know you are running on a cheetah
> > or a bobcat.
> >=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Thursday, April 03, 2008 2:36 PM
> > To: Larry Scheer
> > Subject: please review 28660 - should be a quickie
> >=20
> > A quickie, hopefully:
> >=20
> > Change 28660 by andys@ripper on 2008/04/03 14:34:48 *pending*
> >=20
> >         Bolster sanity check that should prevent installing BSD
> > onto a Linux based system, and vice-versa.
> >        =20
> >         reviewed by
> >=20
> > Affected files ...
> >=20
> > ... //depot/dev/nfx-tree/Tools/flash_install.sh#11 edit
> >=20


------_=_NextPart_001_01C89943.82DED410
Content-Type: text/html;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; =
charset=3Diso-8859-1">
<META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version =
6.5.7653.38">
<TITLE>RE: please review 28660 - should be a quickie</TITLE>
</HEAD>
<BODY>
<!-- Converted from text/plain format -->

<P><FONT SIZE=3D2>If you just remove the Images directory then =
flash_install won't work on a cheetah.<BR>
You will always be returning 1 from sanity_check_soft_dir() on a =
cheetah.<BR>
Here is part of what is wrong&quot;<BR>
From a cheetah:<BR>
athena# echo /*bc.bin | wc -c<BR>
echo: No match.<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 0<BR>
From a bobcat:<BR>
eng216# echo /*bc.bin | wc -c<BR>
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 35<BR>
<BR>
This test is always true on both bobcat and cheetah<BR>
&nbsp; if [ `echo /*bc.bin | wc -c` !=3D 3 ]<BR>
<BR>
If I go by the comment on line 166 then I presume you want line 165 to =
be:<BR>
&nbsp;&nbsp; if [ `echo /*bc.bin 2&gt;/dev/null | wc -c` =3D 35 ] ; =
then<BR>
<BR>
I took the liberty to redirect standard error to avoid the potential of =
noise displaying on the console.<BR>
<BR>
It you want to test your change on a cheetah you can use 10.2.17.1 =
(athena) or 10.2.18.1 (minerva). Please don't blow away their =
configurations and cluster db.<BR>
<BR>
If you need a bobcat to test flash_install you can use 10.2.11.4 =
(eng216) again please preserve the configuration and cluster =
database.<BR>
<BR>
Larry<BR>
<BR>
-----Original Message-----<BR>
From: Andy Sharp<BR>
Sent: Mon 4/7/2008 5:03 PM<BR>
To: Larry Scheer<BR>
Subject: Re: please review 28660 - should be a quickie<BR>
<BR>
You must have been thinking of your proposal when the phrase =
&quot;...make no<BR>
sense&quot; came to mind.&nbsp; The only thing I had to change, if I =
understand<BR>
your point, was the removal of the Images directory, which, hey, I<BR>
don't know, I was just guessing.&nbsp; That's why I sent it to you =
for<BR>
reviewing.<BR>
<BR>
Fixed.&nbsp; As long as the only thing that needed fixing was getting =
rid of<BR>
the Images directory.<BR>
<BR>
<BR>
On Mon, 7 Apr 2008 16:24:17 -0700 &quot;Larry Scheer&quot;<BR>
&lt;larry.scheer@onstor.com&gt; wrote:<BR>
<BR>
&gt; Lines 165 through 173 make no sense. On a cheetah ssc-mgmt.bin =
is<BR>
&gt; located in $1/ssc-mgmt.bin not in Images. There is no =
ssc-mgmt.bin<BR>
&gt; anywhere for bobcat.<BR>
&gt;<BR>
&gt; So I think you meant to write:<BR>
&gt;<BR>
&gt; if [ `echo /*bc.bin | wc -c` =3D 3] ; then<BR>
&gt;&nbsp; # if on a bobcat, don't install cheetah distro<BR>
&gt;&nbsp; if [ $1/ssc-mgmt.bin ] ; then<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp; return 1<BR>
&gt;&nbsp; fi<BR>
&gt; # must be on a cheetah ?<BR>
&gt; elif [ ! -e $1/ssc-mgmt.bin ] ; then<BR>
&gt;&nbsp;&nbsp;&nbsp;&nbsp; return 1<BR>
&gt; fi<BR>
&gt;<BR>
&gt; -----Original Message-----<BR>
&gt; From: Andy Sharp<BR>
&gt; Sent: Monday, April 07, 2008 3:51 PM<BR>
&gt; To: Larry Scheer<BR>
&gt; Subject: Re: please review 28660 - should be a quickie<BR>
&gt;<BR>
&gt; Alright, added some code, but since I don't have a cheetah, I =
don't<BR>
&gt; know if it's right.&nbsp; So please re-review.<BR>
&gt;<BR>
&gt;<BR>
&gt; On Fri, 4 Apr 2008 19:54:56 -0700 &quot;Larry Scheer&quot;<BR>
&gt; &lt;larry.scheer@onstor.com&gt; wrote:<BR>
&gt;<BR>
&gt; &gt; nfx-tree/Tools/flash_install.sh<BR>
&gt; &gt;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; This will prevent a cheetah or =
bobcat build from being<BR>
&gt; &gt; installed on a cougar.&nbsp; But it won't stop a cheetah =
release from<BR>
&gt; &gt; being installed on a bobcat. Which is fine if that was all =
you<BR>
&gt; &gt; wanted to at this time<BR>
&gt; &gt;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; If you want to go one step =
further a cheetah has this file:<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /ssc-mgmt.bin and bobcats do =
not. You could test for the<BR>
&gt; &gt; existence of ssc-mgmt.bin if you know you are running on a =
cheetah<BR>
&gt; &gt; or a bobcat.<BR>
&gt; &gt;<BR>
&gt; &gt; -----Original Message-----<BR>
&gt; &gt; From: Andy Sharp<BR>
&gt; &gt; Sent: Thursday, April 03, 2008 2:36 PM<BR>
&gt; &gt; To: Larry Scheer<BR>
&gt; &gt; Subject: please review 28660 - should be a quickie<BR>
&gt; &gt;<BR>
&gt; &gt; A quickie, hopefully:<BR>
&gt; &gt;<BR>
&gt; &gt; Change 28660 by andys@ripper on 2008/04/03 14:34:48 =
*pending*<BR>
&gt; &gt;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Bolster sanity =
check that should prevent installing BSD<BR>
&gt; &gt; onto a Linux based system, and vice-versa.<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR>
&gt; &gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; reviewed =
by<BR>
&gt; &gt;<BR>
&gt; &gt; Affected files ...<BR>
&gt; &gt;<BR>
&gt; &gt; ... //depot/dev/nfx-tree/Tools/flash_install.sh#11 edit<BR>
&gt; &gt;<BR>
<BR>
</FONT>
</P>

</BODY>
</HTML>
------_=_NextPart_001_01C89943.82DED410--
