X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C894FB.9B97E058@onstor-exch02.onstor.net>; Wed, 2 Apr 2008 12:56:14 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Code review 28626
Date: Wed, 2 Apr 2008 12:56:14 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C951E@onstor-exch02.onstor.net>
In-Reply-To: <20080402103730.38f917d6@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Code review 28626
Thread-Index: AciU6DoBCr0UJmYTQTabFXxUEY3LwwAEShbA
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Andy,
   These changes look fine to me. I thought about making the Linux
timezone stuff follow the same model used in BSD but when I saw that Tim
had already made changes that followed the Debian Linux way of setting
up the time zone files in etc/onstor/initial-config there was no need to
make any changes. The conclusion I came to is: we should do it the
Debian Linux way on Lunix and let BSD be. Looks like Sripal is following
the Linux Debian way with these changes for Linux and preserving the BSD
method for the legacy systems.

Larry

-----Original Message-----
From: Andy Sharp=20
Sent: Wednesday, April 02, 2008 10:38 AM
To: Larry Scheer
Subject: Fw: Code review 28626

Hi Larry,

Could you review this change?  I've reviewed it once, and I think
everything is OK except I'm still not sure about the removed function
from initial-config.c.  He says it can't be portable, but I thought you
had some thoughts to the opposite.  Something like we could do a
symlink on Linux just like OpenBSD does.  Let me know what you think.

I put a note next to the review comment I'm talking about.



Begin forwarded message:

Date: Wed, 02 Apr 2008 22:25:51 +0530
From: Sripal <sripal.surendiran@onstor.com>
To: Andrew Sharp <andy.sharp@onstor.com>
Subject: Re: Code review


Andy,

Since FTI code is merged to dev branch, I moved my changes to dev
branch.

New change id: 28626

Also see my inline comments below

Thanks,
Sripal.

Andrew Sharp wrote:
> Aha, I reviewed it but then thought I would have someone else look at
> it too, but then forgot to tell that person.  My bad.
>
> Anyway, I thought about it some more and I think my review is good
> enough.  Here it is:
>
>
> nfx-tree/code/ssc-genlib/genlib-linux.c
>
>
>      looks ok, but why are these in genlib?  are they cli used only
>      functions?  if so, they can go in ssc-nfxsh/cmd_system*.c or
>      something like that.  hmm, i'm thinking you used them in
>      initial-config as well.
> Sripal>>You are correct.
>
> nfx-tree/code/ssc-genlib/genlib-openbsd.c
>
>
>      line 196, instead of all this snprintf stuff, can you use
>      do_system()?
> Sripal>>Done
>
> nfx-tree/code/ssc-genlib/genlib.h
>
>
>      line 136,158, even though someone has been violating this,
>      function declarations should be all one line with their type:
>
>      int foo(args);
>
>      as opposed to
>
>      int
>      foo(args);
>
>      whereas function definitions should be the opposite.
> Sripal>>Done
>
> nfx-tree/code/ssc-initial-config/initial-config.c
>

I'm still not convinced the following routing can't be portable, but I
know you've put some quality time in on this issue, so I thought I
would get your feedback on it.

>      line 282, it seems like this removed routine,
>      initconf_modifyTimeZone should work fine for Linux as well as
> BSD? if so, then the other functions can be moved into libnfxsh?
> Sripal>>No. In openbsd, we link /etc/localtime to actual time zone
> Sripal>>file in /usr/share/zoneinfo/. But in Linux, we copy the
> Sripal>>actual time zone file to /etc/localtime. We also enter the
> Sripal>>zone name to /etc/timezone file. This difference has actually
> Sripal>>created bug in FTI.
>
> nfx-tree/code/ssc-nfxsh/cmd_system-linux.c
>
>
>      ok
>
>
> nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c
>
>
>      ok
>
>
> nfx-tree/code/ssc-nfxsh/cmd_system.c
>
>
>      looks good
>
>
>
>
>
> On Sat, 29 Mar 2008 13:34:44 +0530 Sripal
> <sripal.surendiran@onstor.com> wrote:
>
>  =20
>> Gentle reminder.....
>>
>> -Sripal.
>>
>> Sripal wrote:
>>    =20
>>> Andy,
>>>
>>> I have made changes to genlib files as a part of fixing bug=20
>>> TED00022994 (Timezone entered in FTI does not show up in cli=20
>>> commands). Request you review the modified files.
>>>
>>> Change id : 28533
>>>
>>> Thanks,
>>> Sripal.
>>>
>>>      =20
