X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C89043.6CB05F78@onstor-exch02.onstor.net>; Thu, 27 Mar 2008 12:47:44 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: please review 28529
Date: Thu, 27 Mar 2008 12:47:44 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9502@onstor-exch02.onstor.net>
In-Reply-To: <20080327123751.1298b86d@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: please review 28529
Thread-Index: AciQQgvVxt+0MvQnQQepVHhrOIeoUgAAVNqQ
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Re-reviewed; looks good

-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, March 27, 2008 12:38 PM
To: Larry Scheer
Subject: Re: please review 28529

On Thu, 27 Mar 2008 11:49:42 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> linux/rootfs/etc/mdrive_fstab
>=20
>      looks good
>=20
> nfx-tree/Tools/flash_install.sh
>=20
>      Line 521: Looks like $1 is ${disk}${part} this would result in
>      a syntax error from expr.

Hmm, coulda sworn that worked fine when I tested it.  Oh well, fixed.

> nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c
>=20
>      Line 276: Subtracting 18 from integers 1, 3, and 4? Don't you
>      want to add 30 as you intended in flash_install.sh? If not what
>      am I missing?

You are missing that it's a char. '1' =3D=3D 49 decimal; 49 - 18 =3D=3D =
31
in shell, '1' and 1 are the same ~:^)

> -----Original Message-----
> From: Andy Sharp=20
> Sent: Wednesday, March 26, 2008 8:55 PM
> To: Larry Scheer
> Subject: please review 28529
>=20
> Change 28529 by andys@ripper on 2008/03/26 19:09:45 *pending*
>=20
>         TED00022813 - EXT3-fs warning: maximal mount count reached
>        =20
>         Add fsck pass #1 to all mounted CF file systems: e2fsck will
>         serialize them as they are all on the same "disk."  e2fsck
>         will not check the filesystem if it is marked clean unless it
>         surpasses the maximum mount count, which will hopefully be
> rare on production systems.  The max mount count will be left at the
>         default 31 for the moment.  Turn off the maximum time setting
>         in flash_install and _system copy init_.
>        =20
>         reviewed by
>=20
> Affected files ...
>=20
> ... //depot/dev/linux/rootfs/etc/mdrive_fstab#1 edit
> ... //depot/dev/nfx-tree/Tools/flash_install.sh#10 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#15 edit
>=20
