X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C8906F.766D8D18@onstor-exch02.onstor.net>; Thu, 27 Mar 2008 18:02:58 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review change 28526 -dmalloc package
Date: Thu, 27 Mar 2008 18:02:58 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9507@onstor-exch02.onstor.net>
In-Reply-To: <20080327175735.71a4a370@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review change 28526 -dmalloc package
Thread-Index: AciQbrY7HxJJAF6ySCO1jvjVrVoNlAAABt0g
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

Ok got rid of line 93.
Dmalloc builds a c++ library so g++ is needed. What else would gcc point
to? Well you said you didn't know what I meant about links... sounded
like you wanted the instructions written on the heel so that is what I
did. Maybe I need TO TALK LOUDER

-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, March 27, 2008 5:58 PM
To: Larry Scheer
Subject: Re: Please review change 28526 -dmalloc package

On Thu, 27 Mar 2008 17:19:45 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Ok I added the changes. I see what you meant by move the cd out. I
> lost track of that and didn't see what you did in the exim4 Makefile.

Line 93, you still have cd PKG_BASE in there.

What else would gcc point to besides gcc-4.1?  We don't need g++ at all.

> -----Original Message-----
> From: Andy Sharp=20
> Sent: Thursday, March 27, 2008 4:51 PM
> To: Larry Scheer
> Subject: Re: Please review change 28526 -dmalloc package
>=20
> linux/Pkgs/binary/Deb/libdmalloc-dev-mipsel-cross_5.5.1-1_all.deb
>=20
>=20
>      looks good
>=20
>=20
> linux/Pkgs/binary/Deb/libdmalloc-dev_5.5.1-1_mipsel.deb
>=20
>=20
>      looks good
>=20
>=20
> linux/Pkgs/binary/Deb/libdmalloc5-mipsel-cross_5.5.1-1_all.deb
>=20
>=20
>      looks good
>=20
>=20
> linux/Pkgs/binary/Deb/libdmalloc5_5.5.1-1_mipsel.deb
>=20
>=20
>      looks good
>=20
>=20
> linux/Pkgs/binary/Rpm/libdmalloc-dev-mipsel-cross-5.5.1-2.noarch.rpm
>=20
>=20
>      looks good
>=20
>=20
> linux/Pkgs/binary/Rpm/libdmalloc5-mipsel-cross-5.5.1-2.noarch.rpm
>=20
>=20
>      looks good
>=20
>=20
> linux/Pkgs/source/dmalloc/Makefile
>=20
>=20
>      >>add linux/Pkgs/source/dmalloc/Makefile
>=20
>      	line 68, please fix trailing whitespace.
>=20
>      	line 99, move the cd $(PKG_BASE) out, like I did in
>      	exim4/Makefile, so you don't have to keep repeating it.
> 	her?  like so:
>=20
> 	@cd $(PKG_BASE) && \
> 	pkgver=3D$(shell dpkg-parsechangelog | fgrep Version: \
> 	  | awk -F': ' '{print $$NF}') ; \
> 	case $$pkgver in \
> 		[0-9]:*) \
> 			ep=3D`echo $$pkgver | cut -d : -f 1` ; \
> 			ver=3D`echo $$pkgver | cut -d : -f 2`; \
> 			epoch=3D`expr $$ep + 1` ; \
> 			dch 'Onstor fixes for use of memset in
> re-entrant signal handlers' \
> 			--newversion $${epoch}:$${ver} ; \
> 			;; \
> 		*) \
> 			dch 'Onstor fixed for recursion' \
> 			--newversion 1:$$pkgver ; \
> 			;; \
> 	esac
>=20
>=20
>      	line 91, even better, thanks.
>=20
>      	line 18, "also links for gcc and g++ to correct compiler
>         (or just apt-get install g++)" - what do you mean?
>=20
>=20
> linux/Pkgs/source/dmalloc/debianrules.patch
>=20
>=20
>      >>add linux/Pkgs/source/dmalloc/debianrules.patch
>=20
>      	looks good
>=20
>=20
> linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz
>=20
>=20
>      >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz
>=20
>=20
> linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc
>=20
>=20
>      >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc
>=20
>=20
> linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz
>=20
>=20
>      >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz
>=20
>=20
> linux/Pkgs/source/dmalloc/onstor-src.dpatch
>=20
>=20
>      >>add linux/Pkgs/source/dmalloc/onstor-src.dpatch
>=20
>      	looks good
>=20
>=20
>=20
> On Thu, 27 Mar 2008 16:29:11 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
>=20
> > I updated dmalloc/Makefile have another look. My comments are in
> > line below.
> >=20
> > -----Original Message-----
> > From: Andy Sharp=20
> > Sent: Thursday, March 27, 2008 2:22 PM
> > To: Larry Scheer
> > Subject: Re: Please review change 28526 -dmalloc package
> >=20
> > linux/Pkgs/binary/Deb/libdmalloc-dev-mipsel-cross_5.5.1-1_all.deb
> >=20
> >      looks good
> >=20
> > linux/Pkgs/binary/Deb/libdmalloc-dev_5.5.1-1_mipsel.deb
> >=20
> >      looks good
> >=20
> > linux/Pkgs/binary/Deb/libdmalloc5-mipsel-cross_5.5.1-1_all.deb
> >=20
> >      looks good
> >=20
> > linux/Pkgs/binary/Deb/libdmalloc5_5.5.1-1_mipsel.deb
> >=20
> >      looks good
> >=20
> > linux/Pkgs/binary/Rpm/libdmalloc-dev-mipsel-cross-5.5.1-2.noarch.rpm
> >=20
> >      looks good
> >=20
> > linux/Pkgs/binary/Rpm/libdmalloc5-mipsel-cross-5.5.1-2.noarch.rpm
> >=20
> >      looks good
> >=20
> > linux/Pkgs/source/dmalloc/Makefile
> >=20
> >      >>add linux/Pkgs/source/dmalloc/Makefile
> >=20
> >      	please fix trailing whitespace.
> > Fixed.
> >=20
> >      	line 31, i determined that this doesn't work.  see the
> >      	exim4 makefile for what i did instead, as i don't
> > remember anymore.  basically, make executes the $(error regardless
> >      	of shell if statements.
> > Fixed. Changed the target and rule to be a pattern match rule that
> > is generic to all Makefiles that we use in this source tree.
> >=20
> >      	line 43, you shouldn't need the '-1', i should think?
> >      	maybe i'm wrong about that.
> > Yes it is needed. I added a comment to state that.=20
> >=20
> >      	line 64, move the cd $(PKG_BASE) out line I did in
> >      	exim4/Makefile, so you don't have to keep repeating it.
> > No, I want 3 separate target rules. While debugging builds I often
> > use these in stages.=20
> >=20
> >      	line 65, it's just easier and seems to work better if
> >      	you say awk '{print $$2}'.  no -F needed.
> > No, Read the comment I need to do that if the package already has an
> > epoch number. The separator is a colon and a space. I did that
> > because I ran into trouble using just '{print $$2}'.
> >=20
> >      	line 72, make the comment a bit more meaningful.
> > anyway, i think you meant something more like 'onstor fixes for
> >      	recursive code use.'
> > Check the comment now. I was just repeating what Max had in the
> > change list. It looks more like his changes were for re-entrant
> > signal handlers. I think he may have meant to say re-entrant rather
> > than recursive. At least that is what Rendell and I thought after
> > looking at his change. But I am open to changing it.
> >=20
> >      	Did you say this doesn't cross-build?  If it has to
> >      	be built on a filer, add comments to that effect.
> >      	Regardless of that, add comment(s) to list any build
> >      	dependencies that are "unusual" for this package, if
> > any. Added comments at the top. Let me know if this is what you had
> > in mind.
> >=20
> > linux/Pkgs/source/dmalloc/debianrules.patch
> >=20
> >      >>add linux/Pkgs/source/dmalloc/debianrules.patch
> >=20
> >      	line 37, duh, trailing whitespace
> > Fixed.
> >=20
> > linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz
> >=20
> >      >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz
> >=20
> > linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc
> >=20
> >      >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc
> >=20
> > linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz
> >=20
> >      >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz
> >=20
> > linux/Pkgs/source/dmalloc/onstor-src.dpatch
> >=20
> >      >>add linux/Pkgs/source/dmalloc/onstor-src.dpatch
> >=20
> >=20
> >=20
> > On Wed, 26 Mar 2008 18:55:39 -0700 "Larry Scheer"
> > <larry.scheer@onstor.com> wrote:
> >=20
> > > Ok this  change is ready to review. I added :
> > >=20
> > > ... //depot/dev/linux/Pkgs/source/dmalloc/debianrules.patch#1 add
> > >=20
> > > To the change list.
> > >=20
> > > _____________________________________________
> > > From: Larry Scheer=20
> > > Sent: Wednesday, March 26, 2008 4:22 PM
> > > To: Andy Sharp
> > > Subject: Please review change 28526 -dmalloc package
> > >=20
> > > Change 28526 by larrys@larrys on 2008/03/26 16:21:05 *pending*
> > >=20
> > >         Files to re-build the libdmalloc package with ONStor
> > > changes. Adds
> > >         the Makefile, onstor patch file and specific source
> > > packages for the current release of the Cougar platform. This
> > > version of the source do not cross compile so build must be done
> > > on a MIPSEL system.
> > >=20
> > >         Updating pre-built debian packages and cross packages in
> > > both debian and
> > >         rpm format that have Max's fix for re-entrant code (memset
> > > in signal
> > >         handler.)
> > >         Reviewed by: AndyS
> > >=20
> > > Affected files ...
> > >=20
> > > ...
> > >
> >
>
//depot/dev/linux/Pkgs/binary/Deb/libdmalloc-dev-mipsel-cross_5.5.1-1_al
> > > l.deb#1 edit
> > > ...
> > >
> //depot/dev/linux/Pkgs/binary/Deb/libdmalloc-dev_5.5.1-1_mipsel.deb#1
> > > edit
> > > ...
> > >
> >
>
//depot/dev/linux/Pkgs/binary/Deb/libdmalloc5-mipsel-cross_5.5.1-1_all.d
> > > eb#1 edit
> > > ...
> //depot/dev/linux/Pkgs/binary/Deb/libdmalloc5_5.5.1-1_mipsel.deb#1
> > > edit
> > > ...
> > >
> >
>
//depot/dev/linux/Pkgs/binary/Rpm/libdmalloc-dev-mipsel-cross-5.5.1-2.no
> > > arch.rpm#1 edit
> > > ...
> > >
> >
>
//depot/dev/linux/Pkgs/binary/Rpm/libdmalloc5-mipsel-cross-5.5.1-2.noarc
> > > h.rpm#1 edit
> > > ... //depot/dev/linux/Pkgs/source/dmalloc/Makefile#1 add
> > > ...
//depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz#1
> > > add ...
//depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc#1
> > > add ...
> > //depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz#1
> > > add
> > > ... //depot/dev/linux/Pkgs/source/dmalloc/onstor-src.dpatch#1 add
