X-MimeOLE: Produced By Microsoft Exchange V6.5
Received: by onstor-exch02.onstor.net 
	id <01C89062.5C893FC8@onstor-exch02.onstor.net>; Thu, 27 Mar 2008 16:29:11 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-class: urn:content-classes:message
Subject: RE: Please review change 28526 -dmalloc package
Date: Thu, 27 Mar 2008 16:29:11 -0700
Message-ID: <BB375AF679D4A34E9CA8DFA650E2B04E056C9504@onstor-exch02.onstor.net>
In-Reply-To: <20080327142202.000fdec0@ripper.onstor.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Please review change 28526 -dmalloc package
Thread-Index: AciQUJnL8p1uZdO3RjqCTkfY03JMzgAD8qMQ
From: "Larry Scheer" <larry.scheer@onstor.com>
To: "Andy Sharp" <andy.sharp@onstor.com>

I updated dmalloc/Makefile have another look. My comments are in line
below.

-----Original Message-----
From: Andy Sharp=20
Sent: Thursday, March 27, 2008 2:22 PM
To: Larry Scheer
Subject: Re: Please review change 28526 -dmalloc package

linux/Pkgs/binary/Deb/libdmalloc-dev-mipsel-cross_5.5.1-1_all.deb

     looks good

linux/Pkgs/binary/Deb/libdmalloc-dev_5.5.1-1_mipsel.deb

     looks good

linux/Pkgs/binary/Deb/libdmalloc5-mipsel-cross_5.5.1-1_all.deb

     looks good

linux/Pkgs/binary/Deb/libdmalloc5_5.5.1-1_mipsel.deb

     looks good

linux/Pkgs/binary/Rpm/libdmalloc-dev-mipsel-cross-5.5.1-2.noarch.rpm

     looks good

linux/Pkgs/binary/Rpm/libdmalloc5-mipsel-cross-5.5.1-2.noarch.rpm

     looks good

linux/Pkgs/source/dmalloc/Makefile

     >>add linux/Pkgs/source/dmalloc/Makefile

     	please fix trailing whitespace.
Fixed.

     	line 31, i determined that this doesn't work.  see the
     	exim4 makefile for what i did instead, as i don't remember
     	anymore.  basically, make executes the $(error regardless
     	of shell if statements.
Fixed. Changed the target and rule to be a pattern match rule that is
generic to all Makefiles that we use in this source tree.

     	line 43, you shouldn't need the '-1', i should think?
     	maybe i'm wrong about that.
Yes it is needed. I added a comment to state that.=20

     	line 64, move the cd $(PKG_BASE) out line I did in
     	exim4/Makefile, so you don't have to keep repeating it.
No, I want 3 separate target rules. While debugging builds I often use
these in stages.=20

     	line 65, it's just easier and seems to work better if
     	you say awk '{print $$2}'.  no -F needed.
No, Read the comment I need to do that if the package already has an
epoch number. The separator is a colon and a space. I did that because I
ran into trouble using just '{print $$2}'.

     	line 72, make the comment a bit more meaningful.  anyway,
     	i think you meant something more like 'onstor fixes for
     	recursive code use.'
Check the comment now. I was just repeating what Max had in the change
list. It looks more like his changes were for re-entrant signal
handlers. I think he may have meant to say re-entrant rather than
recursive. At least that is what Rendell and I thought after looking at
his change. But I am open to changing it.

     	Did you say this doesn't cross-build?  If it has to
     	be built on a filer, add comments to that effect.
     	Regardless of that, add comment(s) to list any build
     	dependencies that are "unusual" for this package, if any.
Added comments at the top. Let me know if this is what you had in mind.

linux/Pkgs/source/dmalloc/debianrules.patch

     >>add linux/Pkgs/source/dmalloc/debianrules.patch

     	line 37, duh, trailing whitespace
Fixed.

linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz

     >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz

linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc

     >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc

linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz

     >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz

linux/Pkgs/source/dmalloc/onstor-src.dpatch

     >>add linux/Pkgs/source/dmalloc/onstor-src.dpatch



On Wed, 26 Mar 2008 18:55:39 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Ok this  change is ready to review. I added :
>=20
> ... //depot/dev/linux/Pkgs/source/dmalloc/debianrules.patch#1 add
>=20
> To the change list.
>=20
> _____________________________________________
> From: Larry Scheer=20
> Sent: Wednesday, March 26, 2008 4:22 PM
> To: Andy Sharp
> Subject: Please review change 28526 -dmalloc package
>=20
> Change 28526 by larrys@larrys on 2008/03/26 16:21:05 *pending*
>=20
>         Files to re-build the libdmalloc package with ONStor changes.
> Adds
>         the Makefile, onstor patch file and specific source packages
> for the current release of the Cougar platform. This version of the
>         source do not cross compile so build must be done on a MIPSEL
> system.
>=20
>         Updating pre-built debian packages and cross packages in both
> debian and
>         rpm format that have Max's fix for re-entrant code (memset in
> signal
>         handler.)
>         Reviewed by: AndyS
>=20
> Affected files ...
>=20
> ...
>
//depot/dev/linux/Pkgs/binary/Deb/libdmalloc-dev-mipsel-cross_5.5.1-1_al
> l.deb#1 edit
> ...
> //depot/dev/linux/Pkgs/binary/Deb/libdmalloc-dev_5.5.1-1_mipsel.deb#1
> edit
> ...
>
//depot/dev/linux/Pkgs/binary/Deb/libdmalloc5-mipsel-cross_5.5.1-1_all.d
> eb#1 edit
> ... //depot/dev/linux/Pkgs/binary/Deb/libdmalloc5_5.5.1-1_mipsel.deb#1
> edit
> ...
>
//depot/dev/linux/Pkgs/binary/Rpm/libdmalloc-dev-mipsel-cross-5.5.1-2.no
> arch.rpm#1 edit
> ...
>
//depot/dev/linux/Pkgs/binary/Rpm/libdmalloc5-mipsel-cross-5.5.1-2.noarc
> h.rpm#1 edit
> ... //depot/dev/linux/Pkgs/source/dmalloc/Makefile#1 add
> ... //depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz#1
> add ... //depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc#1
> add ...
//depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz#1
> add
> ... //depot/dev/linux/Pkgs/source/dmalloc/onstor-src.dpatch#1 add
